From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755992AbdKCPuZ (ORCPT ); Fri, 3 Nov 2017 11:50:25 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:46377 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753880AbdKCPuW (ORCPT ); Fri, 3 Nov 2017 11:50:22 -0400 X-Google-Smtp-Source: ABhQp+RX710mH8XPbLJd11mMbdmvhU+Ov0kCwM+aByNtJbPRit6JomnYi1oTs3CdI1xtLUydLr+9zw== Subject: Re: [PATCH] scsi: lpfc: fix kzalloc-simple.cocci warnings To: Vasyl Gomonovych , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dick.kennedy@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1507750961-26945-1-git-send-email-gomonovych@gmail.com> From: James Smart Message-ID: <0f4c9761-fdab-2311-62ad-f0cd7f432246@broadcom.com> Date: Fri, 3 Nov 2017 08:50:14 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1507750961-26945-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 12:42 PM, Vasyl Gomonovych wrote: > drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset > drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset > > Use kzalloc rather than kmalloc followed by memset with 0 > > Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/scsi/lpfc/lpfc_debugfs.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c > index d50c481..2bf5ad3 100644 > --- a/drivers/scsi/lpfc/lpfc_debugfs.c > +++ b/drivers/scsi/lpfc/lpfc_debugfs.c > @@ -2227,7 +2227,7 @@ > kfree(phba->nvmeio_trc); > > /* Allocate new trace buffer and initialize */ > - phba->nvmeio_trc = kmalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) * > + phba->nvmeio_trc = kzalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) * > sz), GFP_KERNEL); > if (!phba->nvmeio_trc) { > lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > @@ -2235,8 +2235,6 @@ > "nvmeio_trc buffer\n"); > return -ENOMEM; > } > - memset(phba->nvmeio_trc, 0, > - (sizeof(struct lpfc_debugfs_nvmeio_trc) * sz)); > atomic_set(&phba->nvmeio_trc_cnt, 0); > phba->nvmeio_trc_on = 0; > phba->nvmeio_trc_output_idx = 0; > @@ -5457,7 +5455,7 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, > phba->nvmeio_trc_size = lpfc_debugfs_max_nvmeio_trc; > > /* Allocate trace buffer and initialize */ > - phba->nvmeio_trc = kmalloc( > + phba->nvmeio_trc = kzalloc( > (sizeof(struct lpfc_debugfs_nvmeio_trc) * > phba->nvmeio_trc_size), GFP_KERNEL); > > @@ -5467,9 +5465,6 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes, > "nvmeio_trc buffer\n"); > goto nvmeio_off; > } > - memset(phba->nvmeio_trc, 0, > - (sizeof(struct lpfc_debugfs_nvmeio_trc) * > - phba->nvmeio_trc_size)); > phba->nvmeio_trc_on = 1; > phba->nvmeio_trc_output_idx = 0; > phba->nvmeio_trc = NULL; looks good. Signed-off-by:  James Smart