From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='
Date: Mon, 3 Jul 2023 11:56:40 +0200 [thread overview]
Message-ID: <0f4f5a4d-379b-c00c-6bf2-58c08fcc4551@linaro.org> (raw)
In-Reply-To: <ZKKXGE95Sv-eLQa8@hovoldconsulting.com>
On 3.07.2023 11:38, Johan Hovold wrote:
> On Mon, Jul 03, 2023 at 11:30:24AM +0200, Konrad Dybcio wrote:
>> On 2.07.2023 20:50, Krzysztof Kozlowski wrote:
>>> The DTS code coding style expects exactly one space before and after '='
>>> sign.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>
> [...]
>
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>> index 895cafc11480..c4209e2d4b4e 100644
>>> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>> @@ -155,7 +155,7 @@ CPU7: cpu@3 {
>>>
>>> idle-states {
>>> CPU_SLEEP_0: cpu-sleep-0 {
>>> - compatible ="qcom,idle-state-spc", "arm,idle-state";
>>> + compatible = "qcom,idle-state-spc", "arm,idle-state";
>> Will conflict with:
>>
>> https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@linaro.org/
>>
>> there are also a couple of entries with property =\n\t{n}[a-z]
>>
>> Otherwise lgtm
>
> Konrad, please remember to trim irrelevant context from your replies
> (e.g. so that we don't have to skim through thousands of lines to find
> a single comment).
My actual reply begins at line 77, which is considerably less than
thousands and is concluded by my signoff, which signifies the end
of the message.
Konrad
>
> Johan
next prev parent reply other threads:[~2023-07-03 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 18:50 Krzysztof Kozlowski
2023-07-02 18:50 ` [PATCH 2/2] ARM: " Krzysztof Kozlowski
2023-07-03 9:31 ` Konrad Dybcio
2023-07-03 9:30 ` [PATCH 1/2] arm64: " Konrad Dybcio
2023-07-03 9:38 ` Johan Hovold
2023-07-03 9:56 ` Konrad Dybcio [this message]
2023-07-03 10:06 ` Johan Hovold
2023-07-03 16:08 ` Krzysztof Kozlowski
2023-07-03 16:09 ` Krzysztof Kozlowski
2023-07-10 5:07 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f4f5a4d-379b-c00c-6bf2-58c08fcc4551@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®