From: Baolu Lu <baolu.lu@linux.intel.com>
To: Tina Zhang <tina.zhang@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Kevin Tian <kevin.tian@intel.com>
Cc: baolu.lu@linux.intel.com, Michael Shavit <mshavit@google.com>,
Vasant Hegde <vasant.hegde@amd.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/6] iommu/vt-d: Remove mm->pasid in intel_sva_bind_mm()
Date: Wed, 13 Sep 2023 10:25:16 +0800 [thread overview]
Message-ID: <0f4fb712-28e3-8620-6a65-59c9b9d77740@linux.intel.com> (raw)
In-Reply-To: <20230912125936.722348-3-tina.zhang@intel.com>
On 9/12/23 8:59 PM, Tina Zhang wrote:
> The pasid is passed in as a parameter through .set_dev_pasid() callback.
> Thus, intel_sva_bind_mm() can directly use it instead of retrieving the
> pasid value from mm->pasid.
>
> Suggested-by: Lu Baolu<baolu.lu@linux.intel.com>
> Signed-off-by: Tina Zhang<tina.zhang@intel.com>
> ---
> drivers/iommu/intel/svm.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
The intel_svm_bind_mm() could be further merged into
intel_svm_set_dev_pasid(). It's fine if you keep it as is since we need
more cleanup and refactoring work after this series get merged.
So,
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
next prev parent reply other threads:[~2023-09-13 2:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 12:59 [PATCH v4 0/6] Share sva domains with all devices bound to a mm Tina Zhang
2023-09-12 12:59 ` [PATCH v4 1/6] iommu: Add mm_get_enqcmd_pasid() helper function Tina Zhang
2023-09-12 12:59 ` [PATCH v4 2/6] iommu/vt-d: Remove mm->pasid in intel_sva_bind_mm() Tina Zhang
2023-09-13 2:25 ` Baolu Lu [this message]
2023-09-21 18:56 ` Jason Gunthorpe
2023-09-22 2:09 ` Tina Zhang
2023-09-12 12:59 ` [PATCH v4 3/6] iommu: Introduce mm_get_pasid() helper function Tina Zhang
2023-09-21 19:02 ` Jason Gunthorpe
2023-09-22 2:07 ` Tina Zhang
2023-09-12 12:59 ` [PATCH v4 4/6] mm: Add structure to keep sva information Tina Zhang
2023-09-13 2:38 ` Baolu Lu
2023-09-21 19:04 ` Jason Gunthorpe
2023-09-22 1:51 ` Tina Zhang
2023-09-12 12:59 ` [PATCH v4 5/6] iommu: Support mm PASID 1:n with sva domains Tina Zhang
2023-09-21 23:31 ` Jason Gunthorpe
2023-09-22 1:07 ` Tina Zhang
2023-09-12 12:59 ` [PATCH v4 6/6] mm: Deprecate pasid field Tina Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f4fb712-28e3-8620-6a65-59c9b9d77740@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=tina.zhang@intel.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®