From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753897AbcK0WOr (ORCPT ); Sun, 27 Nov 2016 17:14:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:56780 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbcK0WOl (ORCPT ); Sun, 27 Nov 2016 17:14:41 -0500 Subject: Re: [PATCH] ARM: dts: mvebu: Fix armada-385-turris-omnia stdout-path To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= References: <71af60f5-b657-cab4-32a8-00a604fc656e@suse.de> <1480275444-4220-1-git-send-email-afaerber@suse.de> <20161127212528.wmqbwciz5ltnfws3@pengutronix.de> Cc: linux-arm-kernel@lists.infradead.org, Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Tomas Hlavacek , Russell King , linux-kernel@vger.kernel.org, Rob Herring , Gregory Clement , Sebastian Hesselbarth , =?UTF-8?B?QmVkxZlpY2hhIEtvxaFhdHU=?= , Michal Hrusecki From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <0f51c7a1-6d52-3e3e-edfe-e7b10917ecab@suse.de> Date: Sun, 27 Nov 2016 23:14:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161127212528.wmqbwciz5ltnfws3@pengutronix.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.11.2016 um 22:25 schrieb Uwe Kleine-König: > On Sun, Nov 27, 2016 at 08:37:24PM +0100, Andreas Färber wrote: >> Specify the baudrate. >> >> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") >> Cc: Uwe Kleine-König >> Signed-off-by: Andreas Färber > > You said with plain &uart0 the kernel uses a wrong baud rate? That's > strange. For me it works and I think it's the intended behaviour to > dermine the baud rate setup by the bootloader and use this. IIRC the 8250 driver defaults to 9600n8 if unspecified. Kernel tested: 4.9.0-rc2-next-20161028-00010-g4fb44d9-dirty Maybe you used some console= argument overriding it? > I'd prefer it this way over hard coding the baud rate. > >> arch/arm/boot/dts/armada-385-turris-omnia.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts >> index f53cb8b73610..2eff012287d4 100644 >> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts >> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts >> @@ -52,7 +52,7 @@ >> compatible = "cznic,turris-omnia", "marvell,armada385", "marvell,armada380"; >> >> chosen { >> - stdout-path = &uart0; >> + stdout-path = "serial0:115200n8"; >> }; >> >> memory { > > This has the downside to depend on the alias. Not sure this is > considered modern. An alternative would be: > > stdout-path = "/soc/internal-regs/serial@12000:115200n8"; Please don't unroll the path I'm trying to abstract elsewhere. Like I said, the "serialX:115200n8" syntax is what all other Armada 38x boards use: git grep stdout-path -- arch/arm/boot/dts/ | grep armada-38 arch/arm/boot/dts/armada-385-db-ap.dts: stdout-path = "serial1:115200n8"; arch/arm/boot/dts/armada-385-linksys.dtsi: stdout-path = "serial0:115200n8"; arch/arm/boot/dts/armada-388-clearfog.dts: stdout-path = "serial0:115200n8"; arch/arm/boot/dts/armada-388-db.dts: stdout-path = "serial0:115200n8"; arch/arm/boot/dts/armada-388-gp.dts: stdout-path = "serial0:115200n8"; arch/arm/boot/dts/armada-388-rd.dts: stdout-path = "serial0:115200n8"; The alias is needed to reliably determine the tty device number and is set "globally" in armada-38x.dtsi, so why is it a problem to rely on? Regards, Andreas > > (maybe there even exists syntactic sugar to express this using &uart0?) -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)