From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041343B8959 for ; Mon, 23 Mar 2026 17:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774285587; cv=none; b=XXqnmzQYM/j1VCokpW6wRnZP+d36IbN2MOoW8/g6GDZPzS/q9yNJ5tNmZZAaQGi1VgGzw21Hvab3TjkKrSundUbK0xgwv8vKzXa2SzJCuta1UHXSFBLLAIXVjYakqM+QfNrRBz9oL6u7nr41FKJoG9pB4mXKscSAqo9TI3hQg0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774285587; c=relaxed/simple; bh=yf/N67gBIH9jH5tj/eBx49WDNNHqQ6d8Xw/4r6JAHCM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q5BvyQHYNFftkGUNdt8D9w9KNed7m0xdaFmoGwn4C0jD1z4VLw3ZDFmRKqHDHPjH9rh9bDMXIn99C+mgKnp7pSuApPVxRIIZ3tR+McVcAH+XuQ42uRTOZ11c2zKxI2vjHil1lbuuMX6DCREE4Wbceb8ANN5tx5MtDUcOcPz13Xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gBrtZotL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gBrtZotL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A2F4C4CEF7; Mon, 23 Mar 2026 17:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774285586; bh=yf/N67gBIH9jH5tj/eBx49WDNNHqQ6d8Xw/4r6JAHCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gBrtZotLvmRDKY8PUXJxAp1tBrQUR32dB9tYBqsNEny19g53OQ97CArY/anhs9zIS UZUfJEtN2iycEjxPmfE7T/4Qtx1BO5nDj5Uv4T6d5ECUvlLPIbJGcfKRjQ2brAtqOh CBY8PBJiJEtvER62PyFGdjhsUaCI6jmLV0kuqmXaOTYLg3Zj7bxrVCERdYBwjNRXSf G39opJMpfsEvC+DuINZiZ00MGyKg4yZk5OrpuKNQ29og8dXI13v2rdZovSgB9ID329 jGcJNl+HmB8DvfkJn2mSiLHYKCgwgTg7G9iZ7f2dSu4NFPLUQeNK/vuOgkHISiVfo1 KZaBDM/vav43A== Date: Mon, 23 Mar 2026 17:06:21 +0000 From: "Lorenzo Stoakes (Oracle)" To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, david@kernel.org, mhocko@kernel.org, zhengqi.arch@bytedance.com, yuzhao@google.com, shakeel.butt@linux.dev, willy@infradead.org, Liam.Howlett@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/vmscan: prevent MGLRU reclaim from pinning address space Message-ID: <0f599835-9b99-4457-9ba7-a3eaeb0768d1@lucifer.local> References: <20260322070843.941997-1-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 23, 2026 at 09:19:04AM -0700, Suren Baghdasaryan wrote: > On Mon, Mar 23, 2026 at 6:43 AM Lorenzo Stoakes (Oracle) wrote: > > > > On Sun, Mar 22, 2026 at 12:08:43AM -0700, Suren Baghdasaryan wrote: > > > When shrinking lruvec, MGLRU pins address space before walking it. > > > This is excessive since all it needs for walking the page range is > > > a stable mm_struct to be able to take and release mmap_read_lock and > > > a stable mm->mm_mt tree to walk. This address space pinning results > > > > Hmm, I guess exit_mmap() calls __mt_destroy(), but that'll just destroy > > allocated state and leave the tree empty right, so traversal of that tree > > at that point would just do nothing? > > Correct. And __mt_destroy() happens under mmap_write_lock while > traversal under mmap_read_lock, so they should not race. Yeah that's fair. > > > > > > in delays when releasing the memory of a dying process. This also > > > prevents mm reapers (both in-kernel oom-reaper and userspace > > > process_mrelease()) from doing their job during MGLRU scan because > > > they check task_will_free_mem() which will yield negative result due > > > to the elevated mm->mm_users. > > > > > > Replace unnecessary address space pinning with mm_struct pinning by > > > replacing mmget/mmput with mmgrab/mmdrop calls. mm_mt is contained > > > within mm_struct itself, therefore it won't be freed as long as > > > mm_struct is stable and it won't change during the walk because > > > mmap_read_lock is being held. > > > > > > Fixes: bd74fdaea146 ("mm: multi-gen LRU: support page table walks") > > > Signed-off-by: Suren Baghdasaryan Given you have cleared up my concerns, this LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > > > --- > > > mm/vmscan.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > > index 33287ba4a500..68e8e90e38f5 100644 > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -2863,8 +2863,9 @@ static struct mm_struct *get_next_mm(struct lru_gen_mm_walk *walk) > > > return NULL; > > > > Not related to this series, but I really don't like how coupled MGLRU is to > > the rest of the 'classic' reclaim code. > > > > Just in the middle of vmscan you walk into generic mm walker logic and the > > only hint it's MGLRU is you see lru_gen_xxx stuff (I'm also annoyed that we > > call it MGLRU but it's called lru_gen_xxx in the kernel :) > > I don't have a strong opinion on this. Perhaps the naming can be > changed outside of this series. I was thinking more of a new file for mglru :>) I believe we also need some more active maintainership also... but that's another issue ;) > > > > > > > > > clear_bit(key, &mm->lru_gen.bitmap); > > > + mmgrab(mm); > > > > Is the mm somehow pinned here or, on destruction, would move it from the mm > > list meaning that we can safely assume we have something sane in mm-> to > > grab? I guess this must have already been the case for mmget_not_zero() to > > have been used before though. > > Yes, mm is stable because it's fetched from mm_list. When mm is added > to this list via lru_gen_add_mm(mm) it is referenced and that > reference is dropped only after lru_gen_del_mm(mm) removes the mm from > this list (see https://elixir.bootlin.com/linux/v7.0-rc4/source/kernel/fork.c#L1185 > and https://elixir.bootlin.com/linux/v7.0-rc4/source/kernel/fork.c#L1187). > Addition, removal and retrieval from that list happen under > mm_list->lock which prevents races. Ack, thanks! > > > > > > > > > - return mmget_not_zero(mm) ? mm : NULL; > > > + return mm; > > > } > > > > > > void lru_gen_add_mm(struct mm_struct *mm) > > > @@ -3064,7 +3065,7 @@ static bool iterate_mm_list(struct lru_gen_mm_walk *walk, struct mm_struct **ite > > > reset_bloom_filter(mm_state, walk->seq + 1); > > > > > > if (*iter) > > > - mmput_async(*iter); > > > + mmdrop(*iter); > > > > This will now be a blocking call that could free the mm (via __mmdrop()), > > so could take a while, is that ok? > > mmdrop() should not be a heavy-weight operation. It simply destroys > the metadata associated with mm_struct. mmput() OTOH will call > exit_mmap() if it drops the last reference and that can take a while > because that's when we free the memory of the process. I believe > that's why mmput_async() was used here. Yeah that's fair enough! Thanks. > > > > > If before the code was intentionally deferring work here, doesn't that > > imply that being slow here might be an issue, somehow? Or was it just > > because they could? :) > > I think the reason was the possibility of calling mmput() -> __mmput() > -> exit_mmap(mm) which could indeed block us for a while. Yeah fair :) > > > > > > > > > *iter = mm; > > > > > > > > > base-commit: 8c65073d94c8b7cc3170de31af38edc9f5d96f0e > > > -- > > > 2.53.0.1018.g2bb0e51243-goog > > > > > > > Thanks, Lorenzo Cheers, Lorenzo