From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011052.outbound.protection.outlook.com [40.107.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D2D35DA64 for ; Wed, 1 Apr 2026 08:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.52 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775030623; cv=fail; b=h6zxb1vy3qkHn5xXi27fsYmCOn30XWxQYqEqUZn++VfS9WJfh26kZtG/T1ekuJR7UQOXiNwIV9SxSFZCi9XK3IVA5WTMTp2e/at+NSTI6XwH6bB/W3usVlBDCUI3NyQWEYtXj2cg0hXfkWSfekiT5fYEpDF+SeEAMLjFmBJu/bA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775030623; c=relaxed/simple; bh=C6ztvydIINyFL9f9W08kVBHnx1kaK3g7xMqgVDu5HXA=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=uY4ErC8dGEfN7Uzb4jVrT1xqaOTk64vgCCZhtqcPnZs1abhWsifTvLyFIgrQV67irxaDbayTYRa/VdBPfu9VgpoDSrfMpoT1P1IQfL2WsMDF0Nj/Jgj5vBUydmu5N53ywMILSvZEgUuJLjt7C1y0nFoGCVg9EQhzlS6v5hnEokM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=qIdp4ddw; arc=fail smtp.client-ip=40.107.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="qIdp4ddw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HTCK8THEDeQ0/4Afj3FJn8TlsaszZNemE/atqda+lDuhkjpgWdgARf6UHXawIWby8+tH6pBCpyvbmBkgtUtcft4PgcZv5Ff9uGrdVCMGn4NTI2CSyZALk84OZOk8CkQgJ4FaooSaVV06guOC68ATcD9IUiCHuMep7JUH6w659S6m8DGYrHEgqMbH7lLy97ueLZOrZVJ/3O+8SHQWGHd+jCz1oqdiFAtL26O/1WacEfKoULh7rgN+9C8gC5d4P7K1ZJygBk3Fg7PQFWsN952YQn42yL/Bd1Uvk809bFYKyaMgHhV7bsYDXvCDHeKmBM1yqw1d0TV2RUj4EbhmuJypQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dNhl1IfOlDFRkmPBfsX6L3nOAcNBmd1aTK0vJbLTCBs=; b=jh3q5u9LvQACxmIw/WbcqacoIaWgV7AG+B3ujkLO/TrcvxchBWg+Ki31tNS05+DnTop2kRo1ZkRHys7y3bwMAZzPNMHC0Q/TeuuF6HLH3xyT0PAPdk+Y/ginTT22K+D6LllANJKPIlRyS2sghFA/1NCh/ADGHNc4OElFL6WebVNA+JapusQ9/f8id80tuCNv/ar3g2lxM4pODJ2pZLMy+gt1LHog4v0/VAKFPXqQ1zHcvkgXccYvILIyc7tQp/H+6rmMqVZhUdy/aol+07M3SAAAqIl7UK3EtY8KUbpNz1+fV3NLf1g6USdkEZ+mJ7dkkEbiUyQERUp2U8vBsuummA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNhl1IfOlDFRkmPBfsX6L3nOAcNBmd1aTK0vJbLTCBs=; b=qIdp4ddwO2cJNO1qOiC8bHjiYQVnH5HZpD6C0aD9ugWlTwS8I1lU+4ymICKW1tI4cO80OH8sSivljsgiBdovgmAD0oXGmiJGq7RtAhCDrXAvIRKJ4MSTXKuCLslksJItBvQWey2P8ULFLGW9euqEPcdv1qRpqij7lyXTxMUoAqQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9194.namprd12.prod.outlook.com (2603:10b6:610:19f::7) by DM4PR12MB9734.namprd12.prod.outlook.com (2603:10b6:8:225::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.16; Wed, 1 Apr 2026 08:03:38 +0000 Received: from CH3PR12MB9194.namprd12.prod.outlook.com ([fe80::1e6b:ca8b:7715:6fee]) by CH3PR12MB9194.namprd12.prod.outlook.com ([fe80::1e6b:ca8b:7715:6fee%6]) with mapi id 15.20.9769.016; Wed, 1 Apr 2026 08:03:38 +0000 Message-ID: <0f5ddb00-fffb-4efc-b04c-80624ef94675@amd.com> Date: Wed, 1 Apr 2026 19:03:21 +1100 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] x86/sev: Remove bogus virtual address check To: Ard Biesheuvel , Borislav Petkov , Ard Biesheuvel , Eric Biggers Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Tom Lendacky References: <20251010151036.42241-2-ardb+git@google.com> <20260331131655.GAacvJR18jz5J30F8p@fat_crate.local> <991d5e3b-171d-4391-8a1d-b0ca4608ae32@app.fastmail.com> <86dc5dea-2ddc-44b4-b295-d34d87f53567@amd.com> From: Alexey Kardashevskiy Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SY8P282CA0026.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:29b::26) To CH3PR12MB9194.namprd12.prod.outlook.com (2603:10b6:610:19f::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9194:EE_|DM4PR12MB9734:EE_ X-MS-Office365-Filtering-Correlation-Id: b0c6f8c5-5f70-4963-d48d-08de8fc52e7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: wiTjwATaUPkkX3IL5jplA6VzAotqk4FGH+wluBuoHRl3CwhqehQ/7NWKi4rgli3x7+wYZORUUpYHxqaMnW4KYpOGdLIIQKLFuMO6jeJbBNzztbwodI00Ukb3g76b65IN/q4L6agNMfZQCHhitS26Cl7Wk4wLc7khveSxR37UzRJHMAdIfJm7gx2yqSb/719IbGt+PImioJmjnwk1qUGQikfxbh73qErPOEweOpiy2ukVX8gkXOO1bygtlXVqAtCQ+Uv+Yxm7AmKg4guwKjM8Q2zlSsgLwvLnGzzVrrfj9vexVdbXFWxGdXYahh5wWEzrCmHRiZfwNsmsDvtaiMo+GbaOPR1dDhFlRM39fGBdwuf8mhBvN/vvgSi35dIiEBgAaKTF5WDwpHxvM0jsqPeFuy9i8btXQTlNneEWQ/IsX7h6wIEgXUwrvPl2H6RcepYnnqLEogLr3FQfpBnm/Ti75hcsfdTkoiKeORgbu5qgzXxU9PrCcNbaZpMx4TxpZuE5ryp4lg3mc3YYrHWQUCmMEwolw7WEH/ZXuNgfimTm/an0ktgtUAwfdHWJ2UY5LRQfmT056ijPCA9omyBGdYRTxgY0QlRUxaVn483PXFZ6EIImUebVhhpt8p491Qt3IYjAUPibMzheLPb3eNvGZMyWsJoobSw5V4At+np/Wwss8TFWQq6oVxlai1lN4WRkV7wa321qA6cV2vP3QMYSYvYX51PyFI9XLPgGvwc/DI3LO0g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9194.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R094TDBCZUNOb0xzODJ2TnNnTUprTm4wZ1lFUnN3SE5hNkFzSUNTeXhOVlJT?= =?utf-8?B?KzVHRVRTdm1ldWc4Sm9xVG5GNE5EQjlENWRiRkUyNldOaTVIN05KeE9Lc0hy?= =?utf-8?B?dDFNU24xTTJ6YU43WmQ5QjFpUTVFS1JMS2pZOEFHbTQxZ0VPQVB3L0ljR0RK?= =?utf-8?B?aER3YU15NHN5ZFRmMmtyNmZZTHJVc01adzFXUFE4b2lXRm1SYllHTFdOZVYx?= =?utf-8?B?Z2s0OHA0ckNKYUxtM1F0STJ6VFVmVEpaQ0c2VUwwNHhBbjV5MVc4a2VHZTFs?= =?utf-8?B?YnVMUTlDRWZoS1RnSTFvSjkvQzh5NnVNY1p3YzVqRkREQVN4eS9vbFRyUnJ4?= =?utf-8?B?VlF4OUlhZytSYTgwQkdtU2laTktvSUZKQUNiNGhsazNrRUw3UXgrQnlsV0tL?= =?utf-8?B?YWk1QmNaWUxMN1IvRytOODVWdFB5M0hyVjVieTNSdnR0dHE4MkhCZmNDdlk5?= =?utf-8?B?TG4rUlVzVjV2ZldrUkh2aTBZUkhVQ0tTUlkvYkxwQm9MZVVqNWo4bXlCLzBr?= =?utf-8?B?QksxdlJqTzJQYWNyaGhDdkxJdm13dFNjK3VxV3IyS1c5cmQvQi82MnhMcUpM?= =?utf-8?B?NU55bmdtak5VNWs2TzlBTW5UcXNLMnZtNjVFdC9tSnE1NzNhY2JGT3NaQ1V2?= =?utf-8?B?TE1peVNFMEVZdi9OWWVRYk9kSlkyVVczZTUzUURsK1k4T2xjNVFXZ1NSL1Jv?= =?utf-8?B?RlpiNURDclJzZTZlUThhaFhPMUNadUFzT21lOVl3Z01Gc0xrYVlETHZJSkJq?= =?utf-8?B?NFU5elVOSU1tQ1N3OTZBTnJOaW1CRUZ1VU1ENm5GL0FlS3NRZGhpaUNSUnly?= =?utf-8?B?LzdPWmFCYXJ4SCtGdjFrR3luVUdadUxaZXpDT2ZZd1FmU2d4cDJWZ1FuNStt?= =?utf-8?B?eXBjTnFYbzMzNENQOEZkWGdRcUU0TTNXN2EvWENWbTMyM01lYlZSUkpDQmc5?= =?utf-8?B?a1pqQTF0NUhRdDJmSUFmb09HMllqTU5zWTJZTWhKYW8xejM5VFc4cGc1enFY?= =?utf-8?B?U3I0RHRqZ1NtUDVKQXhGQlQ1dzVzTG9PYmZ3QnZzRzFxeEtBc2x6c3ZTa3c1?= =?utf-8?B?aDdwZjN2Z3RZMGpGakVQblFxKy9JL3c1dmFBVkNpY1lISDRuQnQ0d25BY0p6?= =?utf-8?B?SFZUa1RRZmVENTdtelNyTmF6Mk1uOHNXSXFBS0NGWFBYaHN3U3d3aUpwa1Mx?= =?utf-8?B?cUtEdjFOcE9wZEJXaTJNcWxYeGpJY2xJWHNDVXVTcE9wOGZaNWxwaFRFRVRl?= =?utf-8?B?TnNqbjJMMlpiY1FDbmU3d1BLNmU4cVlDYnFmbjk2NjkxbTdsbVVLUE5HQ1Ax?= =?utf-8?B?YkJHUDFXNm9tQkNtVVZEd2gxVXFETEpYT3VqNnJaTVoyQW5KZ0NHTmVhUHBH?= =?utf-8?B?WVliV295WXZaaFRjL2U5S05makpmT3kxblJkVzRUb3drYnZBQUhrc1pKV1JI?= =?utf-8?B?M2pHVDFLWDRHZkZmQkpVYk5XbzlnWUpuV25ud2g2YTZZNUlEQiswQmJmMDgx?= =?utf-8?B?bnA0ei9UNk5zWHRsc1JFcm16NHJqNkp0dXRVZFFHNkxSbnVWbWVzUnU1VDh6?= =?utf-8?B?UDFBZEo1eSt1UitxbXlYdmtEVTJHNm5OOU44U0JwM0lMQmhvSGJPa05ibFNn?= =?utf-8?B?YWtteFM5ZnVRVjNheEM1YTBhQ3JROXQzOU5kcUR4eU5KTzZFbTNLSDlZTk1h?= =?utf-8?B?aXg5ZXo0eXRGYjJtbnZQT3VsbTg3dlBxUGhSdFpwK2RYdmplMlY1Z2ltZ3hM?= =?utf-8?B?RXNoMUFtYUN1anFaUTQ2c3JKS3k4UXlmK3RQOU1kUEpNY0ZFWXhZY1Z4bG9I?= =?utf-8?B?R3JKejFDTWFnamxjaXgxUGZrS2VMZVBZdXd2NlhWYzhSTkJVYWR5VzdpdDYv?= =?utf-8?B?ZDFaQ3hsQmxyRFUzb3RoY25GcFpkZjYxZTNzM1BBRkdHZVQ5UStveHdMSCtE?= =?utf-8?B?Mm91Y2JyN3c0aFBwY3hhOU5Da3N6dTFhTWNiNUl0aGdUdkVIcm9ycW1ROEtN?= =?utf-8?B?QktLREh3UFBhTFd2K1RaYWF5bllYUzJad2pEd3RsOXl0djh3SFJ0NzdYaGc0?= =?utf-8?B?OGFjQVoxN2RSMjlwZjRZTDFsSHlHUUdnczNsd1poaDNxUDk5K3R2cUpCL1lN?= =?utf-8?B?Ym9OV3hqbEcyQ1JFa3VGWXN0SjcyZ1A2WUcvYlo3TFplanQ0WUdlSnN6UVlt?= =?utf-8?B?Q1ZmWStOdU9qVHQxVFUyRUpvdzNiSVV5V240cDVkamNKdWhyQUhXYXdkUTRE?= =?utf-8?B?MDMrZ1JTNWJvQk5oVWIxV2d0RXoxcWRTTE12ZVFXalA4L3FrelVTOThGSzhT?= =?utf-8?Q?r9Bt63igdOfBPFveKy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0c6f8c5-5f70-4963-d48d-08de8fc52e7f X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9194.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 08:03:38.6100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BGHLEsLfnAQPEEdnfB+5IUJRDZtlFSHX0PhMeH+FZTY4/uX/OzZo8IJ1n+1B7C6wDJ8asRAfWKaxpvhR+XZy8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB9734 On 1/4/26 18:29, Ard Biesheuvel wrote: > [ replying a second time since the first one seems to have evaporated - > apologies if you are seeing two replies that look vaguely but not > exactly the same] > > On Tue, 31 Mar 2026, at 23:30, Alexey Kardashevskiy wrote: >> On 1/4/26 00:21, Ard Biesheuvel wrote: >>> (add Eric back to cc) >>> >>> Please keep Eric on cc - I added him for a reason, thanks. >>> >>> >>> On Tue, 31 Mar 2026, at 15:18, Ard Biesheuvel wrote: >>>> On Tue, 31 Mar 2026, at 15:16, Borislav Petkov wrote: >>>>> On Fri, Oct 10, 2025 at 05:10:37PM +0200, Ard Biesheuvel wrote: >>>>>> From: Ard Biesheuvel >>>>>> >>>>>> The AES-GCM crypto library operates strictly on virtual addresses, >>>>>> and never performs any H/W offload, and so calling >>>>>> virt_addr_valid() is not needed. >>>>>> > ... >>>>> >>>>> This came from: >>>>> >>>>> 7ffeb2fc2670 ("x86/sev: Document requirement for linear mapping >>>>> of guest request buffers") >> >> Nah, this is because of db10cb9b574675402b virt: sevguest: Fix passing >> a stack buffer as a scatterlist target >> > > Is that change still needed after > > f3476bc77057 ("virt: sev-guest: Use AES GCM crypto library") huh. You're right, looks like it is not, I missed that. > If not, should we revert db10cb9b574675402b too? Nah, we do not want these structures on stack anyway (they might get too big in the future). > Using the crypto API for simple operations where the algorithm is known > at build time was always a mistake. But moving stack allocations to the > heap just to placate a clunky API that can only be used meaningfully in > an asynchronous manner in the first place is just pointless. True. Reviewed-by: Alexey Kardashevskiy Tested-by: Alexey Kardashevskiy or should I reply with these to the original mail? Thanks, -- Alexey