From: Tim Chen <tim.c.chen@linux.intel.com>
To: Kayra Cizmeci <kayracizmeci@gmail.com>
Cc: KPrateek.Nayak@amd.com, Vishal.Badole@amd.com,
juri.lelli@redhat.com, klaus.kusche@computerix.info,
linux-kernel@vger.kernel.org, mario.limonciello@amd.com,
mingo@redhat.com, peterz@infradead.org,
platform-driver-x86@vger.kernel.org, ricardo.neri@intel.com,
stable@vger.kernel.org, vincent.guittot@linaro.org,
x86@kernel.org, yu.c.chen@intel.com
Subject: Re: [PATCH v2] sched/cache: Honor asym packing over cache aware scheduling on hybrid systems
Date: Tue, 06 Oct 2026 10:04:53 -0700 [thread overview]
Message-ID: <0f6b866947600528f84771227ef2b6c3f4adfbd7.camel@linux.intel.com> (raw)
In-Reply-To: <20261006135959.5709-1-kayracizmeci@gmail.com>
On Tue, 2026-10-06 at 16:59 +0300, Kayra Cizmeci wrote:
> Hi Tim,
>
> > + /*
> > + * On asym packing domains, if the destination CPU
> > + * has higher priority than all CPUs in the source group,
> > + * prioritize asym packing.
> > + */
> > + if ((env->sd->flags & SD_ASYM_PACKING) &&
> > + sgs->group_asym_packing)
> > + return false;
> > +
>
> I think that check is redundant. group_asym_packing is set by sched_group_asym() and bunch of other stuff,
> but sched_group_asym() calls sched_asym() and sched_asym() calls sched_use_asym_prio() that has SD_ASYM_PACKING check
> inside of it.
Thanks. Yes, we can remove the SD_ASYM_PACKING check as the check was done when group_asym_packing was set.
Tim
>
> Ah.. Hope I'm not missing something...
>
> Reviewed-by: Kayra Cizmeci <kayracizmeci@gmail.com>
>
> Now, I'm going to grab a cup of tea. And sleep.
>
>
next prev parent reply other threads:[~2026-10-06 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 18:29 Tim Chen
2026-10-06 13:59 ` Kayra Cizmeci
2026-10-06 17:04 ` Tim Chen [this message]
2026-10-06 15:30 ` Chen Yu
2026-10-06 17:27 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f6b866947600528f84771227ef2b6c3f4adfbd7.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=KPrateek.Nayak@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=juri.lelli@redhat.com \
--cc=kayracizmeci@gmail.com \
--cc=klaus.kusche@computerix.info \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ricardo.neri@intel.com \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®