From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdE3ISO (ORCPT ); Tue, 30 May 2017 04:18:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:48664 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750942AbdE3ISL (ORCPT ); Tue, 30 May 2017 04:18:11 -0400 Subject: Re: [PATCH 1/7] nvme: rename uuid to nguid in nvme_ns To: Johannes Thumshirn , Sagi Grimberg , Keith Busch , Christoph Hellwig Cc: Linux Kernel Mailinglist , Linux NVMe Mailinglist References: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496131397.git.jthumshirn@suse.de> From: Hannes Reinecke Message-ID: <0f70925e-9671-dcf3-7aae-2f4d0125c919@suse.de> Date: Tue, 30 May 2017 10:18:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496131397.git.jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2017 10:08 AM, Johannes Thumshirn wrote: > The uuid field in the nvme_ns structure represents the nguid field > from the identify namespace command. And as NVMe 1.3 introduced an > UUID in the NVMe Namespace Identification Descriptor this will > collide. > > So rename the uuid to nguid to prevent any further > confusion. Unfortunately we export the nguid to sysfs in the uuid > sysfs attribute, but this can't be changed anymore without possibly > breaking existing userspace. > > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/host/core.c | 10 +++++----- > drivers/nvme/host/nvme.h | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)