From: Markus Elfring <Markus.Elfring@web.de>
To: Adrian Nguyen <thenguyen1024@gmail.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, Sebastian Reichel <sre@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Casey Connolly <casey.connolly@linaro.org>
Subject: Re: [PATCH v3 2/2] power: supply: Add Qualcomm SMB1351 charger driver
Date: Sat, 14 Nov 2026 12:39:01 +0100 [thread overview]
Message-ID: <0f715d51-1d85-4126-8cb4-7f60e5f84975@web.de> (raw)
In-Reply-To: <20261114112155.85068-3-thenguyen1024@gmail.com>
…
> +++ b/drivers/power/supply/qcom_smb1351.c
> @@ -0,0 +1,439 @@
…
> +static void smb1351_external_power_changed(struct power_supply *psy)
> +{
…
> + spin_lock(&chip->lock);
> + WRITE_ONCE(chip->retry_until,
> + jiffies + msecs_to_jiffies(SMB1351_SETTLE_MS +
> + SMB1351_RETRY_TIMEOUT_MS));
> + mod_delayed_work(system_freezable_wq, &chip->work,
> + msecs_to_jiffies(SMB1351_SETTLE_MS));
> + spin_unlock(&chip->lock);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock)(&chip->lock);”?
https://elixir.bootlin.com/linux/v7.3.1/source/include/linux/spinlock.h#L610-L612
Regards,
Markus
prev parent reply other threads:[~2026-11-14 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 11:21 [PATCH v3 0/2] " Adrian Nguyen
2026-11-14 11:21 ` [PATCH v3 1/2] dt-bindings: power: supply: Add Qualcomm SMB1351 charger Adrian Nguyen
2026-11-14 11:21 ` [PATCH v3 2/2] power: supply: Add Qualcomm SMB1351 charger driver Adrian Nguyen
2026-11-14 11:39 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f715d51-1d85-4126-8cb4-7f60e5f84975@web.de \
--to=markus.elfring@web.de \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=thenguyen1024@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®