From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C6E923AB87 for ; Wed, 3 Dec 2025 03:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764732852; cv=none; b=Lofs+AF3l0vtBs+xMJba155BZyTR9gIccVmxVjJFkqId96U9ZIRhR0iQLL/XpsQcKBGj4qydBm8Kos7zgXK1wsSFm3baWDNZZDhdy7JmISfp53O7/FT46BxxR7YEsXwv8YctqjQmVtIGJB8DQDa/rAJS4AtbOXB0jFi65HBkSKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764732852; c=relaxed/simple; bh=JRvYcBYR986xL8Q9QurkwlNYv9CajrHMpz9RKcFgCp0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XYOvS5XodH46sbXru+nHkJDbLzVEDzMqHzAzdIYq1Ak6n2+1rRCiSQZxQpwPCi0fDH8bmXPXnM8xQHr9PUerzCbbaoEDJAOi+KNO5Gb9ZbuRzmiYIhbEqMbQi0t1/zHqsxq89vf7SNTqQz/o0kyfVbv8GYLV2Z4XkrYVpK3t0nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B0yVelLG; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B0yVelLG" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-bc17d39ccd2so3328986a12.3 for ; Tue, 02 Dec 2025 19:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764732849; x=1765337649; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YrypMwcN4TiTIMcIjUFPxlrx91p/QDVVVhJWJD6ny4I=; b=B0yVelLGk1Leg8UDV/KpdMPlLF49FdiQQPblZbzH/9q/RFgtCTQSJCU5v1v+FzumeB sN9sZNKjmhTb6McYjJ8imzKu8a2zBAww7kVTjL6ywLl2uSe8FFez1MOeq9fuvaZWdTm6 Xoj5Uk4rbtcNbyRTikKyWbW2eOh5fMxCbFzM02kXNF/B7RFS3oUcEZUQVEjM/+KDD/Kp cOudgezhlB8ksrO9jAaUkwFlxThHgkZEaeOGabohMTcB9Or/yQXg5Hq60cpZ7XANr2wF rpfMtgwVikoJFcUBl1Ic8HfNSUkONX5h47jfpwrU9zKdesfaTknJ1eD3DQgn2KJwJ63J OaVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764732849; x=1765337649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YrypMwcN4TiTIMcIjUFPxlrx91p/QDVVVhJWJD6ny4I=; b=ESu9C6XizHrOFr2n6XI8T1PQzTWsvUTtuvY4tiV0R2zdk+3ozxDN0sgMGuoKZek7jW Lom3hlPfi2Dto5pJDrn028f11iPo1v/RYE8oLqJQ0eKaZ3WiIUM45L6av8YfGziTfJKG 3OXUzY2kNnLdXzew84pp9zVfG5TDrEDIvzKh89HwVIBDZs2OU/tuuIj1Hqge7rAHYm/R 0JSQ0/H3p38b1q/yTaacKWYy5DBzTzk6wK5Hx4lYkIityayBVLleDlUsVKlSrOcKXRWx qd6tkutid1zUHADxDcd9HCa4yp7QsIogWMPHrssavuBEA66krpQ9je8wjpNMPVHehjQm 8Ugw== X-Forwarded-Encrypted: i=1; AJvYcCUjixFGVl/yquH6/9vzdRrkA1HOKQ8cpuLOQ+aTfmq0Urhh9lLz/QiPxxdvNnEuTAGf9biWExdaQZR30/c=@vger.kernel.org X-Gm-Message-State: AOJu0YyOP3fzUOb8DPhVYX1VUUDdUCOw7pOd3U+avkL/WcnqdIY+Cix8 xDsFwohK36yhPmaApTGtyj2NkfxrBOEzKATJR3uwMokNsUv22jOiPXgN X-Gm-Gg: ASbGncvAMCherBUrilnGuJSPlNU+PDYDcXmh2IF0msajWI0Y/KtUVe7lpoPRgDspc9Y 1ghx8efcbvwsNyXqmenwNxPW+L4GINzWfoyX1gpyTnsJNX1uhHYilFjJbTWB5NM0Sz8As+tCJlM tnL2WfMOmj3+2MOxpGspVlA2KqryI2g6iURswFLRGno3s851WpkupHW6KL4TSDSIv7jTwXqL/Ez gonIXhCqz+Uw3o3q4MDgWoVPdjKSq8PspxzA8UlZEMjq7CeI3rNwHCWN/OR/IP/IECMfRsg8XcS nzlxl6SwcPaVAM49kDTJFvvbq8MjCTOejhxXfoFmpZFPKIE2j7ybIoZugssQ6tN0Yl164DxT9v6 JueWD4ZvdwJdnxS1mToRuaChLUxWxqRdll94N57NmiaqE1w6RAFnTPUAbPM0zCbevCRKJUeJo8Z j9LChDb+Mnv7ZipTRljRxeHPk= X-Google-Smtp-Source: AGHT+IHb2Bm444wTR/SyhoFk/OdfrkP+670oMUjj/BL8tdpSmodPv0u+GrGuSHULggAy1sTlh5P04w== X-Received: by 2002:a05:7022:f415:b0:11b:9386:a38b with SMTP id a92af1059eb24-11df0c4c8c4mr768810c88.46.1764732849328; Tue, 02 Dec 2025 19:34:09 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcaed5fcasm92986328c88.2.2025.12.02.19.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 19:34:08 -0800 (PST) Sender: Guenter Roeck Date: Tue, 2 Dec 2025 19:34:07 -0800 From: Guenter Roeck To: Brian Norris Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Nicolas Palix , linux-pm@vger.kernel.org, Julia Lawall , linux-kernel@vger.kernel.org, cocci@inria.fr Subject: Re: [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier() return code Message-ID: <0f729108-6928-4644-b02a-fa7020cdffc4@roeck-us.net> References: <20251202193129.1411419-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202193129.1411419-1-briannorris@chromium.org> On Tue, Dec 02, 2025 at 11:30:24AM -0800, Brian Norris wrote: > Apparently this test is the only code that checks the return code from > pm_runtime_barrier(), and it turns out that's for good reason -- it's > inherently racy, and a bad idea. We're going to make > pm_runtime_barrier() return void, so prepare for that by dropping any > return code checks. > > This resolves some test failures seen like the following: > > [ 34.559694] # pm_runtime_error_test: EXPECTATION FAILED at drivers/base/power/runtime-test.c:177 > [ 34.559694] Expected 1 == pm_runtime_barrier(dev), but > [ 34.559694] pm_runtime_barrier(dev) == 0 (0x0) > [ 34.563604] # pm_runtime_error_test: pass:0 fail:1 skip:0 total:1 > > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/lkml/93259f2b-7017-4096-a31b-cabbf6152e9b@roeck-us.net/ > Signed-off-by: Brian Norris With this series on top of v6.18: Qemu test results: total: 610 pass: 610 fail: 0 Unit test results: pass: 666898 fail: 0 Tested-by: Guenter Roeck Guenter