From: Andrew Lunn <andrew@lunn.ch>
To: "João Rodrigues" <jrodrigues@ubimet.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"open list:ETHERNET PHY LIBRARY" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] net: phy: dp83867: Add SQI support
Date: Thu, 13 Jun 2024 19:13:27 +0200 [thread overview]
Message-ID: <0f7cef0d-b5ef-4feb-981e-c587e08de0e9@lunn.ch> (raw)
In-Reply-To: <20240613145153.2345826-2-jrodrigues@ubimet.com>
On Thu, Jun 13, 2024 at 04:51:51PM +0200, João Rodrigues wrote:
> Don't report SQI values for 10 ethernet, since the datasheet
> says MSE values are only valid for 100/1000 ethernet
The commit message could be better. Something like:
Don't report the SQI value when the link speed is 10Mbps, since the
datasheet says MSE values are only valid for 100/1000 links.
> +static int dp83867_get_sqi(struct phy_device *phydev)
> +{
> + u16 mse_val;
> + int sqi;
> + int ret;
> +
> + if (phydev->speed == SPEED_10)
> + return -EOPNOTSUPP;
What does the datasheet say about MSE where there is no link at all?
Maybe you need to expand this test to include SPEED_UNKNOWN?
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-06-13 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 14:51 [PATCH net-next 0/3] net: phy: dp83867: add cable diag support João Rodrigues
2024-06-13 14:51 ` [PATCH net-next 1/3] net: phy: dp83867: Add SQI support João Rodrigues
2024-06-13 17:13 ` Andrew Lunn [this message]
2024-06-14 16:42 ` João Rodrigues
2024-06-13 14:51 ` [PATCH net-next 2/3] net: phy: dp83867: add cable test support João Rodrigues
2024-06-13 17:19 ` Andrew Lunn
2024-06-14 16:52 ` João Rodrigues
2024-06-14 18:16 ` Andrew Lunn
2024-06-13 14:51 ` [PATCH net-next 3/3] net: phy: dp83867: Add support for amplitude graph João Rodrigues
2024-06-13 17:26 ` [PATCH net-next 0/3] net: phy: dp83867: add cable diag support Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f7cef0d-b5ef-4feb-981e-c587e08de0e9@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jrodrigues@ubimet.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®