From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandru Ardelean <aardelean@deviqon.com>,
Cai Huoqing <caihuoqing@baidu.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: st_sensors: don't always auto-enable I2C and SPI interface drivers
Date: Mon, 10 Jan 2022 20:04:35 +0300 [thread overview]
Message-ID: <0f7d5c44-2119-97ba-5a3e-7f0f40d41605@cogentembedded.com> (raw)
In-Reply-To: <YdxWZEz1GXXxQ+7h@smile.fi.intel.com>
10.01.2022 18:53, Andy Shevchenko wrote:
> On Mon, Jan 10, 2022 at 06:24:32PM +0300, Nikita Yushchenko wrote:
>> This patch makes I2C and SPI interface drivers for STMicroelectronics
>> sensor chips individually selectable via Kconfig.
>>
>> The default is kept unchanged - I2C and SPI interface drivers are still
>> selected by default if the corresponding bus support is available.
>>
>> However, the patch makes it possible to explicitly disable drivers
>> that are not needed for a particular target.
>
> ...
>
> The same question as per v2.
>
>> + default I2C && IIO_ST_ACCEL_3AXIS
>
> What will be the results when I2C=y and the second ones =m?
$ grep CONFIG_I2C= .config
CONFIG_I2C=y
$ grep IIO_ST_ACCEL .config
CONFIG_IIO_ST_ACCEL_3AXIS=m
CONFIG_IIO_ST_ACCEL_I2C_3AXIS=m
# CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set
$ vim .config
<remove CONFIG_IIO_ST_ACCEL_I2C_3AXIS line>
$ grep IIO_ST_ACCEL .config
CONFIG_IIO_ST_ACCEL_3AXIS=m
# CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set
$ make menuconfig
<immediately exit>
$ grep IIO_ST_ACCEL .config
CONFIG_IIO_ST_ACCEL_3AXIS=m
CONFIG_IIO_ST_ACCEL_I2C_3AXIS=m
# CONFIG_IIO_ST_ACCEL_SPI_3AXIS is not set
CONFIG_IIO_ST_ACCEL_I2C_3AXIS was set to =m by default. I believe this is correct behavior.
Nikita
next prev parent reply other threads:[~2022-01-10 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 15:24 Nikita Yushchenko
2022-01-10 15:53 ` Andy Shevchenko
2022-01-10 17:04 ` Nikita Yushchenko [this message]
2022-01-10 18:47 ` Andy Shevchenko
2022-01-13 15:15 ` Andy Shevchenko
2022-01-15 13:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f7d5c44-2119-97ba-5a3e-7f0f40d41605@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=aardelean@deviqon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=caihuoqing@baidu.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®