From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF843FF1D4 for ; Fri, 15 May 2026 15:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778859976; cv=none; b=LAZh9ESQBWLD1qLzw2kySe5JNZIcOe2HPtBZqywBKjV7BmcebYhieQPasBo5gVsUwrvwtFgRpVlAa+dJzoihyd2gGyTo24yK59dSmg+XnVdGfUbcrgQfJpmLtPTgJlNthmXGGJUToJr8fD6MTyF/5PyQEL1dueOyQQZDuFufVMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778859976; c=relaxed/simple; bh=LeaHE+gC1mCUrXQASoxg5zg1wnUSLSEeoi/7LPe9A1Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KaNXRSySsb4PFvZ9ItqTqicoiE3KD8WxA++VsUaKvom0T/fjLV/SI6t6OhpNz1IJDq9GV9EfRBOz0vzkxTixxmo8nGqzrcQU/Hbq1YJ1JN2McUPq4ue75LJNXeYwxX963SzNq/hogBjS72kSn0zRtaehv14SN3TxiNvdxzJzwrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=NEjzoJAr; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="NEjzoJAr" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-415b23dd6e5so3559861fac.3 for ; Fri, 15 May 2026 08:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1778859973; x=1779464773; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Id222wMSLjsZO63ZhosNw0OVQDl4XEooys+lgVTccZk=; b=NEjzoJAr/iM4kw46VXvO3bAQSQiWIR5WHVsCiXv9ala/2/OmV0i65sTEJup4KCYIdy rffHnH/vKwLgr8mnr8+T8bByISM1WHDlJpyR2M7H2i3VntD1zA5rBimFSkV7aw70aYHd B6WMS0DlZpDKnfWppxU3OkOCrnI44nAMRpaTLOBnMGmbmPd5ED0wg+Hug19HVH3Y8X3y /qRobKFLv/v/PGpmPPIKiIdh4Ifn9lSdO4aWgfmOc3LM4JxcKFClKZ637Tm8umo8l2NN 2sLjJWMf9DR03MQCUJlDR57z/96PGQcJN46qt1/7H/yFLev1Jbrn4VfxLrAPAcNO8LWk IVJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778859973; x=1779464773; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Id222wMSLjsZO63ZhosNw0OVQDl4XEooys+lgVTccZk=; b=Yq//yvEguoyJRXj4Aw2wXmWpwvlsh3zjnFv5CIIkOR18zILjqE9dmXLYxdJikaKI7R eiyYLk2MSsHmjowxBtxcJaf131yM6TnInxKnBmpqnIm0A51wqzLCoE1pAFOC9pcDFegW WSHeKV/NwG8ASe41BrxKO6ARtHfS9B5C5Bs+FxoKJSo7jyuOsROcYfyUdsf6YKkkk/tP fyrysmrSGvQKRVgaLYSSOaUgd1JOjS+9Ons4P+78j067iMVDZNS/5dDf+F4ofNq9SuJD T3NidFBP0vMMS32SfsyGhhyYPjPiNublkWpG5sG/z66m9FopCB90OzBHCzfNwIwqsvbU Ph6g== X-Forwarded-Encrypted: i=1; AFNElJ/hnv/Xa65cLZFul80GDJWYUJZDX96yswDSL8BLVMJaJfSApxI10ZhvYaECMD8/09Yz6QhyBCk15XVfTS0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1qvoyNlGp5CSjH5h6dz4h/R8UVOMOkm/G/WeVYkLF243OEPT8 kcgpGrm6s6xnWxnMVM1yf5ckZYeJE8H1v8PhIAhyQUc654KG1VsQ+5xMrt0mgrBPmJs= X-Gm-Gg: Acq92OFwdm2PCUQHyLS08vxYsNP4RXxssZggJb/zwPjt1cBoPz0QVX5SC6BXLNuqLnp MTQ3tndQ1MrZ3adT/xTj47wi9WYnjFAhWiFc+aJaUHtt4MGx+o43+SgXGk8sQaQlh581IUuBPD6 lgn7O6GvoZXb3RPy9NWyKvoCT0bPktp8pu3MNVtPJ0gJHrFKYpmO9wjXy/GdQzsMG+ezZsWglT6 AX4Y6iJa00WHC3/LTNTw7KHp8CeQhn7YvAPAX1Aoj28fArBY5+eLifCk+ts8CNpdg8YnKHjgmSa 88T28xYOhdMTt8zhzvWPeLsUTdu+oe+F+tnWwrbVXZgrqf++yE8aB+2kpgFzZZrPzGm2Y3aY7fr S/tC91POw3wp88P0Tc7NkQypwK7HbBcx8fBuWV9A/X7jb2900Oa/mVnqWJHN+16jskQDNk/ylY0 3FVxKA706RWXohNv9E2GEisIhWQMEoxrbKx+Zb6wgcNq/5XzxwFhQSxcckma/XIh00koDL/EdjF GBZj6UX X-Received: by 2002:a05:6871:ea0e:b0:42c:2c15:3769 with SMTP id 586e51a60fabf-43a2d913986mr3109010fac.3.1778859973279; Fri, 15 May 2026 08:46:13 -0700 (PDT) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-439fc53f2acsm4468762fac.14.2026.05.15.08.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 08:46:12 -0700 (PDT) Message-ID: <0f7e9184-f317-40f1-b366-d8582cb97ac4@kernel.dk> Date: Fri, 15 May 2026 09:46:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] io_uring: propagate array_index_nospec opcode into req->opcode To: Michael Bommarito , io-uring@vger.kernel.org Cc: Pavel Begunkov , Li Zetao , bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260515145812.1241925-1-michael.bommarito@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260515145812.1241925-1-michael.bommarito@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/15/26 8:58 AM, Michael Bommarito wrote: > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index 4ed998d60c09c..7b257a03ef84c 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -1739,6 +1739,7 @@ static int io_init_req(struct io_ring_ctx *ctx, struct io_kiocb *req, > return io_init_fail_req(req, -EINVAL); > } > opcode = array_index_nospec(opcode, IORING_OP_LAST); > + req->opcode = opcode; > > def = &io_issue_defs[opcode]; > if (def->is_128 && !(ctx->flags & IORING_SETUP_SQE128)) { We could just kill 'opcode' while at it, and just use req->opcode for this. I think that'd end up generating the same code, and avoid having two versions of opcode. -- Jens Axboe