From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbdK0MQB (ORCPT ); Mon, 27 Nov 2017 07:16:01 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:24549 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdK0MP7 (ORCPT ); Mon, 27 Nov 2017 07:15:59 -0500 Subject: Re: [PATCH 1/2] ARM: davinci: make the function argument as const To: Bhumika Goyal , , , , , References: <1508148504-2771-1-git-send-email-bhumirks@gmail.com> <1508148504-2771-2-git-send-email-bhumirks@gmail.com> From: Sekhar Nori Message-ID: <0f817e2b-2251-7473-a60b-46ff66c0e77e@ti.com> Date: Mon, 27 Nov 2017 17:44:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508148504-2771-2-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 October 2017 03:38 PM, Bhumika Goyal wrote: > Make the function argument of the function davinci_common_init > as const as it's memory contents are only copied during a > memcpy call. So, the fields of the structure to which the argument > soc_info points to never gets modified and therefore the argument can > be made const. > Add const to the prototype too. > > Signed-off-by: Bhumika Goyal The subject line is written too generically. I changed that to " ARM: davinci: make argument to davinci_common_init() as const " while applying to v4.16/fixes-non-critical Thanks, Sekhar