From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC12F441043 for ; Fri, 27 Feb 2026 16:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208258; cv=none; b=Be6R6IKJkg5x5VVPTKFcb4xEhD0Uli7NjK04bRxAcAS/l9eRCfynjRNydmVFGOg4xF+ZRRNkJHqBi2RyM/githabuD42PMdQSBwZV8BIHi+FbeFREAUtGTjjZ5oNcFqMzrQQHtZroIxgVhHLnoVJ70rFA7FmY5IYyftcT8YCi5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208258; c=relaxed/simple; bh=yMsIV36HNzyHAhumTKQXbRfkZ5ENfqFt+HlNd/77FdQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=m/SiENHGc5flpWEi2HcP2G03NOHOyTAlHSVyRhVweltMbsyOTmqGCRXVi6+2rwI+pYezIgyOfoc6wIp5S7rR8Ch/L4+n/gmBt+eBIrgUud6xncjmIyNUwvvjaDG3kVTsceY8Zm+KzG6SO52//LncqhKPShoVqqGTlzucxwu2ME4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fhr8OTgj; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fhr8OTgj" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4398d1f06caso2083645f8f.0 for ; Fri, 27 Feb 2026 08:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772208255; x=1772813055; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DRZphY/3exWOzWZdEB1ys0d2atmkXHj+DiQYknH1Jjw=; b=fhr8OTgjctJMcxL2HtUu23skTaO+XB5LabLEZgLRLHdpjTUIlG8GkwgC4ThsTwnLhY E8mWPsEhOvM7ev043QY1AORUKnGsND3Tc5c1zdHcNq9mJtGyrNNcckZWgSkxJTeZe/cX eFqj2YcE4Qh98T4nHs5bracbCgzq+6yXgI4rUTS2dQrYeQLcc0InsRjkZapBm0Rty/E/ 2rlP/56FpOnTyuKkZm6bfQASxQKcLjTf8oQ7msWu6II8UG+jxalFM0R/KsvjuEsW5L28 CrPt9DUWRsjlnPGYA60B1r/uDkiiVnO2BzSEQgwcb5DCa44uSJXhIALVU/FornNnRwaw fIiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772208255; x=1772813055; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DRZphY/3exWOzWZdEB1ys0d2atmkXHj+DiQYknH1Jjw=; b=lKLS4nS3KA4MGcaLMP3myOfGQQ5nYDCp2cBStGubZiVR28uKLtt4Ue8MBdwfDIGx7N 4yQAZsVGB3v3URjcsxneLdj+u6vNgvfdgAVtRQE3j1s5T5KDNnV/OxM3dcn7rDSBoUqQ 8eXz6tr9A++NxO7He2c85CPQRkD4NPJIWT0lxEKJ1gfjpKHtzplqG3q2UIE9G9QuG9/3 ly1qSg1GzGswQYsQ0uZHYva8K1qJlHm2Hp8t3j2Nre1Uf3eZxCYbmJsQxMC1w7rKjrzK Z+5Rxi5MpB0jRv3o3xysNa44+F2JWlBNeDl76/HToYF2YAMvM1cScXxZrhrPt5yLHgAF vWuw== X-Gm-Message-State: AOJu0YzVHN+w6AEIgsWe3IRp7wj6sk2PItoCNHZTj5mRtLKPlOfEW5wM LVZX8vhtum+pTgOJxmy6/n0W7YOUr12MfWsFSz7uznJQdsrMrmvNlaTu X-Gm-Gg: ATEYQzy3N2JSdgETYnWic5TzYYr3gph4eMFv/Jz7tfKSauVyyV9IxM+zlG3YpT7epDZ p4RimFRpu0zFoia3Mmv/5Vt7ERO2I0ILU62Gf6vX5L+arBul01AI8pJTw+6W+AaaRkLzLWlegfy g1paKa2DRUWkhn0S4tHh8OHcIeV0UPen+X16MLUo3gL4QxYvPBuu2DfYCID5bxrXF0pliquf2Id bexqDEDJyXUlJfloF46YH6gYeeZuyx1H3y1REDZspWSTf1s7p38UeSMjfFBk3wxG8NIzsJyijk1 bNWCt57GdpiGKer2OSsI0xvtZdLrsHEkKM/b5zS7pLZFiO9slHwr05f7mN6S1MCajtuNPSXqI/V 4qVm3b/dxyEDD2VZqHTTpwJAPdCSeNxsmHF/ovUXbkmGgJ8CLVp9+XvbL2VkpL+hXQ0q1vhfRx7 HAISDktt7p/EL8jv3RYjtLK1SLMqj8SEo= X-Received: by 2002:a05:6000:1a8c:b0:437:6e6e:6f95 with SMTP id ffacd0b85a97d-4399de1c60emr5923899f8f.27.1772208248739; Fri, 27 Feb 2026 08:04:08 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c75a0f6sm9109299f8f.22.2026.02.27.08.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 08:04:08 -0800 (PST) Message-ID: <0f87effdbe7d8ac352249a6487efb5efa40156ea.camel@gmail.com> Subject: Re: [PATCH] i3c: dw: Use more common code in dw_i3c_master_i2c_xfers() From: Nuno =?ISO-8859-1?Q?S=E1?= To: Markus Elfring , linux-i3c@lists.infradead.org, Adrian Ng Ho Yin , Alexandre Belloni , Frank Li , Fredrik Markstrom , Ivar Holmqvist , Jorge Marques , Manikanta Guntupalli , Sakari Ailus , Wolfram Sang , Zilin Guan Cc: LKML , Aniket , Jianhao Xu Date: Fri, 27 Feb 2026 16:04:52 +0000 In-Reply-To: <2411a872-5bf5-4353-a754-47fa54d69c46@web.de> References: <2411a872-5bf5-4353-a754-47fa54d69c46@web.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-02-27 at 11:20 +0100, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 27 Feb 2026 10:16:50 +0100 >=20 > Use an additional label so that a bit of common code can be better reused > at the end of this function implementation. >=20 > Signed-off-by: Markus Elfring > --- This actually looks like a fix to me. It's not just reusing common code. - Nuno S=C3=A1 > =C2=A0drivers/i3c/master/dw-i3c-master.c | 7 +++---- > =C2=A01 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i= 3c-master.c > index d87bde3f7700..beb40d947e6e 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -1113,8 +1113,7 @@ static int dw_i3c_master_i2c_xfers(struct i2c_dev_d= esc *dev, > =C2=A0 dev_err(master->dev, > =C2=A0 "<%s> cannot resume i3c bus master, err: %d\n", > =C2=A0 __func__, ret); > - dw_i3c_master_free_xfer(xfer); > - return ret; > + goto free_xfer; > =C2=A0 } > =C2=A0 > =C2=A0 for (i =3D 0; i < i2c_nxfers; i++) { > @@ -1144,10 +1143,10 @@ static int dw_i3c_master_i2c_xfers(struct i2c_dev= _desc *dev, > =C2=A0 if (!wait_for_completion_timeout(&xfer->comp, m->i2c.timeout)) > =C2=A0 dw_i3c_master_dequeue_xfer(master, xfer); > =C2=A0 > + pm_runtime_put_autosuspend(master->dev); > =C2=A0 ret =3D xfer->ret; > +free_xfer: > =C2=A0 dw_i3c_master_free_xfer(xfer); > - > - pm_runtime_put_autosuspend(master->dev); > =C2=A0 return ret; > =C2=A0} > =C2=A0 > --=20 > 2.53.0 >=20