From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C01735821A; Fri, 3 May 2024 21:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714772040; cv=none; b=OLnvP4LauiZUPTS5EWNnQlFTmYlvFFwEcHV5ATKt9abDsKxn4kYt2Kg2JduDx8bM1Vyk5YQiCTM1Y74c8PvQEiLfN/NtwJMP+zrjLqneqhPUQD3Ah7TegBReC4wgBYF/sbtD96Bx67Jmegsv+MaibHkNBed/i0D1+IMWvsio8D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714772040; c=relaxed/simple; bh=OR8t/7tZT5uQQef3RULK0uCzP116fOOCTBA3svyi1Qw=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oR3zUmOCd4DbZnkRfM1cf3GsxyT6A+wV/ba3yH+LAuHBxKs24FD60iuXnWREELx0diKJPmcTAjiXxTNLJ9vCuvJehPywkw/gpD6ztfBsib/PUzwwLFlmSSNUDUFnBE3vSOHrfmzQQyEmRLLZtXYHsbFJ/KXBLP5Dg3YP5cq/r0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=pf8HEhBr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="pf8HEhBr" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 443LONNw021291; Fri, 3 May 2024 21:33:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=x+VBAQfRCu+s6AQ2CmZe1fqjOOTucJLjWz4SzfIiC0A=; b=pf 8HEhBrNafPZBfZZZsGkubm0NmlkGrtOJqQOkKE/q+2bmZxjBDoSImg7zPWYEU+Tq D+h9vHEZ+AGMosXD0xzqcA4Ogp7y4dilNvoi9w1gnzR5NulbhyiyF1UdB7hk+POp Q6LyV+J/NHAjbgTZzKuiY3aZJ4XDU58Pt/BGaL7UIBM2kOcDBJJOoy5cvoWhrEp1 Eg/42MF1oMoDqkgK2lkVS5VahIHA8rIhkz5OIBT2Q5sIZRP2NlC2/JhQHdn3jxQ1 F502gT51xBP3OiptPTRL7/AGW0nLIyr6L5RQnjq1e1U71KOi5sihxC73qqZx0Uy0 OfB0OfWQ5O5GzwgNjwpA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xvwfa9du8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 May 2024 21:33:32 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 443LXUpo015476 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 May 2024 21:33:30 GMT Received: from [10.110.77.94] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 3 May 2024 14:33:27 -0700 Message-ID: <0f88ec53-6c92-434d-81c8-538b31a2385e@quicinc.com> Date: Fri, 3 May 2024 14:33:26 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH bpf-next v5 2/2] net: Add additional bit to support clockid_t timestamp type Content-Language: en-US To: Martin KaFai Lau CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , Andrew Halaney , "Willem de Bruijn" , Martin KaFai Lau , Daniel Borkmann , bpf , References: <20240424222028.1080134-1-quic_abchauha@quicinc.com> <20240424222028.1080134-3-quic_abchauha@quicinc.com> <2b2c3eb1-df87-40fe-b871-b52812c8ecd0@linux.dev> From: "Abhishek Chauhan (ABC)" In-Reply-To: <2b2c3eb1-df87-40fe-b871-b52812c8ecd0@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: nVdDm5OZ1TpalJYn_PpoYsN-R3ehATxQ X-Proofpoint-ORIG-GUID: nVdDm5OZ1TpalJYn_PpoYsN-R3ehATxQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-03_15,2024-05-03_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2405030153 > BPF_CALL_3(bpf_skb_set_tstamp, struct sk_buff *, skb, >            u64, tstamp, u32, tstamp_type) > { >     /* ... */ >     case BPF_SKB_CLOCK_TAI: >         if (!tstamp) >             return -EINVAL; >         skb->tstamp = tstamp; >         skb->tstamp_type = SKB_CLOCK_TAI; >         break; >         case BPF_SKB_CLOCK_REALTIME: >         skb->tstamp = tstamp; >         skb->tstamp_type = SKB_CLOCK_REALTIME; >         break; > >     /* ... */ > } > >>               return -EINVAL; > >> @@ -9388,17 +9394,17 @@ static struct bpf_insn *bpf_convert_tstamp_type_read(const struct bpf_insn *si, >>   { >>       __u8 value_reg = si->dst_reg; >>       __u8 skb_reg = si->src_reg; >> -    /* AX is needed because src_reg and dst_reg could be the same */ >> -    __u8 tmp_reg = BPF_REG_AX; >> - >> -    *insn++ = BPF_LDX_MEM(BPF_B, tmp_reg, skb_reg, >> -                  SKB_BF_MONO_TC_OFFSET); >> -    *insn++ = BPF_JMP32_IMM(BPF_JSET, tmp_reg, >> -                SKB_MONO_DELIVERY_TIME_MASK, 2); >> -    *insn++ = BPF_MOV32_IMM(value_reg, BPF_SKB_TSTAMP_UNSPEC); >> -    *insn++ = BPF_JMP_A(1); >> -    *insn++ = BPF_MOV32_IMM(value_reg, BPF_SKB_TSTAMP_DELIVERY_MONO); >> - >> +    BUILD_BUG_ON(__SKB_CLOCK_MAX != BPF_SKB_TSTAMP_DELIVERY_TAI); > > Add these also: > >     BUILD_BUG_ON(SKB_CLOCK_REALTIME != BPF_SKB_CLOCK_REALTIME); >     BUILD_BUG_ON(SKB_CLOCK_MONOTONIC != BPF_SKB_CLOCK_MONOTONIC); >     BUILD_BUG_ON(SKB_CLOCK_TAI != BPF_SKB_CLOCK_TAI); > Martin, The above suggestion of adding BUILD_BUG_ON always gives me a warning stating the following. Some systems considers warning as error if compiler flags are enabled. I believe this requires your suggestion before i raise RFC v6 patchset to either keep the BUILD_BUG_ON or remove it completely. /local/mnt/workspace/kernel_master/linux-next/net/core/filter.c:9395:34: warning: comparison between ‘enum skb_tstamp_type’ and ‘enum ’ [-Wenum-compare] 9395 | BUILD_BUG_ON(SKB_CLOCK_REALTIME != BPF_SKB_CLOCK_REALTIME); | ^~ /local/mnt/workspace/kernel_master/linux-next/include/linux/compiler_types.h:451:9: note: in definition of macro ‘__compiletime_assert’ 451 | if (!(condition)) \ | ^~~~~~~~~ /local/mnt/workspace/kernel_master/linux-next/include/linux/compiler_types.h:471:2: note: in expansion of macro ‘_compiletime_assert’ 471 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ /local/mnt/workspace/kernel_master/linux-next/include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ /local/mnt/workspace/kernel_master/linux-next/include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ /local/mnt/workspace/kernel_master/linux-next/net/core/filter.c:9395:2: note: in expansion of macro ‘BUILD_BUG_ON’ 9395 | BUILD_BUG_ON(SKB_CLOCK_REALTIME != BPF_SKB_CLOCK_REALTIME); | ^~~~~~~~~~~~ /local/mnt/workspace/kernel_master/linux-next/net/core/filter.c:9396:35: warning: comparison between ‘enum skb_tstamp_type’ and ‘enum ’ [-Wenum-compare] 9396 | BUILD_BUG_ON(SKB_CLOCK_MONOTONIC != BPF_SKB_CLOCK_MONOTONIC); | ^~ /local/mnt/workspace/kernel_master/linux-next/include/linux/compiler_types.h:451:9: note: in definition of macro ‘__compiletime_assert’ 451 | if (!(condition)) \ | ^~~~~~~~~ | ^~