From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85E4E29AAF7 for ; Tue, 3 Feb 2026 09:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770111117; cv=none; b=TZkYM5vm554LHu1CM2charQbxvcTGgRhLKEqDjJOY5bL5Jh3TNwOjzI8uQk8QUeMIegLxsanGwy9sJxYnc9/IbCXKG5fVqH7OyuJlbt6P3PFXOFsNArcj3D1kr3amqMCkVWK+vZn32wJxr6gjMg8fFid8BEXEjEFx8qbA0ML0hQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770111117; c=relaxed/simple; bh=7lWwlNRV+6r2H3mLL3UVH1qpDayK7pYL5ubxSaD9W38=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rliMpN1MfRgV4kZAiHpUdC2hyVvJ55dyYBuaNRaQqjYz6ZYPU4LTqs/XQpMlfstmhZ8oX1d1lmhpD+CX5T/MSJmO5lGBMzc27W+vsPhFdzJry1gln1oVw83YoSfWFPUyV/S38yA/IEg1XGtZTVjo5cG83mTQGuAVmxqQI9bt1RU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S/DYMzqN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V5TOKK+s; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S/DYMzqN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V5TOKK+s" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6134ZtLI092361 for ; Tue, 3 Feb 2026 09:31:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YdHSwOqniPyo27OYcD5Smnsc9jClWLTB1iwxoPHnzP4=; b=S/DYMzqNK+prf9J9 YjaqJJ2xHmlwt+7/Of2U3ZAlamJN4S3nZsngHFg6FshIQxDnzQwQvkkkoNXK6XJE 3cIk74xIijW44Y4oDkwDtflY0/YBT7TGg7whWXV2sUTx3CAKCTXccpNGqZsccL0+ HzW0PyJmSzqycNpwZaDFVkIx+qhhLd1ZQe6gXDZ/2ahqkV78av05T67jY3Rrhpc1 qfChTUDBD22Jocm7Tl3nSVPm3riCWCIHfpLGq5s/rxhpfw2Yw0W1h9P6EcViLxy2 t9KsIJl5Zl4P+hLdsGpsjvJwQFn/vaaJ6WxDHguHzgp871XBIo5oAVyYlb89b7tE 2m4PJg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2trbkqd4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 09:31:54 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0bb1192cbso45742245ad.1 for ; Tue, 03 Feb 2026 01:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770111113; x=1770715913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YdHSwOqniPyo27OYcD5Smnsc9jClWLTB1iwxoPHnzP4=; b=V5TOKK+sNUyD96H9XRyy1xL9Tp/J+UzyXzCA600WOR5wQdtOwJukkfRTgS8HdOvWdh YIQmyDsdD0wKHnLzWOoUV0YE1q9kAlY+TqbNyj5hHlMI4cThFg7jmXysrR8ouZD65wl1 BnJX140pLOW0vyvt5iQP0n4cbcGawii8b26XMFDWHViNnhHABLW+xFwDqH2PlQewaIDm pnL0tjpb1afnYWcpudlOKtvBhS5SsRJMWPA2FKjkPSitOLckhtzpC4s1ydWMfvif6B6n t5wpefFlXYw7BMz571Yx9GDsndkNwZiNpB5daLHiWw5cRnDq9tmhD5Tm7gX8QHBm8Sb3 Ow1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770111113; x=1770715913; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YdHSwOqniPyo27OYcD5Smnsc9jClWLTB1iwxoPHnzP4=; b=EWI7EDCf30S1zTCQWLqXgsYAru1i4cF/hIXvsLSRhX3F0CYu/LbCNLOHbRg6r+EEgK 0SKDVfBaQlAI0GmTcM8Du3B8MADPqjBS5c8Feny0Vix76U+rk+czzix0u03xnypP4yC8 1Uo38g98Ddd4O7C80kmIYMvkBd4kl5C/JHWADUhRY6s0jyj5ExNeTqt6etht+qPTHZfR UoYegVJ1UAKiRFPopZPqb5pKqClMmwHnhGnGMdU+CMZNCiu5RRaUkgjD66hm7yumITCZ j9O8zNRMNt5Hz8RchYmv14Rap+Kwg2Eh6RB4qYBCNzRkmKfuYBVQ3Horjul1lfFzHmmC QhIQ== X-Forwarded-Encrypted: i=1; AJvYcCW5gy2Da/h3xukU5x5NnOW7c2vtJZy2QpIgC7haRZGEmr+3a1HlJ1UbIWzdfS/vlcmMLflo33tKTWd85jM=@vger.kernel.org X-Gm-Message-State: AOJu0YxE+0aMfIfx3vOfsXSH1lQPMgFidGgc/ISPMasVGcElmmNQDhmO t0Yt3JeGfvvMtq/Gc954DppDNgc73IT0rYLSNBhRQdSBkJ0FuUzbgPRzaGlUeMIsgrc0ZbPVI5K TuAd0k81xDGJJRryippctaJh2SFPENKTBJCN4i7rZrwFBhlZaV7kU0eTAw6HtCGgQfT8= X-Gm-Gg: AZuq6aIzmmTqgTBZ1LIduBLyW7RL1aGMf6la+mtxsQKftzFiYHxrx6B5JUeZiBZIffv 2vhlnA1mO+jw6WQkazu1rgC7fOlrFdpcvLjWjR9bSSFSMoxxrjQbhAL01zrm7bRDBoRR84uXXuT 1KMIfDxlgTQHaOLoM08EOItOFX9QNceqIiAkovbTgqQkZzxufmM4oJUBfEMTpaA8Axca4VyKwYw rWLuGsMg2DNxZrj+NxcMDmQKQ7LKGuh5CtlCN+CLvCeK0fx0H9KUKM5DC1x3wcIhjJkgSUpb4DY MKiNOfvz3VZNKzbr/R2cJ0EUihMURpfPQSLqnSIjXW1vhHBMxLratn0RIafy80t22QngdLoNHgw xy62/sBTjF7N2/5L6M2Qy9i6CliFq0ecCuyN1wUM= X-Received: by 2002:a17:902:e982:b0:295:290d:4afa with SMTP id d9443c01a7336-2a8d96b0eb9mr115559215ad.23.1770111113170; Tue, 03 Feb 2026 01:31:53 -0800 (PST) X-Received: by 2002:a17:902:e982:b0:295:290d:4afa with SMTP id d9443c01a7336-2a8d96b0eb9mr115558825ad.23.1770111112690; Tue, 03 Feb 2026 01:31:52 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a8dc225534sm111999505ad.68.2026.02.03.01.31.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 01:31:52 -0800 (PST) Message-ID: <0f8c0e5e-4921-47e8-b602-e6c08bb1f6f8@oss.qualcomm.com> Date: Tue, 3 Feb 2026 15:01:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] soc: qcom: ice: Add explicit power-domain and clock voting calls for ICE To: Konrad Dybcio , Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , cros-qcom-dts-watchers@chromium.org Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> <20260123-qcom_ice_power_and_clk_vote-v1-11-e9059776f85c@qti.qualcomm.com> <7da1727a-c1cd-466d-88fc-e140b2e7fe5d@kernel.org> <54bf72b6-6397-4655-9c30-680b1374400b@kernel.org> <82a6ba61-94a4-48bc-a012-d09152b32781@oss.qualcomm.com> <646bee0a-8b10-4fa8-9d17-030876179c02@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <646bee0a-8b10-4fa8-9d17-030876179c02@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Lj5ltH_SOjvIqTUxbggoED1GBRP0F6R- X-Authority-Analysis: v=2.4 cv=dcmNHHXe c=1 sm=1 tr=0 ts=6981c08a cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=TJZTRc1pyfe8BRA72ZMA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: Lj5ltH_SOjvIqTUxbggoED1GBRP0F6R- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA3NCBTYWx0ZWRfX2TipZlGSAbsG VM58RZ2QNLU3YIq96KFMGQj7fwllGxTFGZ07GL8z3mDdf+X9fktGYoOZm9QHfCjI3Qj+4Cf7TgJ Rn/Vo6FwFnramrXeRASvS8jhwwv8cZYVZ8ZiNf3o8mXpiXxgbTcH5LKnigWeGGZHTZ+sjl0DpDL ZgUdvI6kkwGAi35h85C04Z2H3i0jli6c5oUjosb86vdTnMlSKxgYV598dQ756u7dVSHRyF4aFHQ Ma799WxpGMXNGUZ4jKqHlCRH9p2Gaxix9SdXPd98XVymHLCd4c8qkC7s2PigQvcLUu1A8Z2sXqt 7qbIQbpojGOThOmMH3eztVlgZqbdNvonEukX4Khu2nEnLiNIKnVKBEbPNyW4HKgF/ulfr26cxOr sTsMKMM5SfaMMK297qdUbuuKj/5r9ywMUb47VYewgzOcOpfWO4LhgXwK+ZeCeXTOYZ/FseTKSTx VBrm9abfHNFT+DLympw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030074 Hi Konrad, On 1/30/2026 4:16 PM, Konrad Dybcio wrote: > On 1/23/26 12:12 PM, Harshal Dev wrote: >> Hi Krzysztof, >> >> On 1/23/2026 4:27 PM, Krzysztof Kozlowski wrote: >>> On 23/01/2026 09:58, Krzysztof Kozlowski wrote: >>>>> >>>>> return 0; >>>>> @@ -584,6 +597,10 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, >>>>> if (IS_ERR(engine->core_clk)) >>>>> return ERR_CAST(engine->core_clk); >>>>> >>>>> + engine->iface_clk = devm_clk_get_enabled(dev, "iface_clk"); >>>>> + if (IS_ERR(engine->iface_clk)) >>>>> + return ERR_CAST(engine->iface_clk); >>>> >>>> And here actual breakage of ALL in-tree and out-of-tree DTS. >>>> >>>> NAK. >>>> >>>> Please read internal guideline. >>> >>> Internal docs are pretty scattered and messy so I failed to find this >>> there, which is surprising because this was frequent feedback. Therefore >>> please update Kernel Upstreaming internal page with following: >>> >>> With few exceptions, it is not allowed to break the ABI, by making >>> bindings or driver changes, where the existing or out of tree DTS would >>> fail to boot. Updating in-tree DTS does not matter here, because DTS >>> goes via different branch, thus driver branch would be always broken. >>> This is explicitly documented in DT rules and explained also in >>> maintainer-soc profile. >>> >>> You need to either provide strong justification for ABI break or make >>> the changes backwards compatible. > > If the ICE can not be powered on alone without this change (i.e. no UFS, > just ICE), then please spell it out explicitly, Harshal. That makes for a > valid reason to break the ABI. > > Plus the fact that without an OPP table, the voltage requirements cannot > be guaranteed to be met > Ack, I have endorsed and stated this point on the DT-binding commit. I'll wait for Krzysztof's view before updating the commit message to strongly reflect this point. >> >> Ack and understood. Let me write this in a way that makes it backward >> compatible by using devm_clk_get_optional_enabled(). Like I explained, for >> Linux distros where CONFIG_SCSI_UFS_QCOM is override set to 'y'. This >> clock vote isn't really needed during probe. > > This is really a side-effect that we shouldn't be depending on, or > even considering as a backup, since the UFS driver may change > independently and stop behaving this way one day > >> In qcom_ice_suspend/resume(). I'll only prepare/un-prepare this clock >> if it was found during probe. > > Clock APIs generally happily eat nullptrs Ack, then I guess in either case we can continue to keep the calls to prepare/un-prepare. Anyways, I am convinced we should specify and use the 'iface' clock. Thanks, Harshal > > Konrad