From: Hans de Goede <hdegoede@redhat.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Thomas Weißschuh" <thomas@weissschuh.net>,
"Mark Gross" <markgross@kernel.org>,
"Jeremy Soller" <jeremy@system76.com>,
"System76 Product Development" <productdev@system76.com>,
"Azael Avalos" <coproscefalo@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 1/4] platform/x86: gigabyte: constify pointers to hwmon_channel_info
Date: Mon, 15 May 2023 15:22:30 +0200 [thread overview]
Message-ID: <0f8e5fc7-2efb-ceac-ac83-fbc8e7b62d3e@redhat.com> (raw)
In-Reply-To: <20230511175627.282246-1-krzysztof.kozlowski@linaro.org>
Hi,
On 5/11/23 19:56, Krzysztof Kozlowski wrote:
> Statically allocated array of pointers to hwmon_channel_info can be made
> const for safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/gigabyte-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index 8aa665e866b8..f6ba88baee4d 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -94,7 +94,7 @@ static umode_t gigabyte_wmi_hwmon_is_visible(const void *data, enum hwmon_sensor
> return usable_sensors_mask & BIT(channel) ? 0444 : 0;
> }
>
> -static const struct hwmon_channel_info *gigabyte_wmi_hwmon_info[] = {
> +static const struct hwmon_channel_info * const gigabyte_wmi_hwmon_info[] = {
> HWMON_CHANNEL_INFO(temp,
> HWMON_T_INPUT,
> HWMON_T_INPUT,
prev parent reply other threads:[~2023-05-15 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 17:56 Krzysztof Kozlowski
2023-05-11 17:56 ` [RESEND PATCH 2/4] platform/x86: hp: " Krzysztof Kozlowski
2023-05-11 17:56 ` [RESEND PATCH 3/4] platform/x86: system76: " Krzysztof Kozlowski
2023-05-11 17:56 ` [RESEND PATCH 4/4] platform/x86: toshiba: " Krzysztof Kozlowski
2023-05-15 13:22 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f8e5fc7-2efb-ceac-ac83-fbc8e7b62d3e@redhat.com \
--to=hdegoede@redhat.com \
--cc=coproscefalo@gmail.com \
--cc=jeremy@system76.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=productdev@system76.com \
--cc=thomas@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®