mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: kbuild test robot <lkp@intel.com>, Maciej Purski <m.purski@samsung.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: drivers/gpu/drm/bridge/sil-sii8620.c:2405: undefined reference to `extcon_unregister_notifier'
Date: Mon, 30 Apr 2018 11:23:05 -0700	[thread overview]
Message-ID: <0f8f6643-9c8a-6427-4b8f-e2d1a3a09531@infradead.org> (raw)
In-Reply-To: <201804291100.alIrExlq%fengguang.wu@intel.com>

On 04/28/2018 08:15 PM, kbuild test robot wrote:
> Hi Maciej,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   19b9ad67310ed2f685062a00aec602bec33835f0
> commit: 688838442147d9dd94c2ef7c2c31a35cf150c5fa drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL
> date:   7 weeks ago
> config: x86_64-randconfig-s4-04290805 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout 688838442147d9dd94c2ef7c2c31a35cf150c5fa
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_remove':
>>> drivers/gpu/drm/bridge/sil-sii8620.c:2405: undefined reference to `extcon_unregister_notifier'
>    drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_extcon_init':
>>> drivers/gpu/drm/bridge/sil-sii8620.c:2229: undefined reference to `extcon_find_edev_by_node'
>>> drivers/gpu/drm/bridge/sil-sii8620.c:2241: undefined reference to `extcon_register_notifier'
>    drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_extcon_work':
>>> drivers/gpu/drm/bridge/sil-sii8620.c:2189: undefined reference to `extcon_get_state'

The correct fix for this IMO is:
config DRM_SIL_SII8620
...
	depends on EXTCON || !EXTCON

but doing that causes kconfig-recursive-dependency-hell-messy-spaghetti.
OTOH, doing:
	select EXTCON
does not cause any kconfig recursive dependency issues and solves the build
errors.


-- 
~Randy

  reply	other threads:[~2018-04-30 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-29  3:15 kbuild test robot
2018-04-30 18:23 ` Randy Dunlap [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-04 17:57 kbuild test robot
     [not found] <CGME20180406095349epcas2p22b69ac92909aeddc04a4e7a4f3c64c3f@epcas2p2.samsung.com>
2018-04-06  9:52 ` kbuild test robot
2018-04-06 10:14   ` Andrzej Hajda
2018-04-06 10:34     ` Chanwoo Choi
2018-04-06 13:55       ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f8f6643-9c8a-6427-4b8f-e2d1a3a09531@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=a.hajda@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=m.purski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®