From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5564086338 for ; Tue, 7 Jan 2025 07:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736236580; cv=none; b=Ju9mt5NoOvhMxVE0TSa8rBZkSbmba7swXi61SER7SQWwoDTgNi7JygFuXWZq/YFPQTPChx7XIb94+D/OOwRfM5bZpNP1sFlemE7nPX/OgYyED1xhkCaVUrcrfSi34Vtc10q6N+OITkJKZmcsDbMWejO1X0+rtqbptntV5hW1YK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736236580; c=relaxed/simple; bh=2V4xd9bQ7zsqkBpcX5D5YGt116oOfH9ExzPAzVi1vRg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n6EsU1pqcps7SylSz8DDZOtkQcPdZLxiauOY8GPFZGdUDbNfOc7On8LKMvD/qFJFY7XqHId8Vv5sPbM3+u96v7hg01RSMGWHsWQdioxKNZdVat2QWTJMx4A9nbnbr4P4fwkkmqVLbw1XsAWQ6YfXH3aU9yDtm436CFZX+QpQihs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=IePT2qhU; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="IePT2qhU" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso14553258f8f.2 for ; Mon, 06 Jan 2025 23:56:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736236575; x=1736841375; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=sZ8pJhAisSeXRzr/sec6vfVpCK3RZROX0EmSm6DYgRI=; b=IePT2qhU4Vvs8xZgSp5GtZCxO+1Zdq6MmWJjiSAYX5R8bZrKlQUCKvQ6AYIIa/AMzC DMQtfkSUKsm6fZjsCYKgPVhghBsDxowK+qHd881Qy8eoQtZ5pCyk0b79eZqMFKlH1LkO iQ4S85vvcB+AHNVxAInt2Xb+0lSgpJnoXwQs3gGdCO+CLF7uSn5q0m9J8PmEyqTjZ/GW sCpV/IH89BHZlvq7GeQ+Nb0JJkdcJ1xTqNDbgvZxN1/u53eiK94O/sWF0IZtdvkEKq5g Q0r9m21bweFMeNJg3z5IivxJ80p/VMZAnTLHOz0Hwb9ETClNOwUHOyISH4YSC8DzFcGE PHDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736236575; x=1736841375; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sZ8pJhAisSeXRzr/sec6vfVpCK3RZROX0EmSm6DYgRI=; b=vgtP4OktX5FbGM0tiJ2mz2ugJgVMwFja4vfMoC/1rRDXyPrS/TvZ82T2YRQZC4u8No CHA42sVs7CubJt6ZxP7yCCu+7JlOENG3lJJBxtMnZRMyLchQ0A4wHo/8wXDIgufDbrD9 8ldXxepRuBbDQbhUiewFT3uflh3ESfNjLEwfcZ8GpIct70fSCFwP82NXe5eykuc73g2m +FMJcDjmDjllpnOnq0PfvYYhlVugR82hnTFvHB3TdrdWkgF4zQYdBEc63dWg7esc+Jw8 roNo4B8DuVJtddn2rmUBmMXz4EdyknoUlwoJ6DUjaYFj1FEWfRp+t6Wc2XvCU2T7jnqd /D2w== X-Forwarded-Encrypted: i=1; AJvYcCVPgowcnKKslHNv+DKrE/IClym/jxfwAZn3fgNs+Q1TS9Ab7toogIKfqv5TQgS6Lr1YBkHogDW4U1ad8Kw=@vger.kernel.org X-Gm-Message-State: AOJu0YyXUYS2yXNy+SI+vgiwxYdQxUYeygINm7FNZlvYXRmegkzR3DG9 1V9NFXUU0sK4v6DvQ/4XXMjD4nTPNDSUREDhCZdScmBC/AH9riY58jt01PHJIg== X-Gm-Gg: ASbGncuZSgH28Y50XcOihAfZ4WAYWWsViZi4jc+C9/VKVWGdC8KnYH3oyw7RocM8BxX JDTh4foylvPTs/46IVB9X1g612dnTVdVvGzYdjLO9mzq9AiX/vLpFCCoBeUqiREnVYGakLWyw9a CzVf6Ur8yvlCiCTbTaIjj9ZVjDR0S6pJ9QlsO+j6AMyfOjFGeFDPnsUwE9k29XfUNspZd4G96Ic hwUDfsxIhfvpTaCyS6O23I1dnh+sBYfP4uifDzjX+pkje9IWpYZx7NEBJndkI6psXvsg7CdxVEN /0wa2KxWlUq4VPsd8dYa2NavG6QtrKoStJeRqPTgkA== X-Google-Smtp-Source: AGHT+IF1hMDTVebgHUuVEgYhuFlwpTzXeNj4hxEa4Dp2c5Rt3BOJt0BHLOo7k9j4Nh48CB2sDG/wXw== X-Received: by 2002:a5d:47ab:0:b0:386:1ab5:f0e1 with SMTP id ffacd0b85a97d-38a221ea67fmr57490789f8f.14.1736236575686; Mon, 06 Jan 2025 23:56:15 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c846ca4sm50600894f8f.43.2025.01.06.23.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 23:56:15 -0800 (PST) Message-ID: <0f8fc348-14f5-40ac-912a-1785caedb675@suse.com> Date: Tue, 7 Jan 2025 08:56:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] xen: update pvcalls_front_accept prototype To: Stefano Stabellini Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06.01.2025 22:36, Stefano Stabellini wrote: > xen: update pvcalls_front_accept prototype > > Signed-off-by: Stefano Stabellini > --- > > Changes in v2: > - also update pvcalls-front.c The patch still gives the impression of being incomplete: There's no caller of the function that you update. However, there's no such caller in the first place. Why don't you just delete the function then? Jan > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index b72ee9379d77..cab480059731 100644 > --- a/drivers/xen/pvcalls-front.c > +++ b/drivers/xen/pvcalls-front.c > @@ -769,7 +769,8 @@ int pvcalls_front_listen(struct socket *sock, int backlog) > return ret; > } > > -int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags) > +int pvcalls_front_accept(struct socket *sock, struct socket *newsock, > + struct proto_accept_arg *arg) > { > struct pvcalls_bedata *bedata; > struct sock_mapping *map; > @@ -788,7 +789,7 @@ int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags) > return -EINVAL; > } > > - nonblock = flags & SOCK_NONBLOCK; > + nonblock = arg->flags & SOCK_NONBLOCK; > /* > * Backend only supports 1 inflight accept request, will return > * errors for the others > diff --git a/drivers/xen/pvcalls-front.h b/drivers/xen/pvcalls-front.h > index f694ad77379f..881ef14660bc 100644 > --- a/drivers/xen/pvcalls-front.h > +++ b/drivers/xen/pvcalls-front.h > @@ -12,7 +12,7 @@ int pvcalls_front_bind(struct socket *sock, > int pvcalls_front_listen(struct socket *sock, int backlog); > int pvcalls_front_accept(struct socket *sock, > struct socket *newsock, > - int flags); > + struct proto_accept_arg *arg); > int pvcalls_front_sendmsg(struct socket *sock, > struct msghdr *msg, > size_t len); >