From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: eahariha@linux.microsoft.com
Subject: Re: [PATCH v3 5/6] docs: i2c: summary: document 'local' and 'remote' targets
Date: Thu, 20 Jun 2024 09:05:43 -0700 [thread overview]
Message-ID: <0f95bbc5-c1d6-4557-b401-90fcfe541df0@linux.microsoft.com> (raw)
In-Reply-To: <cu2mkl42byhce6eytcnw7yseogbnypgtrkoirlezakwg35egdg@vjjye4ca7yey>
On 6/19/2024 12:10 AM, Wolfram Sang wrote:
> Hi,
>
>>> "Synonyms" from patch 6 does say that controller/target is preferred but
>>> couched it in the caveat "If speaking about I2C in general" and
>>> adapter/client when "discuss[ing] implementation details." I was trying
>>> to give space for an unambiguous recommendation.
>>
>> Exactly, this is what I referred to in my previous e-mails.
>> These two statements sound a bit ambiguous to me, as well.
>
> Okay, here is my proposed update:
>
> ===
>
> diff --git a/Documentation/i2c/summary.rst b/Documentation/i2c/summary.rst
> index 90f46f1504fe..579a1c7df200 100644
> --- a/Documentation/i2c/summary.rst
> +++ b/Documentation/i2c/summary.rst
> @@ -67,9 +67,9 @@ Synonyms
>
> As mentioned above, the Linux I2C implementation historically uses the terms
> "adapter" for controller and "client" for target. A number of data structures
> -have these synonyms in their name. So, to discuss implementation details, it
> -might be easier to use these terms. If speaking about I2C in general, the
> -official terminology is preferred.
> +have these synonyms in their name. So, when discussing implementation details,
> +you should be aware of these terms as well. The official wording is preferred,
> +though.
>
> ===
>
> I don't want to be stricter than "preferred". If someone still wants to
> use 'struct i2c_client *client' this is fine with me.
I'm ok with this. I'll let Andi decide if he wants to have
adapter/client refactoring now or in the future or at all.
Thanks,
Easwar
next prev parent reply other threads:[~2024-06-20 16:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 8:12 [PATCH v3 0/6] docs: i2c: summary: update and use inclusive wording Wolfram Sang
2024-06-14 8:12 ` [PATCH v3 1/6] docs: i2c: summary: start sentences consistently Wolfram Sang
2024-06-15 17:47 ` Andi Shyti
2024-06-14 8:12 ` [PATCH v3 2/6] docs: i2c: summary: update I2C specification link Wolfram Sang
2024-06-15 17:48 ` Andi Shyti
2024-06-14 8:12 ` [PATCH v3 3/6] docs: i2c: summary: update speed mode description Wolfram Sang
2024-06-15 18:07 ` Andi Shyti
2024-06-14 8:12 ` [PATCH v3 4/6] docs: i2c: summary: document use of inclusive language Wolfram Sang
2024-06-15 18:12 ` Andi Shyti
2024-06-14 8:12 ` [PATCH v3 5/6] docs: i2c: summary: document 'local' and 'remote' targets Wolfram Sang
2024-06-15 20:49 ` Andi Shyti
2024-06-16 19:14 ` Wolfram Sang
2024-06-17 11:58 ` Andi Shyti
2024-06-17 16:45 ` Wolfram Sang
2024-06-17 16:57 ` Easwar Hariharan
2024-06-17 19:25 ` Andi Shyti
2024-06-19 7:10 ` Wolfram Sang
2024-06-20 16:05 ` Easwar Hariharan [this message]
2024-06-20 23:39 ` Andi Shyti
2024-06-20 23:38 ` Andi Shyti
2024-06-21 7:03 ` Wolfram Sang
2024-06-14 8:12 ` [PATCH v3 6/6] docs: i2c: summary: be clearer with 'controller/target' and 'adapter/client' pairs Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f95bbc5-c1d6-4557-b401-90fcfe541df0@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=andi.shyti@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome