From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A5FC0502A for ; Fri, 26 Aug 2022 21:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345125AbiHZVs0 (ORCPT ); Fri, 26 Aug 2022 17:48:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345196AbiHZVsC (ORCPT ); Fri, 26 Aug 2022 17:48:02 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA24EE68ED for ; Fri, 26 Aug 2022 14:47:29 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id w196so3543178oiw.10 for ; Fri, 26 Aug 2022 14:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc; bh=CK+sMbdIAIuWYSo5Q4OVGY5Ul3jZA6hp/WZ7+Gsk4cQ=; b=ik5XLFmUCEL3+etpXE3CESeQSxuv7z4LNhd3MBNm4AFJnjhT76KtIcOP4M+YeH3f7i p+7fb+v0bmdH6qDd0a7ZsmguGENWHDe+O/OP1oI2sKKsuGAsxm4WINsjmiFyvl9b4zUR Rxf7OVPtrPqcK4mA+kK9o85IC/9b8Xwu9cvZc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc; bh=CK+sMbdIAIuWYSo5Q4OVGY5Ul3jZA6hp/WZ7+Gsk4cQ=; b=lrxcprZwU7ojXBEZ60YM8M53WfScuiXpZnL4s33CBtYCyKwpjXQA/mKeb6JWZUKTf9 sOXGYsYzOnHBeg4Zg4fk9bmOrkrqNqiozCtAf2p5ZZ365ZjZFSPKXvsHV0Q4bbU8vYGW z9qUWq2yNWmqqspNH9tjQsQ4oNmIo4F5Z9ORdLOjJSpudNlVwDOPHh3mIYdPbaju/W66 iY42TBlCgcyzKMpV5RZ/8aaZTA6QGCyi8BCiAcQZ3C2rB/rX1fLAh5mFGJVMJ4Qk7gjS ya6+7TsbQd0FoXU3Ezf18XRa/0wNj/6YVhLdQCywwkugZ6vIYGy1v/QV/LtADP0tLk/M /x/A== X-Gm-Message-State: ACgBeo0OS/fSPMKolPXquMH2S1OFHESLjnGC4B8ngUBzXWjBWhx9F1u3 RtaVqrUJlYBmpo6gRCYOU/PcJQ== X-Google-Smtp-Source: AA6agR4xAqtIsz06Lx9OywleQrMSR01DmaFjYxlIxy9gZ+7x9P0vfYm+nLME0yrsLu2sV2xjrsGl+A== X-Received: by 2002:aca:38c1:0:b0:345:8c44:f2bd with SMTP id f184-20020aca38c1000000b003458c44f2bdmr2560444oia.80.1661550448873; Fri, 26 Aug 2022 14:47:28 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id q16-20020a05683033d000b00638dd127f54sm1611375ott.1.2022.08.26.14.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 14:47:28 -0700 (PDT) Subject: Re: [RESEND PATCH 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver To: Meng Li , Huang Rui , linux-pm@vger.kernel.org Cc: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , linux-kernel@vger.kernel.org, Shuah Khan References: <20220817034630.1172065-1-li.meng@amd.com> <20220817034630.1172065-3-li.meng@amd.com> From: Shuah Khan Message-ID: <0f9706b7-6dd5-663d-70cf-7221b5a1bfc5@linuxfoundation.org> Date: Fri, 26 Aug 2022 15:47:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220817034630.1172065-3-li.meng@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/16/22 9:46 PM, Meng Li wrote: > Add amd-pstate-ut test module, this module is used by kselftest > to unit test amd-pstate functionality. This module will be > expected by some of selftests to be present and loaded. > > Signed-off-by: Meng Li > Acked-by: Huang Rui > Reviewed-by: Shuah Khan > --- > drivers/cpufreq/Kconfig.x86 | 7 + > drivers/cpufreq/Makefile | 1 + > drivers/cpufreq/amd-pstate-ut.c | 293 ++++++++++++++++++++++++++++++++ > 3 files changed, 301 insertions(+) > create mode 100644 drivers/cpufreq/amd-pstate-ut.c > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index 55516043b656..fdd819069d72 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -51,6 +51,13 @@ config X86_AMD_PSTATE > > If in doubt, say N. > > +config X86_AMD_PSTATE_UT > + tristate "selftest for AMD Processor P-State driver" > + depends on X86 && ACPI_PROCESSOR > + default n > + help > + This kernel module is used for testing. It's safe to say M here. > + Shouldn't this X86_AMD_PSTATE_UT depend on X86_AMD_PSTATE? I am running a few tests and when I have X86_AMD_PSTATE_UT enabled as built-in and X86_AMD_PSTATE is disabled, test fails saying incorrect cpufreq driver? Skipped: Test can only run on amd-pstate driver. So it sounds like X86_AMD_PSTATE_UT depends on X86_AMD_PSTATE. thanks, -- Shuah