From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A45C9C6FA89 for ; Mon, 12 Sep 2022 18:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231186AbiILSkp (ORCPT ); Mon, 12 Sep 2022 14:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231157AbiILSkU (ORCPT ); Mon, 12 Sep 2022 14:40:20 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9A4BC2D for ; Mon, 12 Sep 2022 11:39:47 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id j6-20020a17090a694600b00200bba67dadso9019489pjm.5 for ; Mon, 12 Sep 2022 11:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=bs6cY7jsJqoKWWPHSReiAiAq8v2yuiAMDwslSXetISo=; b=rcXmXPCVnwCcRVgP2Twc30tTHXUF+WsfGDNbmtzRFUEU9vaxsyXceGBG7JTMjbiT8G wkfZapuTCZOuPsq4/c0vPoyL/WNn1DtoJekFDrCwa7zD32zpxvb/S5V9XsbhlNh4+2e3 WZvOQVtKWg4xyZi7H/rIVhrTbsSIwwwwfvqGra67loAudGAFeB8172IdWwq0crHFiJWm eSu9O5l4+zgZHfr3o1bmTbl/dtYwV/o189fTmy0Mh4FxBQgvSAE9kG9sTbjZAt5hj4p+ /Jg5E+nt4XJDGVEgt3L+Y/EAN+5YdO7CHVTZuK7VVW7m/dtQSPJOS6/Wltq9DZfPAqAy Ekmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=bs6cY7jsJqoKWWPHSReiAiAq8v2yuiAMDwslSXetISo=; b=G7azjU/o8FjyTc7I29W4V6kVMAu5rG838QLyYfjYLYUMYP6GgPzGY9B1ynr+595u8D 8LBLpBe2h9c7LoExRcnXGJNiYCJFaESGZ1tsdyuJmaICVcGQvNIBrlFLVZmh6ob1sEI8 CaLYgEa9bJbZUmGZ/Bw6P1IKrlggrI+YiIKoKnNA2cQqBLJ14aSsMZ3p2p+df/ysZLIn V4xYptHZvkhaDLLYw2hKCgzj+jkYH+OEorugSzousprsTKCxLLe+0bY+YEmqzGWt1wmY 1rjUSE++ixPyfxIvMvUzUXHmzXkCAVz6ZNvOvUXpR800BEX/XveJD2b2gemV8bN0kRYM FbJg== X-Gm-Message-State: ACgBeo00zLZofjIra9oWi2HRxCCCGGQh+vsGsX3TCEyX9ae3BJQx1OKj /W/+d+hK6gr25DseIPtzZflTVg== X-Google-Smtp-Source: AA6agR50Ne1mei+wMUxARhvXYS3lsDFitgnEjrHfsvDUce33WQnq7GF8owQjID6Zrcapn13BcvL+nQ== X-Received: by 2002:a17:90b:2743:b0:200:9be5:d492 with SMTP id qi3-20020a17090b274300b002009be5d492mr25287793pjb.237.1663007986508; Mon, 12 Sep 2022 11:39:46 -0700 (PDT) Received: from ?IPV6:2401:4900:1c60:5362:9d7f:2354:1d0a:78e3? ([2401:4900:1c60:5362:9d7f:2354:1d0a:78e3]) by smtp.gmail.com with ESMTPSA id s18-20020a170902c65200b00176d8e33601sm6312937pls.203.2022.09.12.11.39.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 11:39:46 -0700 (PDT) Message-ID: <0f98adbf-1786-7212-77e2-22c58484aed1@linaro.org> Date: Tue, 13 Sep 2022 00:09:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 4/4] dt-bindings: net: snps,dwmac: Update interrupt-names Content-Language: en-US To: Krzysztof Kozlowski , devicetree@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, Bjorn Andersson , Rob Herring , Vinod Koul , David Miller References: <20220907204924.2040384-1-bhupesh.sharma@linaro.org> <20220907204924.2040384-5-bhupesh.sharma@linaro.org> <71d970bc-fe6f-91e7-80c1-711af1af5530@linaro.org> From: Bhupesh Sharma In-Reply-To: <71d970bc-fe6f-91e7-80c1-711af1af5530@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/22 8:13 PM, Krzysztof Kozlowski wrote: > On 07/09/2022 22:49, Bhupesh Sharma wrote: >> As commit fc191af1bb0d ("net: stmmac: platform: Fix misleading >> interrupt error msg") noted, not every stmmac based platform >> makes use of the 'eth_wake_irq' or 'eth_lpi' interrupts. >> >> So, update the 'interrupt-names' inside 'snps,dwmac' YAML >> bindings to reflect the same. >> >> Cc: Bjorn Andersson >> Cc: Rob Herring >> Cc: Vinod Koul >> Cc: David Miller >> Signed-off-by: Bhupesh Sharma >> --- >> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index f89ca308d55f..4d7fe4ee3d87 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -105,10 +105,12 @@ properties: >> >> interrupt-names: >> minItems: 1 >> - items: >> - - const: macirq >> - - const: eth_wake_irq >> - - const: eth_lpi >> + maxItems: 3 >> + contains: >> + enum: >> + - macirq >> + - eth_wake_irq >> + - eth_lpi >> > > This gives quite a flexibility, e.g. missing macirq. Instead should be > probably a list with enums: > items: > - const: macirq > - enum: [eth_wake_irq, eth_lpi] > - enum: [eth_wake_irq, eth_lpi] Ok, will fix in v2. Thanks.