mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "moe@flashbots.net" <moe@flashbots.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"kas@kernel.org" <kas@kernel.org>,
	"Miao, Jun" <jun.miao@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"sathyanarayanan.kuppuswamy@linux.intel.com"
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"djbw@kernel.org" <djbw@kernel.org>
Subject: Re: [🚨ext] Re: [PATCH v3 0/2] virt: tdx-guest: Fix and speed up the wait for a Quote
Date: Fri, 13 Nov 2026 17:33:25 +0000	[thread overview]
Message-ID: <0f9ba1a6acb57a8c126739175b4e38dafac08c9d.camel@intel.com> (raw)
In-Reply-To: <CAKV3HMM9BKpmgWeFqRqamAsqqiofj+TG4DrOEHmbUyE0FjA7+w@mail.gmail.com>

On Tue, 2026-11-03 at 09:56 +0000, Moe Mahhouk wrote:
> On Mon, 2026-11-02 at 19:55 +0000, Edgecombe, Rick P wrote:
> > Long term though, isn't this a better option? This patch is
> > essentially a performance optimization.
> 
> Agreed that interrupt-driven completion is the better end state where the
> VMM supports it. But I don't think it can replace polling.
> SetupEventNotifyInterrupt is optional in the GHCI and enumerated through
> GetTdVmCallInfo. KVM only forwards it to userspace (since v6.16), and a
> VMM that doesn't implement it returns SUBFUNC_UNSUPPORTED. So the guest
> still needs a polling fallback for older KVM/QEMU and for other VMMs.
> Patch 2 is about that fallback.

We do expect quote execution time to change, so this may not be optimal long
term. The exponential backoff could limit it to 2x the real quote time. For a
long quote this could be pretty long. I'd almost wonder if the guest would
normally be happy to spend more cycles on getting a faster quote. Can you
explain more about the quote use case you are targeting?

      parent reply	other threads:[~2026-11-13 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 19:17 Moe Mahhouk via B4 Relay
2026-10-24 19:17 ` [PATCH v3 1/2] virt: tdx-guest: Fix timeout detection in wait_for_quote_completion() Moe Mahhouk via B4 Relay
2026-10-27 13:50   ` Xiaoyao Li
2026-10-24 19:17 ` [PATCH v3 2/2] virt: tdx-guest: Poll Quote status with exponential backoff Moe Mahhouk via B4 Relay
2026-10-27 14:08   ` Xiaoyao Li
2026-11-03 10:03     ` [🚨ext] " Moe Mahhouk
2026-11-02 19:55 ` [PATCH v3 0/2] virt: tdx-guest: Fix and speed up the wait for a Quote Edgecombe, Rick P
2026-11-03  9:56   ` [🚨ext] " Moe Mahhouk
2026-11-13  9:09     ` Moe Mahhouk
2026-11-13 17:33     ` Edgecombe, Rick P [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f9ba1a6acb57a8c126739175b4e38dafac08c9d.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=djbw@kernel.org \
    --cc=erdemaktas@google.com \
    --cc=jun.miao@intel.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moe@flashbots.net \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®