From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A964C27F006 for ; Fri, 12 Sep 2025 09:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757670119; cv=none; b=XoEg8S5kepyTZz3zjI9jGa/JD1YVPTvfyyETTZ+BO7drbIuRXReMkss4iQfLYAjZpszALMuE+ZTtlPTqFM/c7dgomJP8pWnnSxfItW5La5rUYWHL61uF421IZssSehzknSM0e3bKdgTUPL1H8iTSUG4GJUcvqLy4i2/JWJEaH7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757670119; c=relaxed/simple; bh=aHZH4YS5dVoOj6kl4jXgDRDoWhg+l0J0dv5TXRxoBzo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CT3RuRFJzy/0x9Wf1tbci/CfiJrjrNjtYw1L9b70h5aGDoBzj6hIdrEMDWo0MYNyHz6GWww4CR99gnz4OHTfVgzO3bFRowlH3cSHoeeVPu5Blvsyjl6RlzNXt6QV49tLBxMZzLClGMLlN9ixXyIMdnCGTe+eXRsPwcp62VCs+0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=frl1N9yB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="frl1N9yB" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58C9fGh3019748 for ; Fri, 12 Sep 2025 09:41:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ubdZE+2MGy4tFDpQKrzviatnp7P+PiPFBJ3kNogasGs=; b=frl1N9yBvDBrBz+g vYpk/y637iCILK5KDEzRuFB1WIT4wlp3iA7Ak3xcVXtckYYSF94Zme5MDaBuQXn2 91njJBp2xEcqFGcBQUSHSCBnCBuYDkDiHbsoiQ8yGQmexU7bb7Ntfmp0WyCqOTE2 uGBhM20XnimXZfWw4fPpeDIuzI/fN9Fzes9TkxsPQT4QCeCepqUAKEdHfQ9GoQe4 yyubFKuDfYboEzIEUsyPMdiDwshIPMZ43ycg4ycI1BYoYRnv3T+sAr8dN6p5Ydok 7pBYoiTgxjeMZhxFiYq4EkyTupvgEh5gDNuWZbvNu3+AaZD0zNVjIQzDOtn6lQYg w+PA8g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 491t387f15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 12 Sep 2025 09:41:56 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-819d2492a75so52206285a.1 for ; Fri, 12 Sep 2025 02:41:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757670115; x=1758274915; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ubdZE+2MGy4tFDpQKrzviatnp7P+PiPFBJ3kNogasGs=; b=YCOo3YYbtM0WCH9l3xoWrijhsYQ1ShRPIXn9pHW46OOb8S3x2B4cjKjzQdV+TrDPoi fzOSiQmR8zN9XmN3k6dcVHs1ymVI6NW+3eHwSe4rt79qvLvweIm24isISOc0PGp5zdcx eshkSzAbNoLH5GRVpPoAZlrsGJ0VadSlLbCY7Y6780s48CB3vnbAK/a5B/3JEiDFG+Rg 1q4b3mtvGx7vut9iOdWxOYyL0+Og/vEBHG3pi+Ka8ljG9SwsTW7z0UtG0WnaANMJ36Qa Ouakb65x4KPl5XzdR9GOBQ8C9hEs7rJk0kSo6l9XiJKZwnaKFhtD7yD39mLdCc8wFH4d 3WfA== X-Forwarded-Encrypted: i=1; AJvYcCXtXcn771iCMGJ3rZcW6rgEjosz/KrVuT3lnHkaXxh2j8DCDDfmE/+ZdiYoeGdpQWiF1nt8eiQNiRRNi1M=@vger.kernel.org X-Gm-Message-State: AOJu0YzdebfYqHwwfJ1HqFpRPEyQP2GlD7uZcG0+fTzVMiWneU3qldo4 DAXqUHjifWf2TVxon7kPKTyZWdRp1ub7SjzQFjoldSmK0t9lx/vJw+YM7VQ/08GyvRK+96g4rDW VbjKDfrz1BdlIFpNXizqcUtmpvQ5i5LP50npdvpoPjbW2Vi7j6OSJ8mdXjBy6xhh9vBE= X-Gm-Gg: ASbGncvd/pRUefD7WKUSw9hLO9nS9lR3MjbfzbKEgrGBY/qJtgJKXUTVnpOaWrlpVDn wh9ZfJMBduVxWIpODmCiiI0II1YhMVRY55zF7yNe3ecNCGKsipQQjilzu8goZzxrWeIJ+OrWULj cWu85+WfRgGIcgH7IDhcLAulUtQ8mbMShr2uyKnixoS+JuGoe10uh2kOx+jpf/V9PO6c7RdAPcy VQ28ULPJ8tpee0DeV9M1VELjMlNXBg0kQbBuaKMf6aagm8hyJE2uLAVlPrVymsJdXUJlyab86Yx Z9eNHCh6Bmvmqy+VH/Ex+l5fS+VHwjPbRMCRJsOWnEUgE/B5komy7vCxL9eMQZLCrCwStCSv9Yx G+7CbSmuiSAY008i/QNKD5A== X-Received: by 2002:a05:6214:f05:b0:70d:e7e1:840f with SMTP id 6a1803df08f44-767c1c8fd01mr17754296d6.3.1757670114684; Fri, 12 Sep 2025 02:41:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW19WjSadyXUxnUE5X6AqSmTHftlhz5SicnK4cbK2PU6jUKPiXVwSAYDJJeeQH+UMau1p6vw== X-Received: by 2002:a05:6214:f05:b0:70d:e7e1:840f with SMTP id 6a1803df08f44-767c1c8fd01mr17753866d6.3.1757670114134; Fri, 12 Sep 2025 02:41:54 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62eed9aec1asm131613a12.3.2025.09.12.02.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 02:41:53 -0700 (PDT) Message-ID: <0f9d55a4-83a1-48f6-aa19-e3117192bebb@oss.qualcomm.com> Date: Fri, 12 Sep 2025 11:41:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/10] dt-bindings: clock: Add required "interconnect-cells" property To: Krzysztof Kozlowski , Luo Jie Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Varadarajan Narayanan , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Anusha Rao , Manikanta Mylavarapu , Devi Priya , Philipp Zabel , Richard Cochran , Konrad Dybcio , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_pavir@quicinc.com, quic_suruchia@quicinc.com References: <20250909-qcom_ipq5424_nsscc-v5-0-332c49a8512b@quicinc.com> <20250909-qcom_ipq5424_nsscc-v5-2-332c49a8512b@quicinc.com> <20250912-nocturnal-horse-of-acumen-5b2cbd@kuoka> <2951b362-c3c1-4608-8534-4d25b089f927@oss.qualcomm.com> <52714c33-5bd7-4ca5-bf1d-c89318c77746@linaro.org> <1cd6a0f9-2955-4189-8d1e-85fa8ad8dddd@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <1cd6a0f9-2955-4189-8d1e-85fa8ad8dddd@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: C3qDv7JKHifR-fO37-0lXBsPtV2m1yjj X-Proofpoint-GUID: C3qDv7JKHifR-fO37-0lXBsPtV2m1yjj X-Authority-Analysis: v=2.4 cv=NdLm13D4 c=1 sm=1 tr=0 ts=68c3eae4 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=r2WM0BnHFFIPBb0dDCkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA4MDA2NiBTYWx0ZWRfX+3X4ODyYFmik Oy0Uk1FIlj+y9sx/tCMwWnTwGXDpQrsiQsu261Vxlxd01ihM0WhfSCJ1AFRaMZLhw+hIbU5x5ak V/OlYN5mZ0FZ0qPt8rfNBNx9izVlkfUDMuGq8uRz3Chk5XBDZh7Jk3cbkkk6OqdW56Rt+62fVwo 8u6NdUpD4EO4INmsw9Eh7yp12ZceFFDHbuznaClxr+ABnXcL56DS89amEW/DuAlKOyoRxEG/n/m lIUL8nWcVLZ5BmYi7EjSonI6Xsb9+N03RDNZzEOGUBO7vfla72yeWEnSgZ57WvURTYBaKspdY8c ghzGdwNCGrhIFbJvOW20aIVu3Z+Df6Z6p9JMKBZy6DxvqxVMujsi6qZ7TMJ9/DZBTV0EKdvZ8Fj JeZ6+jEU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-12_03,2025-09-11_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509080066 On 9/12/25 11:27 AM, Krzysztof Kozlowski wrote: > On 12/09/2025 11:21, Konrad Dybcio wrote: >> On 9/12/25 11:17 AM, Krzysztof Kozlowski wrote: >>> On 12/09/2025 11:13, Konrad Dybcio wrote: >>>> On 9/12/25 11:13 AM, Konrad Dybcio wrote: >>>>> On 9/12/25 9:04 AM, Krzysztof Kozlowski wrote: >>>>>> On Tue, Sep 09, 2025 at 09:39:11PM +0800, Luo Jie wrote: >>>>>>> The Networking Subsystem (NSS) clock controller acts as both a clock >>>>>>> provider and an interconnect provider. The #interconnect-cells property >>>>>>> is mandatory in the Device Tree Source (DTS) to ensure that client >>>>>>> drivers, such as the PPE driver, can correctly acquire ICC clocks from >>>>>>> the NSS ICC provider. >>>>>>> >>>>>>> Although this property is already present in the NSS CC node of the DTS >>>>>>> for CMN PLL for IPQ9574 SoC which is currently supported, it was previously >>>>>>> omitted from the list of required properties in the bindings documentation. >>>>>>> Adding this as a required property is not expected to break the ABI for >>>>>>> currently supported SoC. >>>>>>> >>>>>>> Marking #interconnect-cells as required to comply with Device Tree (DT) >>>>>>> binding requirements for interconnect providers. >>>>>> >>>>>> DT bindings do not require interconnect-cells, so that's not a correct >>>>>> reason. Drop them from required properties. >>>>> >>>>> "Mark #interconnect-cells as required to allow consuming the provided >>>>> interconnect endpoints"? >>>> >>>> "which are in turn necessary for the SoC to function" >>> >>> If this never worked and code was buggy, never booted, was sent >>> incomplete and in junk state, then sure. Say like that. :) >>> >>> But I have a feeling code was working okayish... >> >> If Linux is unaware of resources, it can't turn them off/on, so it was >> only working courtesy of the previous boot stages messing with them. > > > Which is fine and present in all other cases/drivers/devices. Entire > Linux in many places relies on bootloader and that is not a "work by > coincidence". > > Another thing is if you keep backwards compatibility in the driver but > want to enforce DTS to care about these resources, but that is not > explained here, I think. I don't feel like arguing axiology today ;) But I see your point and I won't object to either outcome, so long as the property is *allowed* As a sidenote the IPQ SoCs have a rather thin layer of fw Konrad