From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ravb: Fix wrong dma_unmap_single() calls in ring unmapping
Date: Mon, 15 Jan 2024 08:28:12 +0600 [thread overview]
Message-ID: <0f9e73a2-075a-4a4d-9c74-de17d135567d@cogentembedded.com> (raw)
In-Reply-To: <c40ebf74-e7a7-4fa6-098c-42341a030bb5@omp.ru>
>> + if (le16_to_cpu(desc->ds_cc) != 0)
>
> It's not that != 0 or le16_to_cpu() are necessary here but we're on
> the little-endian platforms anyways...
Let's leave optimizing this out to compiler.
In the code, I'd vote for always having explicit conversion operation when reading __le16 value from memory.
Nikita
next prev parent reply other threads:[~2024-01-15 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 4:47 Nikita Yushchenko
2024-01-13 9:47 ` Sergey Shtylyov
2024-01-15 2:28 ` Nikita Yushchenko [this message]
2024-01-13 21:13 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f9e73a2-075a-4a4d-9c74-de17d135567d@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®