From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A861B4F1F for ; Thu, 2 Apr 2026 09:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775120729; cv=none; b=MEb5GrIFLLGe5z0nZaqLn4hC14dNw24mzH7joVk5qy7K2CDcrc87u53XKfhSSgLWdr7n4ofGGcbFmt4dbRvW0rvWJlbUmalSIBJXOaHP0hX8/UFNFcsuZLGMfwRLztR2LRVEHJcirjwAfqePM+/P1z7L1JDawy8kpu5lFQhsGmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775120729; c=relaxed/simple; bh=4xw/ga67voI/myNm1PvWwzm5TeuMOLMx8Q/7T61VA8Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OF3eUwt/yxvSob6hLiMIcNe1WKsB1fpiTFzZE0w/Vms/ki9sasPa5upLiCtJGqPWDUuBxcx6oH1urbfSKF2UIg3NXamQFsARLZaqngG0f3iTOW+RD2V21BLCHgCMt+DKwxT31fVPD3YycsoO8pnN2s2MCVMZayquivOZzXoTLNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y8F7MFnp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RsMssBFu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y8F7MFnp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RsMssBFu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775120727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uo3OmzGA2ckZBESUf6sgSBkAP6Pbi+eIBXMIiQ/bWFY=; b=Y8F7MFnpOxpSVQEghfc52b8ReBNa1r19g9ivtaVbOT2omWSWvZ3XGAPUOMXu8K0sa+QtNJ f98a3lKineIEMVx7ER04mKQ8XLL3qeLEoACQ8OX2fbk4YYPH0A9DvCyH0beoPL5IOj/RoC Ozy0km/MqPmqC3adgCWWLNnmV+t8Udg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-UJwHZZNcOhSV-RZtmFqSTA-1; Thu, 02 Apr 2026 05:05:25 -0400 X-MC-Unique: UJwHZZNcOhSV-RZtmFqSTA-1 X-Mimecast-MFC-AGG-ID: UJwHZZNcOhSV-RZtmFqSTA_1775120724 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d15f2e0f4so572927f8f.0 for ; Thu, 02 Apr 2026 02:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775120724; x=1775725524; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uo3OmzGA2ckZBESUf6sgSBkAP6Pbi+eIBXMIiQ/bWFY=; b=RsMssBFuqL4139FKn9bVrWyvsHjQd9pteDE1m6lqSLGOwYb2K0LnMXYGiR2xxbBYLm UL/VqIVWF1N958otTstcT3uw+tprz1OUsZKzKoNUZ/UMtKaLb+AQ4v9SDBmxg/2iFn5f pCyGFer+hLd689fnpCopOPwhu/hsTdh09AbboOHYNaTJM/LVJyuSEDlbiwHZrWDp1VYY JRtjWT6D0LyAHqIiv6G13nZUTFMKPgaxJjTdwYGNgnAxQbmy1PPRyVN0KuPij9fRfaop VLMJY+IsnyemiMOTxg22krODGeRBQMoEJ3dR5O9O6HtG/1UrHK54UKPEtw0SxHUSUC38 adjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775120724; x=1775725524; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uo3OmzGA2ckZBESUf6sgSBkAP6Pbi+eIBXMIiQ/bWFY=; b=UdcRoV7VZiCeyo9UG3aALG6qMY5nhzAE1z99eo61nL07vr7S31qYu7Ae0Z6y1OIknw 1vfEz6iJAdbCAQei70Tx1YcDjQbt6L5i6avt+/1YvMpqDjCBMm8Isuzu+PGQqEw+ZbjP 8ElFpFXJluMFFuhl3biEIFiC5ixBoUUw0+t42Wqx30VEzf+LXapQggjjhUXSl2SoEjl6 KJgOnxQKF4bObqX2CxRcpob/QEIeVTiVZP2qmcpkM5p36d84LLt0LW7WX3vcOan9R3l8 ecDo/gTKx4WnJ3WvJ2iulNcUpdmOPZJ6swNEaCTONZp/QH9bq6DQBIIgLgjwncnq/QCY Te9w== X-Forwarded-Encrypted: i=1; AJvYcCXUWQtqSd8Ti0eUkwjWzKcqvlgvweMFVrbv90l8yyetZzKfKufyC/SS8GypvlwNV32wG0yQt88ga0q2xSY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+UBu8Zv2pDV9c4FhrlcVm6HtsuSWqNMaZRYDHPvqc4nthikkP iLaM6D+AkR6SCoOpK15ymlMY+GR65GkSb798O2jnxIs66aV0r0jRDsmF/AcS4uvIsDj2qlYues7 eHKwKlqF5jWxv/NK+hDsA74E2WwSwOItxpn0hbfqE5q47VVA0v1pj6O9uQaDJIz4QYw== X-Gm-Gg: ATEYQzwbA8QHESjf2FXkxemdRI1ePkGxeBp4NZKlKK66QTVDjVS4x6FuaIbjbY6ata0 cF3txRfIKaxa5OEuuPuK4PWfs+Jvdp6ofIfHeHkKojk69Tj3YmOdoj0+PdGD24OjkswhrhcKM5T b43idyHQUVdlSzSzGFuDIOlY6OgiA0Hh4YAcRyTefB3QboDc7IVTkNvZQRwnk7VehErix3rq56c NeTDUsKUvszPcBEz50cv1oHewxBF3QGu+4LhzaLlYvouYFQ5O3HsHhHSxWR5LvqjP9hvhTTfSZu ISah/OMoDBvi+NE8wItvl02iF+BggZbRfg+6KYNBlVwFuCdNGEkbGdvH26bQpND3PmaitMiEk4m gtKaHEpWmR3bCwIV07ECH6CTS98SD5unyDSs0ecKWGEQ7xdAuixYCVDNjEA== X-Received: by 2002:a05:600c:c0d5:b0:46e:4e6d:79f4 with SMTP id 5b1f17b1804b1-48883597d5cmr86145695e9.15.1775120724274; Thu, 02 Apr 2026 02:05:24 -0700 (PDT) X-Received: by 2002:a05:600c:c0d5:b0:46e:4e6d:79f4 with SMTP id 5b1f17b1804b1-48883597d5cmr86145105e9.15.1775120723689; Thu, 02 Apr 2026 02:05:23 -0700 (PDT) Received: from [192.168.88.32] ([212.105.153.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48885553118sm39116485e9.14.2026.04.02.02.05.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 02:05:23 -0700 (PDT) Message-ID: <0f9e9d4e-8083-4297-91d3-10d0f614c87c@redhat.com> Date: Thu, 2 Apr 2026 11:05:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] net: caif: fix stack out-of-bounds write in cfctrl_link_setup() To: Kangzheng Gu , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, kees@kernel.org, thorsten.blum@linux.dev, arnd@arndb.de, sjur.brandeland@stericsson.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260329190350.19065-1-xiaoguai0992@gmail.com> <20260330065342.145549-1-xiaoguai0992@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260330065342.145549-1-xiaoguai0992@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/30/26 8:53 AM, Kangzheng Gu wrote: > diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c > index c6cc2bfed65d..373ab1dc67a7 100644 > --- a/net/caif/cfctrl.c > +++ b/net/caif/cfctrl.c > @@ -416,8 +416,16 @@ static int cfctrl_link_setup(struct cfctrl *cfctrl, struct cfpkt *pkt, u8 cmdrsp > cp = (u8 *) linkparam.u.rfm.volume; > for (tmp = cfpkt_extr_head_u8(pkt); > cfpkt_more(pkt) && tmp != '\0'; > - tmp = cfpkt_extr_head_u8(pkt)) > + tmp = cfpkt_extr_head_u8(pkt)) { > + if (cp >= (u8 *)linkparam.u.rfm.volume + > + sizeof(linkparam.u.rfm.volume) - 1) { > + pr_warn("Request reject, volume name length exceeds %zu\n", > + sizeof(linkparam.u.rfm.volume)); It looks like this printk is remotely triggerable from each incoming (malformed) packet. It should be rate-limited. Thanks, Paolo