mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Karol Przybylski <karprzy7@gmail.com>
Cc: skhan@linuxfoundation.org, jbrunet@baylibre.com,
	jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: tps25990: Fix unreachable code in tps25990_read_word_data
Date: Thu, 5 Dec 2024 16:15:49 -0800	[thread overview]
Message-ID: <0fa164c7-5562-40bf-b2d9-92ed1efaff8a@roeck-us.net> (raw)
In-Reply-To: <20241205213315.3073207-1-karprzy7@gmail.com>

On Thu, Dec 05, 2024 at 10:33:15PM +0100, Karol Przybylski wrote:
> The tps25990_read_word_data function contains a block of unreachable code caused by the syntactic structure in the PMBUS_VIRT_READ_IIN_MAX case.
> 
> Specifically, the return TPS25990_READ_IIN_PEAK; statement immediately exits the function, making the next lines unreachable.
> 
> This patch removes the return statement, leaving the expected handling.
> 
> Discovered in coverity: CID 1602227
> 
> Signed-off-by: Karol Przybylski <karprzy7@gmail.com>

Thanks a log for the patch. I squashed it into the patch introducing the
problem. Please note that the above commit message is missing line breaks.

Thanks,
Guenter

      reply	other threads:[~2024-12-06  0:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 21:33 Karol Przybylski
2024-12-06  0:15 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fa164c7-5562-40bf-b2d9-92ed1efaff8a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jbrunet@baylibre.com \
    --cc=jdelvare@suse.com \
    --cc=karprzy7@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®