From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932134AbdECUha (ORCPT ); Wed, 3 May 2017 16:37:30 -0400 Received: from mout.web.de ([212.227.15.3]:64607 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754030AbdECUhW (ORCPT ); Wed, 3 May 2017 16:37:22 -0400 Subject: [PATCH 1/6] lockdep: Replace 11 seq_puts() calls by seq_putc() From: SF Markus Elfring To: Ingo Molnar , Peter Zijlstra Cc: LKML , kernel-janitors@vger.kernel.org References: <3f95acb5-c037-b6fa-7a9b-258b4ae465fb@users.sourceforge.net> Message-ID: <0fae17e0-1880-e041-293e-8ab3184df6a7@users.sourceforge.net> Date: Wed, 3 May 2017 22:36:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <3f95acb5-c037-b6fa-7a9b-258b4ae465fb@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tIq2m73+PUp2OSFKvcFTzuXENu5XgeXF0vXH6x5o2cbXmNNPtKh F93PN/HmnTVPPq45Xkm08bmLW3VaYJ+W1BJpr+C4sdHCbSXuHetzZWALENNZ9cU79jIPAXS 7o8JKpVPt/8/bT/CKw6njY8UIhXohhRbaa6fvWcAJj3Fi8cP9Q16yqQS210ZgRfxNrvBnlT Uyk7LXhH5mJS2bNCd7z5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vge4ek3mcBM=:HVn4pXemwzMt+63SG+LAHF sczAmS1hKMbY22p/0QAeTuutJsqOZj8QKvXYlPmS08ZmXDt/BvKGiimyJaIvpuoTuPk5VcB/9 IfBKtxOBKDGDmbCw1mNteL9IwFkeXKhVyTm/V0stBbQbdB9HdNL3j2sWfc/DJXnzgbO7pM+7d VaZxhQTzE3j7WvtiWoTUn+GKfVHGCA8qcVYPx4dlHZL0+6aFR8CjLvFL9QfC91Cq50V26Y7pz bBrzQw99fud/42wwEDattBOPM1MbVIRnCutOUM8GXcK5SXB+NleJVEWlWFcW70DOx7uA0+BgT KVaJ9VyXPYVD1qGLfvJbz8O1qW0mqO9/Wx4b5RUqmfhu3mJpOG46wrCHr8e1UKotZvEsj6rPb ji936LDHzH8A7cLbOzhNyKmUmR6iMpsZP6BHlog4151lphupxXix3UBhFvH9G7t7vUEhhcSzQ msxsnQIYU/eLN+BbMT0dAZLwd1vO5Tvy8QbaBwxexCoIbn7SQCPgUN6vizWlK3PfEmafxK+ZS 34Sdt5PofdboWvYIkyNnKyU0IFsMKu4GLe3ryj6ZKiiPtfXD+JgwqI/sSzAj+Z4UQwKM+T1h1 Gi6n7zNWvFfj5sfc4YHQQsWbU6AYjO3Rc6+9UumozF/JXCblMTgQ3O4e8QDRwfBuvFbhwcoqM DxiJAGy1EOU/XC/YpfXJK28DwfmvfgQP9jpX7CMOyaG9yO1A8UQSQwZw7qz5eDfvTpLO0k3Nw Oi0pV9AKBGjtu8YjrfIZGrcybctozqiRZgB1hp8Bc5GNvJR+o8eF+gqgsOYpJ1rfnZN2Em0h3 3VUkkxA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 3 May 2017 21:00:26 +0200 Some single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/locking/lockdep_proc.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c index 6d1fcc786081..825496ece766 100644 --- a/kernel/locking/lockdep_proc.c +++ b/kernel/locking/lockdep_proc.c @@ -81,15 +81,14 @@ static int l_show(struct seq_file *m, void *v) print_name(m, class); - seq_puts(m, "\n"); + seq_putc(m, '\n'); list_for_each_entry(entry, &class->locks_after, entry) { if (entry->distance == 1) { seq_printf(m, " -> [%p] ", entry->class->key); print_name(m, entry->class); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } } - seq_puts(m, "\n"); - + seq_putc(m, '\n'); return 0; } @@ -156,10 +155,9 @@ static int lc_show(struct seq_file *m, void *v) seq_printf(m, "[%p] ", class->key); print_name(m, class); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } - seq_puts(m, "\n"); - + seq_putc(m, '\n'); return 0; } @@ -393,10 +391,10 @@ static void seq_line(struct seq_file *m, char c, int offset, int length) int i; for (i = 0; i < offset; i++) - seq_puts(m, " "); + seq_putc(m, ' '); for (i = 0; i < length; i++) seq_printf(m, "%c", c); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } static void snprint_time(char *buf, size_t bufsiz, s64 nr) @@ -483,7 +481,7 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data) seq_lock_time(m, &stats->write_waittime); seq_printf(m, " %14lu ", stats->bounces[bounce_acquired_write]); seq_lock_time(m, &stats->write_holdtime); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } if (stats->read_holdtime.nr) { @@ -492,7 +490,7 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data) seq_lock_time(m, &stats->read_waittime); seq_printf(m, " %14lu ", stats->bounces[bounce_acquired_read]); seq_lock_time(m, &stats->read_holdtime); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } if (stats->read_waittime.nr + stats->write_waittime.nr == 0) @@ -532,9 +530,9 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data) ip, (void *)class->contending_point[i]); } if (i) { - seq_puts(m, "\n"); + seq_putc(m, '\n'); seq_line(m, '.', 0, 40 + 1 + 12 * (14 + 1)); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } } -- 2.12.2