From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Biao Huang <biao.huang@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
macpaul.lin@mediatek.com
Subject: Re: [PATCH v3] arm64: dts: mt8195: Add Ethernet controller
Date: Thu, 20 Oct 2022 10:09:42 +0200 [thread overview]
Message-ID: <0fb91a39-e356-4785-3ab1-11cbc3e78877@collabora.com> (raw)
In-Reply-To: <20221020024155.24520-2-biao.huang@mediatek.com>
Il 20/10/22 04:41, Biao Huang ha scritto:
> Add Ethernet controller node for mt8195.
>
> Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 88 ++++++++++++++++++++
> 2 files changed, 176 insertions(+)
>
..snip..
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 905d1a90b406..7efaf92c5ff3 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1042,6 +1042,94 @@ spis1: spi@1101e000 {
> status = "disabled";
> };
>
> + eth: ethernet@11021000 {
> + compatible = "mediatek,mt8195-gmac", "snps,dwmac-5.10a";
..snip..
> + #address-cells = <0>;
> + #size-cells = <0>;
I'm truly sorry for a partial bad suggestion, you don't need to specify address nor
size cells = <0>; in the ethernet node, or you get a warning:
arch/arm64/boot/dts/mediatek/mt8195.dtsi:1174.26-1260.5: Warning
(avoid_unnecessary_addr_size): /soc/ethernet@11021000: unnecessary
#address-cells/#size-cells without "ranges" or child "reg" property
So please remove these two.
After which...
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-10-20 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 2:41 [PATCH v3 0/1] " Biao Huang
2022-10-20 2:41 ` [PATCH v3] " Biao Huang
2022-10-20 8:09 ` AngeloGioacchino Del Regno [this message]
2022-10-20 8:49 ` Biao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb91a39-e356-4785-3ab1-11cbc3e78877@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®