From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755666AbdEMQdr (ORCPT ); Sat, 13 May 2017 12:33:47 -0400 Received: from mout.web.de ([212.227.15.14]:52279 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbdEMQdq (ORCPT ); Sat, 13 May 2017 12:33:46 -0400 Subject: [PATCH 1/2] oprofile_perf: Improve a size determination in oprofile_perf_init() From: SF Markus Elfring To: oprofile-list@lists.sf.net, Robert Richter Cc: LKML , kernel-janitors@vger.kernel.org References: <8e408a15-7884-e9a1-0df2-a7419987c450@users.sourceforge.net> Message-ID: <0fc2061c-a358-b158-898f-5aa6325cfe02@users.sourceforge.net> Date: Sat, 13 May 2017 18:33:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <8e408a15-7884-e9a1-0df2-a7419987c450@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:EWgXeyr4AeH1PQ+99jxCp9stnnl4UlVaTS0MA4YeMZ7GAviI2Zy E2UOUqrKAVL+EeDgA//beMe9RvilTwRcz1zUBAQgYnnpfNiiSId7m8XMdEuB1jNS4fnkCve GXdP+L90hJHnN3vlcj5URjb4cltRGXtkNdkuoiR7m0xx+GaaKOXFrIrCaNctoDbTS2SUwqg fnCrVloEC541gGAAnE3aw== X-UI-Out-Filterresults: notjunk:1;V01:K0:smPDJT9vRbI=:QpcO1kFljz8V2iq+xKkeuk oboE8ZgiV9qieEWmxMqdrnHGAgFqIYlaZFTA/LOiBKtasYkAUfHQVLj9qizPeIipdLPq7ww8g 3BQyOfhZ/YM/KvhK4mOtZ/fHr2nxmwGEmmU9DKP39YYX+jTVEu5kAOVNjMvVPWJsUSLtZnSYI NcQCvJw267g7Gako9vl/J4HDVXTeo7wGW7OJOpaQuKinIkHtc/gFx+Z3dmb5J0p2+YXkoKXpm fhaDVTlr+gEJ8N4NSwSjZMjo3k3SbR4ZZQrhMaLhjt4mTlzymJ6sO0reMrj1alXHgg4Pj5TwS xtbqIGAY7bygnz1DUnnZeW+KleCHr5wBvwU0MumvWNAa0RIR/hQsu9yqlm8EC2njKUvmXOkfi 4ET66KwQqIxUvmjB7erbPlFmr0p/YXzPey5gYiuMmUpZpGwaGus5A7bgYI5FjUXCc6f611cHu fuPKwS5TMY20t98s9V7MGno8qHQMfpBxad0uEU+Cn2jxdW74O5fGpPXgxBKNMjBeaApsdWpzg t/imx/uU2Z1YZ/aI2v5yl+igsQtEM0Gmb8QZB1apOnNhu82EaQJntUYllNwLI60Z6nCpYgfHA ZslfXc4Q1wErBHk2boFjkwB9ErNsRal3UqWOk1a6Y0L9DJrnLKQZyNek8fQ3xB/IIlFb3BxXB u62/PJAFoiY/2IgIdNgIU7Hfl4b88gCb1VsHguEDgS9jnWO7YJ4fiPZjRMW0+L3Hi+HjFbCFg IEBMZCxNjUuP4YDPRmHx8swuKCCc4Wk4Ph1nbp1tO8HkSUGKFlcV8Dws+nAPpTVA5pV7aWZrF GY0y5pB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 13 May 2017 18:00:13 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/oprofile/oprofile_perf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/oprofile/oprofile_perf.c b/drivers/oprofile/oprofile_perf.c index d5b2732b1b81..033f2c26f2ad 100644 --- a/drivers/oprofile/oprofile_perf.c +++ b/drivers/oprofile/oprofile_perf.c @@ -285,7 +285,6 @@ int __init oprofile_perf_init(struct oprofile_operations *ops) goto out; } - counter_config = kcalloc(num_counters, - sizeof(struct op_counter_config), GFP_KERNEL); - + counter_config = kcalloc(num_counters, sizeof(*counter_config), + GFP_KERNEL); if (!counter_config) { -- 2.12.3