From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCF8D3AFB09 for ; Wed, 10 Jun 2026 08:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781081873; cv=none; b=bZk0a+E6dLiTvLr5SQl1sroO9IhXusPAcmgQSnFioLVVISJtCN3g6/sFqtWxq4UUo7VuWkbnItXP99poFyssPSeKaAkUOKXGIdzPMUSTmBiiJIg+UIijsHi3xeviI7VD5573p9R+HcEnuNjRur2K+xcgqBxeNDSM3a9L9ci2rck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781081873; c=relaxed/simple; bh=P1tuX+TCQiojtRE1Vy3rLWC5CCz0sd5BKC2Ld8Q2CUM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hx5Z4HTUXDW9rhxk+u3bHWGVwH3jLeWg2wy8ILnUKB6QigDj/P18FtJbL4BBNUNXa8b2ku/y4PzQ7ad2JT6nehqjwCh4Of9B9PrKSkU3EvQ/1PD9Opz/Vt2ralRvrWJ4NGUoXGWI3gyg8xpvwPeR2zon8h007LBFBPC9f88U3/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GDET/AbE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KxxJwztx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GDET/AbE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KxxJwztx" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A7hxd1990993 for ; Wed, 10 Jun 2026 08:57:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x9mL1Zr611lQe1BlZ6Wwrsk25RwLSKrOaDlttTZhghQ=; b=GDET/AbEBmlVaK9q 311uxnF+IKgzA8I2bOtPnFCHV30+ONJJoKJSgYQsKVP/VqcnDOkkzYf3k51ge1Z+ urFWZx2b0MOSxvF7J4oUNaSorm5Aan34FQglCPEViZ5wspLJkjVxFiOJCjR/bLQn Pp73bOOFJ4izILo57p7qTIhaZx1eEFblXdWE/DQo4bNByXb+sA9b/nrrWm17nCnA I/6ekHMHfhT4CG/DzIU1+Y4VxaVUWQPQIOvlhifPw4LVQj7fmyyLZwAG0zJV1r/O cwlDRtWb2uYrMfM40wfwAH2VHlSOi3P9YkG4Km8esSnXNjVTHkTYHIB2TG8a4Jnp o2qzig== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq1tg0rtu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 08:57:50 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36bcfce8a33so5839984a91.1 for ; Wed, 10 Jun 2026 01:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781081869; x=1781686669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x9mL1Zr611lQe1BlZ6Wwrsk25RwLSKrOaDlttTZhghQ=; b=KxxJwztxdMmixEcasNGNaVOurzuGa/Ml6rZwy90pkK8aeXn6n1myd8N9MFvjGXDQic 52d63FJRjrU5/dHWGoTByBdrLgFbLDmCUTDiYrrFJxPYtfKA+djOFVdBv23q0btfxzb3 IuJwtegwcFp9RlYGaqBCX3+GswOrNnSj5zTEutFUe/JF9wUhHMhdWFoWMRAie/lRw8jA VB0JXzEr9CixcNe/8NGfEzrLXR2xkTuVEkSmx37OL4PIvayaFi1cj5FjLBfXdBXJTqCA FGa8ZQ64tj/U3dSSNj9VHjbsOYEPj45+GKFhL/MpiEH1ESyMBrVzYgpJCH51pJP58aeq J6KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781081869; x=1781686669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x9mL1Zr611lQe1BlZ6Wwrsk25RwLSKrOaDlttTZhghQ=; b=Ll26DPHmoRyGdH+pORGK11HKOX6TDIjnilB6Q4DTrW9ikfBJ71LB7FqrwSaYMy21aa jvAYzghOAZaDvaLEbb6gVA23Wy//ZFyPHQl1eiN9xryzvtxmfKN1bmaFFHGbN6iTUUMA 5jB1Bm+B1jx3NaG6LwAoyHDBxrRk04XcPLyZKeJf4HCHq/kUFyuiTr3ahuTzR/jUlm6K vaqqOXVH2+cnbV8qVmbq5ftJaJYfCDLBXxDpQ/Tq2Pp4pdB422iCA91IdwUNoEibq217 FllBDMK1z5o6osXFxFW56NhMAvUv6r4+PeD+5XhLkG5yF/KE1lqNJpH2nZydFXs0E8pI JsAQ== X-Forwarded-Encrypted: i=1; AFNElJ+W4oBaVsUoI3ymnwVq5Atxfkr9IyVp2w3qA9wOxyEDHOWpPOLiWqr+iRNk0SUDFQU8ea+bGFjynJ3ANQ4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3r+vIHQxGvf66OlaWd0WUM5oymBnv1uVfFSSE7EM3unSga9/r E6DHjCRH0uwjo9y9CDKBli/C3m9RB4NVjCNil+FdhHAvQmEhY7pARZqxpzwgcqOjkqxpzmW/cp8 QFxodyIoZGBYVFCEiUMsVSRnQdDnMvRtT9/VJg4d3Oopk0KYcQMz9uBdtC2nBVtjJWmQ= X-Gm-Gg: Acq92OEN26ic51Kw8TiQiI3/FOtqZd5X3NKJ18a075IFDv+wd1y0k37f5PD+1grP6p8 wa9gFGIMjENyvYeXwZxAbKel3MqjnyvF7j4ttVCY/8FLy5CpnL16+yNHPIvKT6ARShP5PbYH8os k491FTAPbbnko3XCEW9BXwmJLH/DHqctGjyROt/Ji9rihMysCdQSAfTfxyMmCe4MK8F+K7RKSR5 +xv6dKg00HChAGKyxQza4jPKPdotcKk8FO3eNjX++MXSKgX8uGV1OuOlwEYQmS88Gc9SdNfiNKz giIsejfYQoeBn9smkxQP4JlZsU9j8v0I8vqd1Y+onQ3u9RRik6Qb6l/Ss7WewIHM8e7aV9UK9v5 +QFclKAukP2niJVV6qlAvgr9tN4lVb5D7zXueLsHR/l/yJcSwZwJC71EjU/re X-Received: by 2002:a17:903:4b2d:b0:2c1:e9f8:7587 with SMTP id d9443c01a7336-2c1ec92d8aamr208414925ad.29.1781081869461; Wed, 10 Jun 2026 01:57:49 -0700 (PDT) X-Received: by 2002:a17:903:4b2d:b0:2c1:e9f8:7587 with SMTP id d9443c01a7336-2c1ec92d8aamr208414765ad.29.1781081868993; Wed, 10 Jun 2026 01:57:48 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f85de1sm239180905ad.20.2026.06.10.01.57.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:57:48 -0700 (PDT) Message-ID: <0fc4d9d4-2943-4ed8-a8ea-014e83c74e5c@oss.qualcomm.com> Date: Wed, 10 Jun 2026 14:27:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper To: Krzysztof Kozlowski , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610080809.2588640-1-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: FRj7B4ebyuaEVxxSDSaZ8MntbXeFz4Tj X-Authority-Analysis: v=2.4 cv=dLmWXuZb c=1 sm=1 tr=0 ts=6a29270e cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=u__0wiaksbrxrX_IWOoA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA4MyBTYWx0ZWRfX1K4WuLb3HeO3 eaPKBWnGnvZySD5kn+iJHz+kCLtk1x20/Ta6leA71ojBPciB5VOBpVt1w3sXOe7jhEltLkTCsYy 05zP2cVZxIAEUfR4+boylwsuxAlD15cm0d0nZjX6R3ie3Gr7jSgfZzQ9SyUJDnt288IrSL1wcAE ZxGHtvx7wTYloCQPRwgSIi6UADmHWdtUBSd9OUP9KaXYXYOW8vv07eWFQnsFqyfLpoTyAx/PmzC BltHuhG7C2KOuC6dhqmmHyKG35u1parp7ATwPzVFS80RlfFHngOAFl31HpPLUZAOrzC5WDp6ID7 K8rlJ830TMYTCvLzdBd5DEnJdmLTPkQ3ZexUOIWPZ1sXX+QfwiOa93la2ncaguCUC3sobgLdlNx vzgz7KlmZYprU7VqifytcdAUh7avzN3mJoas7t8SfE0F7WEo9OQu3+IC+4DZxoprcGPKen18eax vr5FHrHU4JctFW3Idgg== X-Proofpoint-ORIG-GUID: FRj7B4ebyuaEVxxSDSaZ8MntbXeFz4Tj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100083 On 6/10/2026 1:55 PM, Krzysztof Kozlowski wrote: > On 10/06/2026 10:08, Ajay Kumar Nandam wrote: >> lpi_gpio_write() became unused after the PM clock runtime conversion >> switched write paths to __lpi_gpio_write() inside callers that already >> hold an active runtime-PM reference. >> >> With -Werror this triggers: >> error: 'lpi_gpio_write' defined but not used [-Wunused-function] >> >> Remove the dead wrapper. >> >> Fixes: b719ede389d8 ("pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM") > > Please add Reported-by credits, at least Nathan as he bisected it. > > >> Signed-off-by: Ajay Kumar Nandam >> --- >> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> index 4d758fd117c4..fe7ec0176081 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> @@ -79,20 +79,6 @@ static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, >> return pm_runtime_put_autosuspend(state->dev); >> } >> >> -static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin, >> - unsigned int addr, unsigned int val) > > So why do we need __lpi_gpio_write()? Hi Krzysztof, Thanks, good point. I will respin with: Reported-by: Nathan Chancellor About __lpi_gpio_write(): it is still needed for the in-callers path where runtime PM is already held and we only need the raw MMIO helper. The unused wrapper is lpi_gpio_write(), so this fix removes only that dead function. Thanks, Ajay > > Best regards, > Krzysztof