mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Daeho Jeong <daeho43@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>, stable@kernel.org
Subject: Re: [PATCH] f2fs: fix error handling on device alias check in rename and unlink
Date: Fri, 21 Aug 2026 10:21:32 +0200	[thread overview]
Message-ID: <0fc4eebe-68a1-472f-9dee-fecd5dd85f06@wanadoo.fr> (raw)
In-Reply-To: <20260821011812.2938998-1-daeho43@gmail.com>

Le 21/08/2026 à 03:18, Daeho Jeong a écrit :
> From: Daeho Jeong <daehojeong@google.com>
> 
> In f2fs_rename() and f2fs_unlink(), directly returning -EPERM when
> encountering a device aliasing file bypasses the cleanup path.
> 
> Fix this by setting err to -EPERM and jumping to the proper cleanup
> labels (out_dir and out) instead of returning immediately.
> 
> Fixes: a737e409a3d6 ("f2fs: support dynamic reserve/release for device aliasing")
> Cc: stable@kernel.org
> Signed-off-by: Daeho Jeong <daehojeong@google.com>

Hi,
if possible, a

Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

would be appreciated.

CJ> ---
>   fs/f2fs/namei.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 784f636244e1..b9b15c5d28de 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -571,8 +571,10 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry)
>   
>   	trace_f2fs_unlink_enter(dir, dentry);
>   
> -	if (IS_DEVICE_ALIASING(inode))
> -		return -EPERM;
> +	if (IS_DEVICE_ALIASING(inode)) {
> +		err = -EPERM;
> +		goto out;
> +	}
>   
>   	if (unlikely(f2fs_cp_error(sbi))) {
>   		err = -EIO;
> @@ -1025,8 +1027,10 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
>   	}
>   
>   	if (new_inode) {
> -		if (IS_DEVICE_ALIASING(new_inode))
> -			return -EPERM;
> +		if (IS_DEVICE_ALIASING(new_inode)) {
> +			err = -EPERM;
> +			goto out_dir;
> +		}
>   
>   		err = -ENOTEMPTY;
>   		if (old_is_dir && !f2fs_empty_dir(new_inode))


  parent reply	other threads:[~2026-08-21  8:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  1:18 Daeho Jeong
2026-08-21  1:31 ` [f2fs-dev] " Chao Yu
2026-08-21  8:21 ` Christophe JAILLET [this message]
2026-08-21 14:17 Daeho Jeong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fc4eebe-68a1-472f-9dee-fecd5dd85f06@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=daeho43@gmail.com \
    --cc=daehojeong@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®