From: David Hildenbrand <david@redhat.com>
To: Hao Ge <gehao@kylinos.cn>,
akpm@linux-foundation.org, willy@infradead.org
Cc: gehao618@163.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V2] mm/page-flags: make __PageMovable return bool
Date: Thu, 4 Apr 2024 21:26:50 +0200 [thread overview]
Message-ID: <0fc5f2ea-af19-4ac6-a32a-efd607800b0a@redhat.com> (raw)
In-Reply-To: <20240321032256.82063-1-gehao@kylinos.cn>
On 21.03.24 04:22, Hao Ge wrote:
> make __PageMovable return bool like __folio_test_movable
>
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
>
> ---
> v2: Send this patch on the latest version
> ---
> include/linux/page-flags.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 5ee2d0ab62c6..2647c7a35c5a 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -689,7 +689,7 @@ static __always_inline bool __folio_test_movable(const struct folio *folio)
> PAGE_MAPPING_MOVABLE;
> }
>
> -static __always_inline int __PageMovable(const struct page *page)
> +static __always_inline bool __PageMovable(const struct page *page)
> {
> return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) ==
> PAGE_MAPPING_MOVABLE;
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-04-04 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 13:28 [PATCH] " Hao Ge
2024-03-21 3:22 ` [PATCH V2] " Hao Ge
2024-04-04 19:26 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc5f2ea-af19-4ac6-a32a-efd607800b0a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gehao618@163.com \
--cc=gehao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®