From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752001AbcHFVhs (ORCPT <rfc822;w@1wt.eu>);
	Sat, 6 Aug 2016 17:37:48 -0400
Received: from mout.web.de ([212.227.17.11]:60296 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751050AbcHFVhr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 6 Aug 2016 17:37:47 -0400
Subject: Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR
 test for devm_ioremap_resource
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
References: <20160806051548.GA30731@amitoj-Inspiron-3542>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: LKML <linux-kernel@vger.kernel.org>, Coccinelle <cocci@systeme.lip6.fr>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Julia Lawall <julia.lawall@lip6.fr>, Michal Marek <mmarek@suse.com>,
        Nicolas Palix <nicolas.palix@imag.fr>
Message-ID: <0fc7f1af-b66d-3089-8c15-6cdc570ac159@users.sourceforge.net>
Date: Sat, 6 Aug 2016 08:30:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <20160806051548.GA30731@amitoj-Inspiron-3542>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:bf4JcyfHO8azu59rqUOxgvm2syr8v/ULfbUCIi20Se0rrKslE30
 tvGJO4+9SGFIgoW1CHWq/FgeLGroUF455IB8etY+Vvv+K9I/hrhtMXyC2Ht1iMokaW3CFKq
 Fkk+3OjSARN8kRwPDaqOFozoLbbBIfMjzj0d4ZmZFSMsgXsDP3PMf6/ofRcAkB4yRDB8Mzl
 VDZ312VSA38AHEpCJgmNQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:75LGybZOj48=:92xMTaUfGqUE2B+LF40H2/
 1eZXUwc3/ZqkvNfnZnynQgwV64ZIp5z0dwbbKn6PeYXMublZ1FSO1r1YgRFV+GFnpd+V5gwt8
 l5odq/xAYduWZx4WTBH/Uv0ERGWOUn0iEf4426PgwlITKH+5o692yKtrSrx3NNSPmLshmcElx
 JjnvFjT4aOUU2WNCn2HnctVfjvGoNX9/HdeEbayprPAAAaCHHwnKRi+bHxWYtoi1LW8oDxO9d
 0FWoh0wmB+qAKYyDIkqBRTK1rT6S5afTwpRTFd1n0V2XQdmqa4miMDnwJZmm/76mjgpWWfHBX
 sk7MhNeQx87lQXXd3C0L/rMlyKPL66ybozKLjn0+noieqRQ0oa7SlS9Wbf/9iVeuxlLmiPgbH
 bZDH07rEJx6cOeOtv0CFtBhBpYrujvt8Jb76qF/8Gs3S5gjlPSiGN25Ik3aodK8gfr5NPnVQh
 mIC7OWMvptGdNS2BfzFsupp2w7M0yjvmkB0amWRPDb3QY2D5kxcSDBhaCV927RQPp6jCIwXjD
 RmsJhO4keQHmtyFTq5n9sY2do7mKHJQ/pIHQnsEwcFefZj01hMZomp/pkUO/P0YEW4GvXqvLn
 oQBPk5bR4R/iyIfMEN998T0zS6hSNj1z9Pjd1Sfl0mlDqYf8wBtamy1pN09d3k8V6WvNei5JQ
 qTCqvYzR9qZW/tnVHn1cfb4HDk2zWRk9as+5uHtu5qBCqFAEQZwL8A9CukVba4BRuIvKiEV9Y
 xmH06OavKmooE7GZzayIGNHZKOjHVuwyDW09SNppX16ZvHZRHYrQDYhMTz2MsLwtuEBb68nfZ
 p/l4hqQ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +@err depends on context || org || report@
> +statement S;
> +expression e;
> +position j0;

How do you think about to omit the number from this variable name?


> +@@
> +
> +  e = devm_ioremap_resource(...);
> +* if (!e@j0) S

Are there any more functions to consider for such a source code search pattern?
How do you think about to use a function name list here?


> +// ----------------------------------------------------------------------------

I suggest to omit such comment lines from this SmPL script.

Regards,
Markus