From: Vlastimil Babka <vbabka@suse.cz>
To: "Christoph Lameter (Ampere)" <cl@gentwo.org>,
Pedro Falcato <pedro.falcato@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mateusz Guzik <mjguzik@gmail.com>
Subject: Re: [PATCH v2] slab: Warn on duplicate cache names when DEBUG_VM=y
Date: Thu, 8 Aug 2024 10:28:30 +0200 [thread overview]
Message-ID: <0fc80187-a6a1-424f-b36e-8a67889cbd0a@suse.cz> (raw)
In-Reply-To: <ad85f6ee-28a9-b558-2219-5a6e49e17b75@gentwo.org>
On 8/7/24 19:32, Christoph Lameter (Ampere) wrote:
> On Wed, 7 Aug 2024, Pedro Falcato wrote:
>
>> Duplicate slab cache names can create havoc for userspace tooling that
>> expects slab cache names to be unique. This is a reasonable expectation.
>
> Yes that is reasonable. This is done during slab creation and so is not a
> performance sensitive operation. The sanity check could be done even
> without CONFIG_DEBUG_VM
We can perhaps move it outside CONFIG_DEBUG_VM in few cycles.
> Acked-by: Christoph Lameter <cl@linux.com>
Added to slab/for-next, thanks!
next prev parent reply other threads:[~2024-08-08 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 9:07 Pedro Falcato
2024-08-07 10:34 ` Vlastimil Babka
2024-08-07 17:32 ` Christoph Lameter (Ampere)
2024-08-08 8:28 ` Vlastimil Babka [this message]
2024-08-11 20:30 ` David Rientjes
2024-08-11 22:28 ` Pedro Falcato
2024-08-12 0:55 ` David Rientjes
2024-08-16 12:17 ` Pedro Falcato
2024-08-26 19:23 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc80187-a6a1-424f-b36e-8a67889cbd0a@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=pedro.falcato@gmail.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®