From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47BC933062 for ; Fri, 17 Jan 2025 15:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737129291; cv=none; b=gl2UJZ9faADsBU8VQ4bk0znS/+58+uBuwnYHeKZvznVnbyAA9duR8xEtN6ZWUTu/hox/iFWbsgTz4v1AntH+dDcedCqMY6HoF3H4t5uQQHpb6Ygbpuo3rKXDW8nkTZdbTYnPg/1C8BNOwG759VHSqL6mKoh1rK3OX3QbmpWGL+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737129291; c=relaxed/simple; bh=G+eqXajtcoLTMj3bUIQxF+d7Lp0tM0NmbV0PUyOSO3U=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:References: From:In-Reply-To; b=ngoCZQsl/rQTTwH1odEJcDCLatrDFeZKo29op7RHWXk/Rj+K6ujipCoAvFtRuFRlgyLPeOgXkKVRdyyKg8Tn6uiRVtISAXpcCbBil9UVwQRaJ8nwQwLICSUTODcluFpnd1FWR4aiSeahFs0O258YYA/a0Ec0pTe54AZqF6H2bCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Dl2JRnqS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dl2JRnqS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737129287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8xEOdumKlte1BrryYyr+zYO6TzhDDk4EOI6NsZlx+1k=; b=Dl2JRnqSz3gkKlgVzHtD2FNW1ng33mouUAfZy+HMFhLj0jXandz98eSVIZucBYDYZYwywD mxBZHq+nPwAGyqKEZbfdKk/0q4Aovrfr+xVkyIAgEBuNk2zbeLqTpA+2Z6ixjvvXpF4jws AHWVDy8aSMarViDFaKsyWydPttiFV50= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-QrSbm70MPGaXmILr324msQ-1; Fri, 17 Jan 2025 10:54:37 -0500 X-MC-Unique: QrSbm70MPGaXmILr324msQ-1 X-Mimecast-MFC-AGG-ID: QrSbm70MPGaXmILr324msQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4362f893bfaso11628015e9.1 for ; Fri, 17 Jan 2025 07:54:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737129276; x=1737734076; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8xEOdumKlte1BrryYyr+zYO6TzhDDk4EOI6NsZlx+1k=; b=iMbs3nn2SNETse+XjCcAESYL/IZUoR2vZmJLWa8OfvLSBE9n6IrlaIIzp16TmBOQ0I zlkeaQGw3LWa6ivQdfKMeDvoVTqfTm3GZBpHQcatRp5npRyWJoDRQ+zpl0RftOJlv1Jd MRiljTLnK9jcM4xNom3dyPt+tt5lYPkpOQ4n65G/MfMFarltXSTzHk0cn5iU2pNlRNYS YZAQ9q07HqK83CqmMuaBxiFn+ZBGKn7dn04ouvK9zSMuKzkw7mQECvgHkreAEhsK1WzC bahLo8aZrh9tVulKp3Rpxtjk3oo6EFk/s1E0vbdBIsca7F6l4gReki3evmJ2fLdG732m hAUw== X-Forwarded-Encrypted: i=1; AJvYcCUyuUy6djfswJgph8va8wzYewpVHL7WAgyNM0AiKi4H26N/iUS8jGWW8QTq65MGH/JTDM3qSr+S+/t5pmo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9msKn2CLTh7SwGmC14lGt7L3e8n4/+iVZc37tY6z9pJ4Up3ez 0F39kbRGPLtK/teUtaEUG6mUmJEYAa1g0X9grn+ICrZ807J7MUt3IFMbDexiY2PAqnH8bdNWOiC bE5wCKM/25RaZ1LyjvAUKr0JXp5nFfVGdJ/3X00gLoqIsmDFI/wsLrXdgzxEsCw== X-Gm-Gg: ASbGncuKhL0JZbKXvosVEuCMUd2VhUSQQPyYUSKFhwna+kayyb6XTe84F3zD5M/JEeN w/+VcDQZL/loVY5sAo47+mm9wWc4UP0WsKFS7W0GEuFrszT3rhsQiNkjj3tN81lPGQK0pJ1XSQF BClW0LWVFp18yiJsumSmeNJi+XIqYa8HbFPktnjW/CX0txhnJPI/2QB+aChoydCPBzhlJ29lYA4 SOJAUXkpTp2CPnjjbz7N6zZcMd258uTVM0tgMciYj6uBJYr1/1kgDTg8ogT+J6wBIPAxhHgVlJq c+yX/UwWyqg= X-Received: by 2002:a05:600c:1d1d:b0:434:faa9:5266 with SMTP id 5b1f17b1804b1-438913e79e2mr32304535e9.13.1737129276050; Fri, 17 Jan 2025 07:54:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsTg2raWhjyEo5lKjWgBmLN/ToD8g9/G+vx9LF2oshOtykfFxQS9zN4r4klibJsr1IWmBXzQ== X-Received: by 2002:a05:600c:1d1d:b0:434:faa9:5266 with SMTP id 5b1f17b1804b1-438913e79e2mr32304335e9.13.1737129275709; Fri, 17 Jan 2025 07:54:35 -0800 (PST) Received: from [192.168.88.253] (146-241-15-169.dyn.eolo.it. [146.241.15.169]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3215482sm2816198f8f.5.2025.01.17.07.54.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 07:54:35 -0800 (PST) Content-Type: multipart/mixed; boundary="------------QMuwEC0rishas579NE0afvxl" Message-ID: <0fcb7d4a-bdda-44f9-8f86-3e7669b65bb1@redhat.com> Date: Fri, 17 Jan 2025 16:54:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mptcp?] WARNING in __mptcp_clean_una (2) To: syzbot , linux-kernel@vger.kernel.org, mptcp@lists.linux.dev, syzkaller-bugs@googlegroups.com References: <6789b25e.050a0220.20d369.004d.GAE@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <6789b25e.050a0220.20d369.004d.GAE@google.com> This is a multi-part message in MIME format. --------------QMuwEC0rishas579NE0afvxl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/17/25 2:29 AM, syzbot wrote: > syzbot has tested the proposed patch but the reproducer is still triggering an issue: > WARNING in __mptcp_clean_una > > MPTCP: snd_una 52e55b5d657ac4e2 snd_nxt 52e55b5d657ac4e2 write_seq 52e55b5d657ac4e2 idsn 52e55b5d657ac4e1 dfrag seq 3d10b145d4f45513 len 32728 It looks like we are not catching a disconnect(). Add the missing accounting and more debug, in case the problem is elsewhere. /P --------------QMuwEC0rishas579NE0afvxl Content-Type: text/x-patch; charset=UTF-8; name="mptcp_clean_una_splat_debug_disc.patch" Content-Disposition: attachment; filename="mptcp_clean_una_splat_debug_disc.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL25ldC9tcHRjcC9wcm90b2NvbC5jIGIvbmV0L21wdGNwL3Byb3RvY29s LmMKaW5kZXggMWIyZTdjYmI1NzdmLi5mYzhkOWZjMzY5NDIgMTAwNjQ0Ci0tLSBhL25ldC9t cHRjcC9wcm90b2NvbC5jCisrKyBiL25ldC9tcHRjcC9wcm90b2NvbC5jCkBAIC0xMDIyLDgg KzEwMjIsMTggQEAgc3RhdGljIHZvaWQgX19tcHRjcF9jbGVhbl91bmEoc3RydWN0IHNvY2sg KnNrKQogCiAJCWlmICh1bmxpa2VseShkZnJhZyA9PSBtc2stPmZpcnN0X3BlbmRpbmcpKSB7 CiAJCQkvKiBpbiByZWNvdmVyeSBtb2RlIGNhbiBzZWUgYWNrIGFmdGVyIHRoZSBjdXJyZW50 IHNuZCBoZWFkICovCi0JCQlpZiAoV0FSTl9PTl9PTkNFKCFtc2stPnJlY292ZXJ5KSkKKwkJ CWlmICghbXNrLT5yZWNvdmVyeSkgeworCQkJCXByX2Vycigic25kX3VuYSAlbGx4IHNuZF9u eHQgJWxseCB3cml0ZV9zZXEgJWxseCAiCisJCQkJICAgICAgICJpZHNuICVsbHggZGZyYWcg c2VxICVsbHggbGVuICVkIGRpc2Nvbm5lY3RzICVkOiVkICIKKwkJCQkJInN0YXRlICVkICVk XG4iLAorCQkJCSAgICAgICBzbmRfdW5hLCBtc2stPnNuZF9ueHQsIG1zay0+d3JpdGVfc2Vx LAorCQkJCSAgICAgICBtcHRjcF9zdWJmbG93X2N0eChtc2stPmZpcnN0KS0+aWRzbiwKKwkJ CQkgICAgICAgZGZyYWctPmRhdGFfc2VxLCBkZnJhZy0+ZGF0YV9sZW4sCisJCQkJICAgICAg IHNrLT5za19kaXNjb25uZWN0cywgbXNrLT5kaXNjb25uZWN0cywKKwkJCQkgICAgICAgc2st PnNrX3N0YXRlLCBzay0+c2tfc29ja2V0ID8gc2stPnNrX3NvY2tldC0+c3RhdGU6IC0xKTsK KwkJCQlXQVJOX09OKDEpOwogCQkJCWJyZWFrOworCQkJfQogCiAJCQlXUklURV9PTkNFKG1z ay0+Zmlyc3RfcGVuZGluZywgbXB0Y3Bfc2VuZF9uZXh0KHNrKSk7CiAJCX0KQEAgLTE3Njcs OCArMTc3NywxMCBAQCBzdGF0aWMgaW50IG1wdGNwX3NlbmRtc2dfZmFzdG9wZW4oc3RydWN0 IHNvY2sgKnNrLCBzdHJ1Y3QgbXNnaGRyICptc2csCiAJCSAqIHNlZSBtcHRjcF9kaXNjb25u ZWN0KCkuCiAJCSAqIEF0dGVtcHQgaXQgYWdhaW4gb3V0c2lkZSB0aGUgcHJvYmxlbWF0aWMg c2NvcGUuCiAJCSAqLwotCQlpZiAoIW1wdGNwX2Rpc2Nvbm5lY3Qoc2ssIDApKQorCQlpZiAo IW1wdGNwX2Rpc2Nvbm5lY3Qoc2ssIDApKSB7CisJCQlzay0+c2tfZGlzY29ubmVjdHMrKzsK IAkJCXNrLT5za19zb2NrZXQtPnN0YXRlID0gU1NfVU5DT05ORUNURUQ7CisJCX0KIAl9CiAJ aW5ldF9jbGVhcl9iaXQoREVGRVJfQ09OTkVDVCwgc2spOwogCkBAIC0zMjA4LDYgKzMyMjAs NyBAQCBzdGF0aWMgaW50IG1wdGNwX2Rpc2Nvbm5lY3Qoc3RydWN0IHNvY2sgKnNrLCBpbnQg ZmxhZ3MpCiAJaWYgKG1zay0+ZmFzdG9wZW5pbmcpCiAJCXJldHVybiAtRUJVU1k7CiAKKwlt c2stPmRpc2Nvbm5lY3RzKys7CiAJbXB0Y3BfY2hlY2tfbGlzdGVuX3N0b3Aoc2spOwogCW1w dGNwX3NldF9zdGF0ZShzaywgVENQX0NMT1NFKTsKIApkaWZmIC0tZ2l0IGEvbmV0L21wdGNw L3Byb3RvY29sLmggYi9uZXQvbXB0Y3AvcHJvdG9jb2wuaAppbmRleCA3MzUyNmYxZDc2OGYu LjU5YTZlNTJmMDJhNCAxMDA2NDQKLS0tIGEvbmV0L21wdGNwL3Byb3RvY29sLmgKKysrIGIv bmV0L21wdGNwL3Byb3RvY29sLmgKQEAgLTM0MCw2ICszNDAsNyBAQCBzdHJ1Y3QgbXB0Y3Bf c29jayB7CiAJCXU2NAlydHRfdXM7IC8qIGxhc3QgbWF4aW11bSBydHQgb2Ygc3ViZmxvd3Mg Ki8KIAl9IHJjdnFfc3BhY2U7CiAJdTgJCXNjYWxpbmdfcmF0aW87CisJdTE2CQlkaXNjb25u ZWN0czsKIAogCXUzMgkJc3ViZmxvd19pZDsKIAl1MzIJCXNldHNvY2tvcHRfc2VxOwo= --------------QMuwEC0rishas579NE0afvxl--