From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390DBC28CC6 for ; Wed, 5 Jun 2019 08:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CDCB206B8 for ; Wed, 5 Jun 2019 08:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfFEIhj (ORCPT ); Wed, 5 Jun 2019 04:37:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:52566 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726885AbfFEIhi (ORCPT ); Wed, 5 Jun 2019 04:37:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B76D4AB87; Wed, 5 Jun 2019 08:37:37 +0000 (UTC) Subject: Re: [PATCH v2 3/3] xen/swiotlb: remember having called xen_create_contiguous_region() To: Christoph Hellwig Cc: Boris Ostrovsky , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Konrad Rzeszutek Wilk , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20190529090407.1225-1-jgross@suse.com> <20190529090407.1225-4-jgross@suse.com> <20190530090409.GB30428@infradead.org> <2fbfc6a7-572c-1ce2-3323-802f9a77500e@suse.com> From: Juergen Gross Message-ID: <0fcd8b61-7714-2278-e552-f0b72d9c5d1a@suse.com> Date: Wed, 5 Jun 2019 10:37:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2fbfc6a7-572c-1ce2-3323-802f9a77500e@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.05.19 13:38, Juergen Gross wrote: > On 30/05/2019 14:46, Boris Ostrovsky wrote: >> On 5/30/19 5:04 AM, Christoph Hellwig wrote: >>> Please don't add your private flag to page-flags.h. The whole point of >>> the private flag is that you can use it in any way you want withou >>> touching the common code. >> >> >> There is already a bunch of aliases for various sub-components >> (including Xen) in page-flags.h for private flags, which is why I >> suggested we do the same for the new use case. Adding this new alias >> will keep flag usage consistent. > > What about me adding another patch moving those Xen private aliases > into arch/x86/include/asm/xen/page.h ? This is becoming difficult. I'd need to remove the "#undef PF_NO_COMPOUND" from page-flags.h or to #include a (new) xen/page-flags.h from page-flags.h after all the defines are ready. Is that really worth the effort given that other components (e.g. file systems) are doing the same? Juergen