From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA9BC433EF for ; Wed, 11 May 2022 15:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245688AbiEKPQt (ORCPT ); Wed, 11 May 2022 11:16:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245657AbiEKPQl (ORCPT ); Wed, 11 May 2022 11:16:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B12CE20793F for ; Wed, 11 May 2022 08:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652282198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8tAHsUaXeH5aIreYrSE446zf4Y+7VPnOdSUL2jWESc=; b=UMHMJkYkb/r8N6bs98WVRdU0R6T8xrGwIzAF0PIR2cF6JB0lmGfs0GPYabxd0WaSgbpN2x tu7+Thb3ULo2Gm88KKr5ro39ocqffezwiXa9yckfVZr99t7jC9uGhqeuqoHrZ7Y69Y4aNR LnPwV6EXFjL6/kkx/e0N+Mstc6cFUJI= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-XyVfF8vtN02BPUzMMxBJDQ-1; Wed, 11 May 2022 11:16:37 -0400 X-MC-Unique: XyVfF8vtN02BPUzMMxBJDQ-1 Received: by mail-ed1-f69.google.com with SMTP id ch28-20020a0564021bdc00b00425cb227ab4so1531508edb.4 for ; Wed, 11 May 2022 08:16:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=C8tAHsUaXeH5aIreYrSE446zf4Y+7VPnOdSUL2jWESc=; b=RyuNP72AcvRdRLIuoe3Bje6wy/9cINg1ByBKsnQGN4wROFv6YVrMNbOJmRDVxKLWxP XC8P2gMIix7YK4R8icr2OJ/P56vwhOiShLuC1DOmQ1DJlhG36i5XjOh3IFuoNpocBL4Q Xtko4BNwQG20Zi108iuwTjI7ft7I4ncjBJ7gZzS/lG5lGHsCzgJ7bWfOz8vHPV6tLUbw 7/YpQM3tXRRycVxojSWSku3d3WjeHwBIE38SH5jl1CQkOHjp+2m+h19kn6VSOOtCtV8j fQZFOMYQfVFPmy+B+NRK+EIl9tcLXvOBUlMj/XXFk5RXb2ED4MFPawOaj48Ya4cTFacd XgpA== X-Gm-Message-State: AOAM533uIg5rxAhuXCp4Yd6NrE/eM3wlFYzPFnGjNP5hUBLRiju7ZSEB fJZAcZ7ZimOpdl9uTs7exjAVsTiSDfS6bohZaklS54qhwihiyLv8U1Nz8xfaT2QKYxyohNA4ce/ nJXOcqQhK4qfPoTuOiODmPZm7 X-Received: by 2002:a17:906:12d3:b0:6f5:18a2:176d with SMTP id l19-20020a17090612d300b006f518a2176dmr24604261ejb.474.1652282195839; Wed, 11 May 2022 08:16:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzalPzBW9scyTGP9Q/0WkNxbU8XCq0kzYWjoozZOJHhRlViijcXgZrS+QybEUs+6GrMAmCjOQ== X-Received: by 2002:a17:906:12d3:b0:6f5:18a2:176d with SMTP id l19-20020a17090612d300b006f518a2176dmr24604212ejb.474.1652282195328; Wed, 11 May 2022 08:16:35 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id lz6-20020a170906fb0600b006f3ef214db5sm1128878ejb.27.2022.05.11.08.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 08:16:34 -0700 (PDT) Message-ID: <0fd2b4d0-e219-2e47-dd39-f73076e1eb9a@redhat.com> Date: Wed, 11 May 2022 17:16:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/2] platform/x86: asus-wmi: Update unknown code message Content-Language: en-US To: Luca Stefani Cc: Corentin Chary , Mark Gross , "open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS" , "open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS" , open list References: <20220506122536.113566-1-luca.stefani.ge1@gmail.com> From: Hans de Goede In-Reply-To: <20220506122536.113566-1-luca.stefani.ge1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/6/22 14:25, Luca Stefani wrote: > Prepend 0x to the actual key code to specify it > is already an hex value > > Signed-off-by: Luca Stefani Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 0e7fbed8a50d..35fe9641ba9b 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -3114,7 +3114,7 @@ static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus) > > if (!sparse_keymap_report_event(asus->inputdev, code, > key_value, autorelease)) > - pr_info("Unknown key %x pressed\n", code); > + pr_info("Unknown key code 0x%x\n", code); > } > > static void asus_wmi_notify(u32 value, void *context)