From: Roger Quadros <rogerq@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, s-vadapalli@ti.com, r-gunasekaran@ti.com,
srk@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Pekka Varis <p-varis@ti.com>
Subject: Re: [PATCH net-next 2/3] net: ethernet: am65-cpsw: Set default TX channels to maximum
Date: Tue, 14 Nov 2023 22:16:45 +0200 [thread overview]
Message-ID: <0fe29f0c-5418-49a6-ab62-f210f8f7e765@kernel.org> (raw)
In-Reply-To: <20231114121343.o3nk3lddzy57mqgw@skbuf>
On 14/11/2023 14:13, Vladimir Oltean wrote:
> On Mon, Nov 13, 2023 at 01:07:07PM +0200, Roger Quadros wrote:
>> am65-cpsw supports 8 TX hardware queues. Set this as default.
>
> Motivation? Drawbacks / reasons why this was not done from the beginning?
Motivation was to get the "kselftest -t net/forwarding:ethtool_mm.sh" test to work
without requiring additional manual step of increasing the TX channels.
Another issue is that all network interfaces (can be up to 4 on some devices) have to be
brought down if TX channel count needs to change.
I am not aware why this was not done from the beginning.
--
cheers,
-roger
next prev parent reply other threads:[~2023-11-14 20:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:07 [PATCH net-next 0/3] net: ethernet: am65-cpsw: Add ethtool standard MAC stats Roger Quadros
2023-11-13 11:07 ` [PATCH net-next 1/3] net: ethernet: am65-cpsw: Add standard Ethernet MAC stats to ethtool Roger Quadros
2023-11-13 13:26 ` Andrew Lunn
2023-11-13 16:42 ` Simon Horman
2023-11-14 12:06 ` Roger Quadros
2023-11-13 11:07 ` [PATCH net-next 2/3] net: ethernet: am65-cpsw: Set default TX channels to maximum Roger Quadros
2023-11-13 13:26 ` Andrew Lunn
2023-11-14 12:13 ` Vladimir Oltean
2023-11-14 20:16 ` Roger Quadros [this message]
2023-11-13 11:07 ` [PATCH net-next 3/3] net: ethernet: am65-cpsw: Error out if Enable TX/RX channel fails Roger Quadros
2023-11-13 13:27 ` Andrew Lunn
2023-11-14 12:07 ` Vladimir Oltean
2023-11-14 19:53 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe29f0c-5418-49a6-ab62-f210f8f7e765@kernel.org \
--to=rogerq@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p-varis@ti.com \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®