From: Waiman Long <llong@redhat.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>,
akpm@linux-foundation.org, hch@infradead.org, llong@redhat.com,
xavier_qy@163.com
Cc: lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org,
mkoutny@suse.com, jserv@ccns.ncku.edu.tw,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH] lib/Makefile: Make union-find compilation conditional on CONFIG_CPUSETS
Date: Wed, 9 Oct 2024 12:43:05 -0400 [thread overview]
Message-ID: <0fefd06c-58f7-4771-a811-ec26ab268526@redhat.com> (raw)
In-Reply-To: <20241009154022.2432662-1-visitorckw@gmail.com>
On 10/9/24 11:40 AM, Kuan-Wei Chiu wrote:
> Currently, cpuset is the only user of the union-find implementation.
> Compiling union-find in all configurations unnecessarily increases the
> code size when building the kernel without cgroup support. Modify the
> build system to compile union-find only when CONFIG_CPUSETS is enabled.
>
> Link: https://lore.kernel.org/lkml/1ccd6411-5002-4574-bb8e-3e64bba6a757@redhat.com/
> Suggested-by: Waiman Long <llong@redhat.com>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> lib/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 773adf88af41..53f82de7cbe2 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -35,8 +35,9 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
> is_single_threaded.o plist.o decompress.o kobject_uevent.o \
> earlycpio.o seq_buf.o siphash.o dec_and_lock.o \
> nmi_backtrace.o win_minmax.o memcat_p.o \
> - buildid.o objpool.o union_find.o
> + buildid.o objpool.o
>
> +lib-$(CONFIG_CPUSETS) += union_find.o
> lib-$(CONFIG_PRINTK) += dump_stack.o
> lib-$(CONFIG_SMP) += cpumask.o
>
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2024-10-09 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 15:40 Kuan-Wei Chiu
2024-10-09 16:43 ` Waiman Long [this message]
2024-10-09 16:44 ` Tejun Heo
2024-10-10 9:38 ` Christoph Hellwig
2024-10-11 14:12 ` [PATCH v2] " Kuan-Wei Chiu
2024-10-14 5:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fefd06c-58f7-4771-a811-ec26ab268526@redhat.com \
--to=llong@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
--cc=visitorckw@gmail.com \
--cc=xavier_qy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®