From: Guenter Roeck <linux@roeck-us.net>
To: "John B. Wyatt IV" <jwyatt@redhat.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-pm@vger.kernel.org, Thomas Renninger <trenn@suse.com>,
Shuah Khan <shuah@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, John Kacur <jkacur@redhat.com>,
Tomas Glozar <tglozar@redhat.com>, Arnaldo Melo <acme@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"John B. Wyatt IV" <sageofredondo@gmail.com>
Subject: Re: [PATCH v3 2/4] pm:cpupower: Add SWIG bindings files for libcpupower
Date: Sat, 21 Sep 2024 14:23:07 -0700 [thread overview]
Message-ID: <0ff4937d-0e51-4d67-9b8a-d2bf1bebe1fb@roeck-us.net> (raw)
In-Reply-To: <20240905021916.15938-3-jwyatt@redhat.com>
Hi,
On Wed, Sep 04, 2024 at 10:19:09PM -0400, John B. Wyatt IV wrote:
> SWIG is a tool packaged in Fedora and other distros that can generate
> bindings from C and C++ code for several languages including Python,
> Perl, and Go.
>
> These bindings allows users to easily write scripts that use and extend
> libcpupower's functionality. Currently, only Python is provided in the
> makefile, but additional languages may be added if there is demand.
>
> Added suggestions from Shuah Khan for the README and license discussion.
>
> Note that while SWIG itself is GPL v3+ licensed; the resulting output,
> the bindings code, is permissively licensed + the license of the .o
> files. Please see
> https://swig.org/legal.html and [1] for more details.
>
> [1]
> https://lore.kernel.org/linux-pm/Zqv9BOjxLAgyNP5B@hatbackup/
>
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: John B. Wyatt IV <jwyatt@redhat.com>
> Signed-off-by: John B. Wyatt IV <sageofredondo@gmail.com>
> ---
>
> Changes in v3:
> - Reordered patch series for cpupower stub implementation to be
> first.
> - Added pm:cpupower prefix to header and Rafael to Cc.
>
> Changes in v2:
> - Implemented the function so SWIG will accept the header
> definition
> ---
> .../power/cpupower/bindings/python/.gitignore | 8 +
> tools/power/cpupower/bindings/python/Makefile | 31 +++
> tools/power/cpupower/bindings/python/README | 59 +++++
> .../bindings/python/raw_pylibcpupower.i | 247 ++++++++++++++++++
> 4 files changed, 345 insertions(+)
> create mode 100644 tools/power/cpupower/bindings/python/.gitignore
> create mode 100644 tools/power/cpupower/bindings/python/Makefile
> create mode 100644 tools/power/cpupower/bindings/python/README
> create mode 100644 tools/power/cpupower/bindings/python/raw_pylibcpupower.i
This file is deleted when running "make mrproper".
$ git reset --hard HEAD
$ make mrproper
$ git status
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
deleted: tools/power/cpupower/bindings/python/raw_pylibcpupower.i
That is a bit more than annoying when trying to switch branches after
that happened.
Guenter
next prev parent reply other threads:[~2024-09-21 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 2:19 [PATCH v3 0/4] Add SWIG Bindings to libcpupower John B. Wyatt IV
2024-09-05 2:19 ` [PATCH v3 1/4] pm:cpupower: Add missing powercap_set_enabled() stub function John B. Wyatt IV
2024-09-05 2:19 ` [PATCH v3 2/4] pm:cpupower: Add SWIG bindings files for libcpupower John B. Wyatt IV
2024-09-21 21:23 ` Guenter Roeck [this message]
2024-09-22 15:39 ` Linus Torvalds
2024-09-23 13:29 ` John B. Wyatt IV
2024-09-23 16:09 ` Shuah Khan
2024-09-05 2:19 ` [PATCH v3 3/4] pm:cpupower: Include test_raw_pylibcpupower.py John B. Wyatt IV
2024-09-05 2:19 ` [PATCH v3 4/4] MAINTAINERS: Add Maintainers for SWIG Python bindings John B. Wyatt IV
2024-09-06 1:03 ` [PATCH v3 0/4] Add SWIG Bindings to libcpupower Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ff4937d-0e51-4d67-9b8a-d2bf1bebe1fb@roeck-us.net \
--to=linux@roeck-us.net \
--cc=acme@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sageofredondo@gmail.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglozar@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®