From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 595C42EC08C for ; Wed, 7 Jan 2026 12:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767788212; cv=none; b=N/Is3P1bCvETggbbXrod1NN9+VQlFgtQjt8oRgLGA3FI9e59DzKIGPdU5ujXJOZRuQI/8bGxMewgn2Rd7S97UERYymPvuN4HnI9m1lt0Tiebw8frX2MRKbJh0jRFEZ/jrtnByByK9JL92Rmdo9GIPmUdhQBHs+DqC41zJNUEDKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767788212; c=relaxed/simple; bh=NjGfYThFux0yY5RSyrwt2i1Ek9JVno/OrKe540SAtak=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VoB4paT2ThR2fa+Lg3o3KrHDEdeveFG3so5AEuhI2HwkIf+ybVdnbMu6vIoLX0Wk9s6taDllgN6Wl0hYVv600zpEC/iOCmoZ5hahSJAl/S62wHc/UZUAjKmiPkBTDG0p0T4y4BVDURh9DAH7nZEJxttXqdOjFg3gEEl/rw6EYpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h3J7M3bp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XcUnomYV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h3J7M3bp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XcUnomYV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 607ALXL43888893 for ; Wed, 7 Jan 2026 12:16:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d55j32hYpW4S+x8R8th4vTayuLxbVkuWG4hN8s1Dfnc=; b=h3J7M3bpOCEvKjJ5 hwjNb274pY01CAOLPg8h63hhH76T28kFq22c/sYwHaX7Ub2MdTpFWgrSeo7EEy+h pneR5DQjWm0a+k50A0w/84IvFi4qvbMTz7wYGvaI7L7Y8MxLV+oO/Cn4xtgtazRc F96V3/U+nJqO4gsHMudnhvbG/Yla3MT0xU4yPEEai7zE4NfMsWSd5aFGqPrCQbN1 3G6UTCaSOWbuAHv+aTki5V9cqwsOMj4Oec8WabXmPIQ4vCpf6HhRZhnBUvAfJtuV JYa2pZ1f9AhRZYZLs4gF62U7qXzbZdmsJgs5tqhdApb/O4s10PVsa8GoRovXQiBC FJrQBw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bh6a0k8db-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 12:16:50 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f1e17aa706so8056961cf.2 for ; Wed, 07 Jan 2026 04:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767788210; x=1768393010; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d55j32hYpW4S+x8R8th4vTayuLxbVkuWG4hN8s1Dfnc=; b=XcUnomYVJP2/neV3PwGde3mUPOP17d3a/RbblG1hf32HOLoqrvBq2X8ww28g8BHLsY VyYJ/VyNc+yxdUB+jxpwd1qn5yYBZDmug0HXXdvb6OaQlq8OEWiJfwtoC/Wj2dvsUZDN JynnD/Kab7TUBLd3zC39QuyQvteHyiG5HzPQ9eJUWs+9lltT9Nj6lqgavbwEqxpYeV3F iw9pCFo26hR83WKKpo/iLUITcOH4pnbd3t0czyvuGQ13zLSbcqIiU7i0htLR0BiOmzC6 7m5LxIOONnYItvAXs7BUelI01ppVety19uyieLwXGzKCOjh60h6m8we25puaDrPaHhSs +gWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767788210; x=1768393010; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d55j32hYpW4S+x8R8th4vTayuLxbVkuWG4hN8s1Dfnc=; b=ubvz6guN1YiPfoXM/blX+jl+Dyp7MZwMV2lWwaCJfrZAWIDrxfhc1zky3OTQpZFXAF UNrylHWm/GK1dIYlIPh2tEF+R9e9qJGs03w0fRhSu+XjLP6jKaTilQUV05shq+DBomCg 9oHWiQABoRsf0xBqhynaUEJFUgotVlVvD2BesRVePGbmPQtC01Bq8zXAuvRJc9/SUtim O1JgewhWQ1OM/ZpN1ZukaSViajImjJef6tDww5e/VP9b6FwwIi3us4IX9wu1OsGBm3kx BEXwKNDnHvrkq4l8/gssDDj7GFEuN3s4jXeNk7ROfSzPd1pE98WU0RCjhR/hEFOMkLJL Nhgg== X-Forwarded-Encrypted: i=1; AJvYcCWj9DEF+P1O20uzOHohR4NUKIM05YTKbzx4u0AGyilP4Lf8EvNgMAHOI9XLfNd0ELBFf78PnxmSa97D3+s=@vger.kernel.org X-Gm-Message-State: AOJu0YwWKEjULeZFox9FAoD/deMTyw9nOhqFlJsSamcc7LXplrtmV5SS j5Z+RzTi/Afx5JEUhJks6xUHRyjiuqfJolprHRH4eldUUymhmIbb1Iqluv8XzugCFZSHnY+xtJD DKKwaLRQXHdtrDz2QVMuMal1tNshGLNc9woKnlIS8Ar7FrmyE1tVZFVkAfqA/+WeGkC4= X-Gm-Gg: AY/fxX6KrAAlGoZL7XPN2W3vuHZDuqWSrvXzLWB99KUbBwe4cMxNoTdUbeY4RzJmMLM aedavcNhTUHndH1htPV5PSLdAhwqEbnvh2DiQTtmET9GikUzXbM3ZanILKHu7sC5YXXi01M+g6L sKNs0gC6ARYJ3uNq4x9x1eAphYSAgDw1BWSlH4Z9/ArWolo/QIU9s1eUI8IXwxGM34b2ZvGDQJ3 fa+sA5hZpEJlJ0Y3qPGKm+Tzo/ZGEqnj7JkWkm6rBOsKWcSOmpDtpP834+ekR47hBXfEFSS6cU9 nr3pyzaLhAHLkeRoNVidsehgZiQi4MRLQB4A+9PLBksLQHOigVzYzDmjXGH1exfexHxfvyNqmPr HB57PmzjlQsX7v8KgKXfH6sWI0x9QmKZGswQUOAz18rkd5f4k3xFtR2I1MerrwcgoYXo= X-Received: by 2002:a05:622a:1347:b0:4f1:dffa:7834 with SMTP id d75a77b69052e-4ffb49a02a0mr21372201cf.7.1767788209640; Wed, 07 Jan 2026 04:16:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUS4ix100WivikbOS3qGiN8osG7zEalwH/GRaCRfETPDly8syMlLkh+ICwAI7jDOvlay399w== X-Received: by 2002:a05:622a:1347:b0:4f1:dffa:7834 with SMTP id d75a77b69052e-4ffb49a02a0mr21371921cf.7.1767788209114; Wed, 07 Jan 2026 04:16:49 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a511551sm486275966b.53.2026.01.07.04.16.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 04:16:48 -0800 (PST) Message-ID: <0ff8041a-c876-419e-8f18-7656e29549a3@oss.qualcomm.com> Date: Wed, 7 Jan 2026 13:16:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] clk: qcom: cmnpll: Account for reference clock divider To: Luo Jie , Bjorn Andersson , Michael Turquette , Stephen Boyd , Luo Jie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_pavir@quicinc.com, quic_suruchia@quicinc.com References: <20260106-qcom_ipq5332_cmnpll-v2-0-f9f7e4efbd79@oss.qualcomm.com> <20260106-qcom_ipq5332_cmnpll-v2-1-f9f7e4efbd79@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260106-qcom_ipq5332_cmnpll-v2-1-f9f7e4efbd79@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: RmZ_nX7UUKbzAXbYBdVVa6Bf_hU1B3lW X-Proofpoint-GUID: RmZ_nX7UUKbzAXbYBdVVa6Bf_hU1B3lW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDA5NSBTYWx0ZWRfX9IylXCoorY+g zML1PU4UwFpZvXJjYwD4jsaSOtnRR+GJGiQ+id3fGfLcYVaQ7JGzzkIhPl15Ep3sZbDqIbZmpdM PVYIjui6umVLOWSPlojUwRe4WCzAWlFtuJcHypMaToQOfypyR6iVu+zoqSCcC8AkcG77BQpEd2o sNLndpE7zrWLMsqBz6J8LdYvRzgFA3PxpBypZKaJtXSoIBO+cDHMKyaT+oBBw9ikPz4LWtbye4F Nn1AE7fzke6PbU8YtMiTM/DPfS8nPhwSS/XZUVCujJKoL5aXjYpCxmSXPoyg0YBMWVkLGJHI4Md RCcbUDiQJ/4ba5WcPr5jIaC2RzqIQBDezuLfKP/Mhy0xU0c0ayw9YTdRLioDn54oMJ4fziETsNz iysPjWK45COq6VzgJqxNa5R9ezMgxZMkZy8poBPfqunFl2jzED9fglM/FfmBkGai/ZahNfmw14C eYRvd43O2YdIM5GF3LQ== X-Authority-Analysis: v=2.4 cv=MtdfKmae c=1 sm=1 tr=0 ts=695e4eb2 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=QfgEeMFAfvcTqVishicA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070095 On 1/7/26 6:35 AM, Luo Jie wrote: > The clk_cmn_pll_recalc_rate() function must account for the reference clock > divider programmed in CMN_PLL_REFCLK_CONFIG. Without this fix, platforms > with a reference divider other than 1 calculate incorrect CMN PLL rates. > For example, on IPQ5332 where the reference divider is 2, the computed rate > becomes twice the actual output. > > Read CMN_PLL_REFCLK_DIV and divide the parent rate by this value before > applying the 2 * FACTOR scaling. This yields the correct rate calculation: > rate = (parent_rate / ref_div) * 2 * factor. > > Maintain backward compatibility with earlier platforms (e.g. IPQ9574, > IPQ5424, IPQ5018) that use ref_div = 1. > > Fixes: f81715a4c87c ("clk: qcom: Add CMN PLL clock controller driver for IPQ SoC") > Signed-off-by: Luo Jie > --- > drivers/clk/qcom/ipq-cmn-pll.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/ipq-cmn-pll.c b/drivers/clk/qcom/ipq-cmn-pll.c > index dafbf5732048..369798d1ce42 100644 > --- a/drivers/clk/qcom/ipq-cmn-pll.c > +++ b/drivers/clk/qcom/ipq-cmn-pll.c > @@ -185,7 +185,7 @@ static unsigned long clk_cmn_pll_recalc_rate(struct clk_hw *hw, > unsigned long parent_rate) > { > struct clk_cmn_pll *cmn_pll = to_clk_cmn_pll(hw); > - u32 val, factor; > + u32 val, factor, ref_div; > > /* > * The value of CMN_PLL_DIVIDER_CTRL_FACTOR is automatically adjusted > @@ -193,8 +193,15 @@ static unsigned long clk_cmn_pll_recalc_rate(struct clk_hw *hw, > */ > regmap_read(cmn_pll->regmap, CMN_PLL_DIVIDER_CTRL, &val); > factor = FIELD_GET(CMN_PLL_DIVIDER_CTRL_FACTOR, val); > + if (WARN_ON(factor == 0)) > + factor = 1; FWIW the docs tell me the value of this field is '192' on IPQ5332.. Konrad