From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794350135; b=WW5FKsz7JGYJmcyZb58UD4lD958RIeO9hmLC4i/DE/dOSvUkoqLQi6bRRbktNDn0cwXa HGZlqJWD6Qt4HAIGrfr9zYN9H9GaQ/N19PG4gmsv87YMpUm4U5CS4dCocY0xDhRzDJNpb TCK9c/CpZnzGG1lKNhw+EjLGkez08qgZMD8K359ALqHY4bqCPapv66ZhLASDsdr7uVZbG A+o2WdkMjOmldTEfTiiq9XW5mWBTbdEFjnBESkoZZ2JuCU+rewmsvFbtti23bNqKuPNHy tpHjbjMNipIKyHVAUx6ZMP+I/iqD0bACsO6NMFZKfSjrHQwNhpkIJlmAHMeIktRmclQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794350135; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=WUUdei9e97lDlcy3f/sZAzpE00dIzzVutyh3SNWyTyI=; b=ZeLjrnAF5mK66SJj2tanr0cq22u1PADckaGH8wao51WGAeR9hgr31Hk9RWag58IVNP7M 6IAsCNbU8uQz8Cm+FcJ6A7Frmy+t24lBMvv/KieGHvlPa1olydmT+OE3QGYRAfirmLvvO 5jKDtei8MdXXB6JwxedDxWLsfm9+7SDlmaHt8FzTCSG7K6eWrY9YT18SF8W+okOV32m0f SicXQ1JWa/3rowUU4GT6l3E2EaBcLco+RTiCY2S1y31UjKxnDUdinW/hxhXTtOQbF44k4 sjZMIqlDcd3poCW0NlutVaOfKDzq6SfKlaem7McpCF7vLPEEMpbzB/YM9Fi4zPPtowA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="PAta/XlA"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3543B606A320 for ; Tue, 10 Nov 2026 22:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PAta/XlA Received: by smtp.kernel.org (Postfix) with ESMTPSA id 083E01F008AB; Tue, 10 Nov 2026 22:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794350134; bh=WUUdei9e97lDlcy3f/sZAzpE00dIzzVutyh3SNWyTyI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PAta/XlAf5KTDd2yv4rcAqgfaYY3FVC82tN59/JriIBEANJRFOOl2e2qBr+2Hz8QQ xcA+4ranrOcQGshLRsJWdvWw7BfIBeC4h19GP1ywRJWCguqcRoWYpLAcmqQxqXtYzZ PwOPRL/dhzR6/bx8HQmIvgCn70YfpYKsrabVhVLj91kdR0cpCXxQWuA4YEtFMLShrR B2Eaos3aMi/6xchPZmkK5fYyzlbUyKqSkqZU5hMRoFROpVbGgzXgfd0tYyToM+dUEA djZ6l00kUkKE5aBFbZFCcwfENK1xr7e3NaXMWp7DtJXN/7hX0hWssnz1+T6mzFVKaX koeDy2MJPoQvA== Message-ID: <0ff8276d-9535-449a-94b0-912651411bfe@kernel.org> Date: Tue, 10 Nov 2026 23:35:25 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages() To: Yeoreum Yun , Rik van Riel Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , John Hubbard , Peter Xu , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Yuan-Hao Hsu References: <20261109-refactor_gup_fast-v3-0-2aaef02df0e1@arm.com> <20261109-refactor_gup_fast-v3-5-2aaef02df0e1@arm.com> <7627c0d90188b581e7740bf8d17c8dd07b460f89.camel@surriel.com> <699499e46ace0875fd0f32052399e665c8209ea9.camel@surriel.com> <5db7a358c293393a93984ac3c3cc58e810edd75a.camel@surriel.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/10/26 22:27, Yeoreum Yun wrote: > On Tue, Nov 10, 2026 at 03:23:15PM -0500, Rik van Riel wrote: >> On Tue, 2026-11-10 at 20:19 +0000, Yeoreum Yun wrote: >>> >>> Hmm, Wouldn't this name be semantically much the same as keeping >>> the existing gup_unshared_page(), since both essentially convey that >>> no unsharing is required from GUP's perspective? >> >> The function measures how many pages in >> this current interval do not need to be >> unshared. >> >> I'm happy with any name, though. >> >> I would really like to just see this >> code go in, so I can post my two >> GUP series on top, first the batching >> for the GUP-slow path, and then the >> series that allows access_remote_vm() >> and friends to work under the per-VMA >> lock. > > @David, If you don't have any strong comments for original name > -- gup_unshared_page(), May I post next version with resolving other > comments so that Rik's series be posted soon? > > Otherewise, gup_skip_unshare_pages() works for me. Let me think ... Maybe just throw in: gup_pages_not_requiring_unshare A bit long, but who cares -- Cheers, David