From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752419AbdATNzh (ORCPT ); Fri, 20 Jan 2017 08:55:37 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:37258 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbdATNzX (ORCPT ); Fri, 20 Jan 2017 08:55:23 -0500 X-AuditID: b6c32a38-f79836d00000492b-c4-588216c8e081 Subject: Re: [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as CLK_IS_CRITICAL To: Javier Martinez Canillas , Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, Inki Dae , Andi Shyti , Shuah Khan , Mauro Carvalho Chehab , Marek Szyprowski , Kukjin Kim , Chanwoo Choi , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Tomasz Figa , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org From: Sylwester Nawrocki Message-id: <0ffa0d28-1086-887c-dcfc-590b6146b03e@samsung.com> Date: Fri, 20 Jan 2017 14:55:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <551ac156-0cfa-29be-335f-d8a1f171cd8a@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjmO5edozU5zlqvWonLSCW1gdBHSSYUHaIf9SMYBukpDyvSOTYT jaJpF215YxWuJVm4iqamLTO1EaGWIrFllobz8kNwWdkFE4Ts4nYm+O95vvd5eN7n5WNJhYeO Yk/qCkSDTshVyUKp9p6E5KR+Zalmm9e8Hj/rnabxyC8fjS2TNRT+OttE4OqpLyT2eFoZ7Jwa pvHPigkaD3XVybDV84LAzb3jDL7vXCTw4MBevPDmKoVv/PpBYUfXItrN8d8/XmL4oapKgu+0 jTO803FFxj+xn+fbqpdYVZsD8XPOjQfZzNC0HDH3ZKFoSNmVHXpibszE6N1sUYv7rcyEbjFm FMIClwoz7waRhJXwdqJF5scKrgPBbO0hMwpdwmUElPd00MsG26suWho8QPChoT1IJhGMXqwL 2CO4I/CupJTyD9ZwVxDctdoYPyG5aRK+PrQHAmWcGipfVQWwnNsF481PA26K2wxtM5WB97Wc Brpfe0lJEw4L1yYoPw7h0sFi6gzoSW4bWK/3EBKOgSdNs6Q/DLg/DDy+bVvaj10iG8D5kpQ6 7IGpgfFg6Qj43NcWPEY0OP6OEpK3GkF/0wUkESuCsbIaQlLthJ6+QVpKC4Nv8xXBADmUX1ZI Eh5cdm/wYBkwOLDASFf1IJi3ZNSgGNuKPrYVHWwrOtxBpAMpRb0xTysa1frUZKOQZzyt0yYf z89zosA3S8QdyOU+0I04FqlWy7NfmzQKWig0Fud1I2BJ1Rp5pqJUo5DnCMVnREN+luF0rmjs RtEspVonbyjZqVFwWqFAPCWKetGwPCXYkCgTilOlZbpaW739Y7WWkGdPt85AVqPgSrKfbSES nMOayBxfSmH4sUP3Dk8m+44qL1n3l9XFNT7a/jt2zt48t899q0hnV79/3qyP+mceUrY3RIbF bxoRYj95NufX75CFuUmut+S2b9SruabcGr931XQ9k56yeFNvOCcUxzZqdcotKsp4QlAnkgaj 8B+1g6QhYgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jAd3jYk0RBltfW1tsP/KM1eL6l+es FpPuT2CxePN2DZNF/+PXzBbnz29gt9j0+Bqrxceee6wWl3fNYbOYcX4fk8XaI3fZLZZt+sNk cfGUq8WPM90sFlO/fGCxWLXrD6ODgMf7G63sHpf7epk8ds66y+6xaVUnm8fmJfUeW/qBvL4t qxg9Pm+SC+CIcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXy jAzQgINzgHuwkr5dglvG5zsN7AXnOCrWn7vA1sA4m72LkZNDQsBEYtbRXawQtpjEhXvr2boY uTiEBJYySuxoecQE4TxklHjx4iMbSJWwQLTEpcYmFpCEiEA3o8SeiR/ZIaouMkpcP/8dbBaz wDNmiS8/E0BsNgFDid6jfYwgNq+AncTdtVvBJrEIqEpsedkLFOfgEBWIkGg4nA5RIijxY/I9 FhCbU8BeYlLDTjaQEmYBPYn7F7UgpstLbF7zlnkCo8AsJB2zEKpmIalawMi8ilEitSC5oDgp PdcwL7Vcrzgxt7g0L10vOT93EyM4rp9J7WA8uMv9EKMAB6MSD29EaGOEEGtiWXFl7iFGCQ5m JRHeKKGmCCHelMTKqtSi/Pii0pzU4kOMpkBfTGSWEk3OB6acvJJ4QxNzE3NjAwtzS0sTIyVx 3sbZz8KFBNITS1KzU1MLUotg+pg4OKUaGEuPGXk/s1YIm5529lLj8rn7pghOu7x5TszrB3tZ nNVZMl8cKrhifYS9uv/3Y9MNIk/83LYXH3+nXm36d7HcrS213ts4rjmqn9rF8texwrDJv+sR 00Ex+2Y+55xI5mOtAfccXp5vr9tS7rl1lZTujg3svnwWGwWiGx2emx+9Hcd/3NlPz0eiXIml OCPRUIu5qDgRAM56K+EBAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170120135520epcas1p3ce372fa1a6843d50efd36313da77bb91 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170120104148epcas5p11af0e630f0881092a9b3b43e8b5b1aac X-RootMTR: 20170120104148epcas5p11af0e630f0881092a9b3b43e8b5b1aac References: <1484908891-11820-1-git-send-email-javier@osg.samsung.com> <551ac156-0cfa-29be-335f-d8a1f171cd8a@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2017 01:32 PM, Sylwester Nawrocki wrote: > On 01/20/2017 11:41 AM, Javier Martinez Canillas wrote: >> On Exynos5800 SoC the SCALER block uses 2 input clocks: CLK_ACLK_300_GSCL >> and CLK_ACLK432_SCALER, so both needs to be ungated in order to access it. >> >> But Exynos5420 only has the CLK_ACLK_300_GSCL as gsc_pd clk. So just using >> this definition from exynos5420.dtsi in Exynos5800 leads to the following: > [...] >> So until a proper solution based on runtime PM gets merged, mark the clock >> as critical to prevent it to be gated. >> >> Suggested-by: Marek Szyprowski >> Signed-off-by: Javier Martinez Canillas > > Acked-by: Sylwester Nawrocki Oops, the $subject patch can be dropped since as Marek just pointed out to me the changes introduced by that patch are already included in a patch which is already in the v4.10 fixes queue: https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=318fa46cc60d37fec1e87dbf03a82aca0f5ce695 -- Thanks, Sylwester