From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755299AbcJWJJU (ORCPT <rfc822;w@1wt.eu>);
        Sun, 23 Oct 2016 05:09:20 -0400
Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57149 "EHLO
        saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752617AbcJWJJT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 23 Oct 2016 05:09:19 -0400
Subject: Re: [PATCH] iio: dac: mcp4725: fix odd_ptr_err.cocci warnings
To: Julia Lawall <julia.lawall@lip6.fr>, Tomas Novotny <tomas@novotny.cz>
References: <alpine.DEB.2.20.1610222238240.2191@hadrien>
Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Yong Li <sdliyong@gmail.com>, Akinobu Mita <akinobu.mita@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        kbuild-all@01.org
From: Jonathan Cameron <jic23@kernel.org>
Message-ID: <10011ef1-273a-80f9-b559-683ac6f68ac6@kernel.org>
Date: Sun, 23 Oct 2016 10:09:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1610222238240.2191@hadrien>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22/10/16 21:41, Julia Lawall wrote:
> PTR_ERR should access the value just tested by IS_ERR
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> 
> CC: Tomas Novotny <tomas@novotny.cz>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Looks fairly obvious to me and I want to get a pull request out
shortly so applied.

Thanks,

Jonathan
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
> Not checked at all.  This is being reported on the following tree:
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> testing
> head:   2796a310d462f73954c0ce8ffabaf4baacaecca1
> commit: e0b80def1faa901d83a7d580e8aa4ad4a512bedf [109/113] iio: dac:
> mcp4725: support voltage reference selection
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
> 
> 
>  mcp4725.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -418,7 +418,7 @@ static int mcp4725_probe(struct i2c_clie
>  	if (pdata->use_vref) {
>  		data->vref_reg = devm_regulator_get(&client->dev, "vref");
>  		if (IS_ERR(data->vref_reg)) {
> -			err = PTR_ERR(data->vdd_reg);
> +			err = PTR_ERR(data->vref_reg);
>  			goto err_disable_vdd_reg;
>  		}
>