From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbbLAThr (ORCPT ); Tue, 1 Dec 2015 14:37:47 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:60576 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbbLAThq (ORCPT ); Tue, 1 Dec 2015 14:37:46 -0500 From: Arnd Bergmann To: Mark Brown Cc: Thierry Reding , linux-kernel@vger.kernel.org, Tyler Baker Subject: Re: [PATCH] regulator: core: Ensure we lock all regulators Date: Tue, 01 Dec 2015 20:37:35 +0100 Message-ID: <10014691.6gKPjN7Tsn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151201165301.GM1929@sirena.org.uk> References: <1448988057-13965-1-git-send-email-broonie@kernel.org> <1503180.zM1PdPxpk1@wuerfel> <20151201165301.GM1929@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:S+uQgL+9ecgrDu5nq5F6PiAa+oDB4tcZ85rrogF/+He7Nu68ujc v8deMPzpw6EAEhZ3rBlo0Fk17yUuHp6zPfMnvF1KLACY1tqvHSYuf9xaga1hfuIxzSUSxQR mUGpETTXu/pm79BHklpYxbB27oJqNiRrZKS/MlwQGhHPJObDhLDO4QBk1t8I/sycFBfXRHl qCGiBaOUKZTzKm/nrbVNw== X-UI-Out-Filterresults: notjunk:1;V01:K0:uZ2UEKgRfnw=:Hoskro8bT2cLs+TO/p+Beq 3e8TwADahnX3K6CkA92LqTlRza8AVrtlMjcFOsCV45LN3xnfbd2GmwmE081FsJHOGReTEsW2p zF/JowmSn0F1xUP3VxN+9eoBWmqfa1o1gWb7gyikh8PKhYPmD76pGIg2bXalCE9ZhkLEX2vp+ Ae91DeN86XNw+h06g6uPWlSYr3YYV3aHeoa9x1AucECiQcqA2djCbp9Jwaarg8AVITENnZqTc VE41lRF/+b6mSBCFOiWndClpaJTErvAaPuIPnJvdYZUkwgEPTsygtOfNFM+VFxtpta6CIzIIj 6tmYpiJBNQcSJ31Jl7w5E6LHPZRK69VRjQHynfvi8NJ9/BYtLMN0Tz3R+LKEVYJ09ncpnBXUS 16ggZeIaM/D/Q0pne0ahgkN8G+pi6z6k8Ei/olfBgs4F9YiLMAeTRbtZdQQIpePnOR5TtsMAN EjcgV97klrZsEVRNajr/Yn0amF7bUcfr95za0IcMg2Qcmhw1S1j/I+T5xq33oqCRL+N2XBu+Y WIwFfljCVMa9cnev/1FGdPZXgr2TdzXSJUq0h5xFB6gGz3mbCt32EidiNZ06/HL+7GVYI5KQt BElkvQXQtu2K2Occ/CnG3W2rvFPLgafrZKfMb1m9S2A1i8ARk6dtNLNX4H+0O2FNRDiAuTToc jPpuoSLeBCo9IseL+dK4ZEMVKOe/74gUSVOiqIjHvS15qnKsxNtO1QnA5W4S7EvtCd62HglbS cd39T0qhf0VCEO7m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 December 2015 16:53:01 Mark Brown wrote: > On Tue, Dec 01, 2015 at 05:45:17PM +0100, Arnd Bergmann wrote: > > On Tuesday 01 December 2015 16:40:57 Mark Brown wrote: > > > > mutex_lock(&rdev->mutex); > > > - for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++) > > > + for (i = 1; rdev; rdev = rdev->supply->rdev, i++) > > > mutex_lock_nested(&rdev->mutex, i); > > > I think now we have a double lock, the initial mutex_lock() needs to > > be removed again. > > Ugh, I even made that fix before I sent but didn't actually commit it > I'm glad I'm not the only one who can screw up a trivial one-line fix to this damned function. ;-) I'm still leading with three stupid mistakes over your one though. Arnd