mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com,
	awilliam@redhat.com, lenb@kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [Patch V3 0/5] I2C ACPI operation region handler
Date: Fri, 30 May 2014 14:24:12 +0200	[thread overview]
Message-ID: <10091506.iBigojlNVE@vostro.rjw.lan> (raw)
In-Reply-To: <53881E87.9070706@intel.com>

On Friday, May 30, 2014 02:00:39 PM Lan Tianyu wrote:
> On 05/20/2014 08:59 PM, Lan Tianyu wrote:
> > ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart) operation
> > region. It allows ACPI aml code able to access such kind of devices to
> > implement some ACPI standard method.
> >
> > On the Asus T100TA, Bios use GenericSerialBus operation region to access
> > i2c device to get battery info. So battery function depends on the I2C
> > operation region support. Here is the bug link.
> > https://bugzilla.kernel.org/show_bug.cgi?id=69011
> >
> 
> Hi Wolfram:
> 	Since this version resolved all comments, it's ok for you?

BTW, patches [2-3/5] are already queued up for 3.16 as they are independent of
the i2c changes.

> 
> > Change since V2:
> >          Drop patchs of adding I2C smbus quick read/write and word/block
> > process call functions because not find machines supporting such protocols
> > so far and can't test these functions.
> >          Merge patchs of "I2C ACPI related code clear up" and "Add CONFIG_I2C_ACPI
> > config"
> > 	Patch 2: Add acpi_bus_detach_private_data() function to detach data from
> > ACPI handle and replace ACPI_ERROR() with acpi_handle_debug() to avoid some redundant
> > error log.
> >
> > Change since V1:
> >         Fix some code style issues. Change prefix i2c_acpi to acpi_i2c.
> > Move ACPI related code in the i2c core to i2c-acpi.c. Add CONFIG_I2C_ACPI
> > and make i2c core built-in when it's set to avoid i2c ACPI operation region
> > being removed.
> >
> > Lan Tianyu (5):
> >    ACPICA: Export acpi_buffer_to_resource symbol
> >    ACPI: Add acpi_bus_attach_private_data() to facilitate to attach data
> >      to ACPI handle
> >    ACPI/Thermal: Use acpi_bus_attach_private_data() to attach private
> >      data
> >    I2C/ACPI: Add i2c ACPI operation region support
> >    I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config
> >
> >   drivers/acpi/acpica/rscreate.c |   1 +
> >   drivers/acpi/bus.c             |  28 +++-
> >   drivers/acpi/thermal.c         |  11 +-
> >   drivers/i2c/Kconfig            |  18 +-
> >   drivers/i2c/Makefile           |   5 +-
> >   drivers/i2c/i2c-acpi.c         | 362 +++++++++++++++++++++++++++++++++++++++++
> >   drivers/i2c/i2c-core.c         |  97 +----------
> >   include/acpi/acpi_bus.h        |   2 +
> >   include/linux/acpi.h           |  11 ++
> >   include/linux/i2c.h            |  12 ++
> >   10 files changed, 439 insertions(+), 108 deletions(-)
> >   create mode 100644 drivers/i2c/i2c-acpi.c
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2014-05-30 12:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 12:59 Lan Tianyu
2014-05-20 12:59 ` [Patch V3 1/5] ACPICA: Export acpi_buffer_to_resource symbol Lan Tianyu
2014-05-20 21:24   ` Rafael J. Wysocki
2014-05-21  2:06     ` Lan Tianyu
2014-05-20 12:59 ` [Patch V3 2/5] ACPI: Add acpi_bus_attach_private_data() to facilitate to attach data to ACPI handle Lan Tianyu
2014-05-20 12:59 ` [Patch V3 3/5] ACPI/Thermal: Use acpi_bus_attach_private_data() to attach private data Lan Tianyu
2014-05-20 12:59 ` [Patch V3 4/5] I2C/ACPI: Add i2c ACPI operation region support Lan Tianyu
2014-06-06 22:48   ` Rafael J. Wysocki
2014-06-09  7:56     ` Mika Westerberg
2014-06-27 11:03   ` Wolfram Sang
2014-05-20 12:59 ` [Patch V3 5/5] I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI config Lan Tianyu
2014-06-27 11:03   ` Wolfram Sang
2014-06-30  1:32     ` Lan Tianyu
2014-05-20 21:25 ` [Patch V3 0/5] I2C ACPI operation region handler Rafael J. Wysocki
2014-05-21  2:16   ` Lan Tianyu
2014-05-30  6:00 ` Lan Tianyu
2014-05-30 12:24   ` Rafael J. Wysocki [this message]
2014-05-30 12:10     ` Wolfram Sang
2014-05-30 12:37       ` Lan Tianyu
2014-06-06 12:28         ` Wolfram Sang
2014-06-06 22:42           ` Rafael J. Wysocki
2014-06-24  7:02       ` Lan Tianyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10091506.iBigojlNVE@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=awilliam@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=tianyu.lan@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®