From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC0EC2D0C4 for ; Tue, 10 Dec 2019 08:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D2DF206D5 for ; Tue, 10 Dec 2019 08:48:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="C3bR0m/s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbfLJIsA (ORCPT ); Tue, 10 Dec 2019 03:48:00 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:36433 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726843AbfLJIr7 (ORCPT ); Tue, 10 Dec 2019 03:47:59 -0500 Received: from localhost (mailhub1-ext [192.168.12.233]) by localhost (Postfix) with ESMTP id 47XDGj1VPZz9tyW7; Tue, 10 Dec 2019 09:47:57 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=C3bR0m/s; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id Fd8oBSUCPelI; Tue, 10 Dec 2019 09:47:57 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 47XDGj0Pbxz9tyW5; Tue, 10 Dec 2019 09:47:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1575967677; bh=zENznlhMrznRJGWMWUM1fyRyx1+XPUaBYHrlB+Jwl+w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=C3bR0m/sd7ui2ylcf/4sLqze9kSUVlsC2nH2GGy/7SAQFUiOrwszHGjmiCVMWRuNS 0g10ccnkDpQFCCACb5AWLTX+LeG0BrGxFkEeZxDfHb3z6cIDTkzX5m2n3LOxmiqQzF r4AECHp94sRL+vM2fY+m2h96iFux0v/dJA7GHmMc= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1060E8B805; Tue, 10 Dec 2019 09:47:58 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id jVkK5NT9l2oC; Tue, 10 Dec 2019 09:47:58 +0100 (CET) Received: from po16098vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 425408B754; Tue, 10 Dec 2019 09:47:57 +0100 (CET) Subject: Re: [PATCH] sh: kgdb: Mark expected switch fall-throughs To: Kuninori Morimoto , Andrew Morton Cc: Greg Kroah-Hartman , Yoshinori Sato , Rich Felker , Daniel Thompson , Will Deacon , Douglas Anderson , Paul Burton , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, "stable@vger.kernel.org" References: <87o8wgy3ra.wl-kuninori.morimoto.gx@renesas.com> <87muc0y3q4.wl-kuninori.morimoto.gx@renesas.com> From: Christophe Leroy Message-ID: <1009e85d-882a-d43b-8936-a0b4de596aa3@c-s.fr> Date: Tue, 10 Dec 2019 08:47:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <87muc0y3q4.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/2019 08:39 AM, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following error: > > LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception': > LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=] > if (kgdb_hex2long(&ptr, &addr)) > ^ > LINUX/arch/sh/kernel/kgdb.c:269:2: note: here > case 'D': > ^~~~ > > Signed-off-by: Kuninori Morimoto > Acked-by: Daniel Thompson I guess you should also add: Fixes: ab6e570ba33d ("sh: Generic kgdb stub support.") Cc: stable@vger.kernel.org Christophe