From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org
Cc: radhey.shyam.pandey@amd.com, srinivas.goud@amd.com,
shubhrajyoti.datta@amd.com, manion05gk@gmail.com
Subject: Re: [PATCH V4 1/3] dt-bindings: Add optional gpio property to uartps node to support rs485
Date: Mon, 11 Dec 2023 11:03:10 +0100 [thread overview]
Message-ID: <100af9d8-e62d-4488-8138-fd2004454d11@linaro.org> (raw)
In-Reply-To: <20231211091159.58564-2-manikanta.guntupalli@amd.com>
On 11/12/2023 10:11, Manikanta Guntupalli wrote:
> Add optional gpio property to uartps node and reference to rs485.yaml
...
diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> index e35ad1109efc..d5dd4e92d1fb 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> @@ -46,6 +46,10 @@ properties:
> power-domains:
> maxItems: 1
>
> + rts-gpios:
> + description: Optional GPIO to control transmit/receive.
> + maxItems: 1
Why do you exactly need it here? It's already allowed, isn't it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-11 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 9:11 [PATCH V4 0/3] Add rs485 support to uartps driver Manikanta Guntupalli
2023-12-11 9:11 ` [PATCH V4 1/3] dt-bindings: Add optional gpio property to uartps node to support rs485 Manikanta Guntupalli
2023-12-11 10:03 ` Krzysztof Kozlowski [this message]
2023-12-11 9:11 ` [PATCH V4 2/3] tty: serial: uartps: Relocate cdns_uart_tx_empty to facilitate rs485 Manikanta Guntupalli
2023-12-11 9:11 ` [PATCH V4 3/3] tty: serial: uartps: Add rs485 support to uartps driver Manikanta Guntupalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100af9d8-e62d-4488-8138-fd2004454d11@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®